NetBSD Problem Report #45682

From yamt@NetBSD.org  Mon Dec  5 08:25:12 2011
Return-Path: <yamt@NetBSD.org>
Received: by www.NetBSD.org (Postfix, from userid 1270)
	id 6050763B9C6; Mon,  5 Dec 2011 08:25:12 +0000 (UTC)
Message-Id: <20111205082512.6050763B9C6@www.NetBSD.org>
Date: Mon,  5 Dec 2011 08:25:12 +0000 (UTC)
From: yamt@NetBSD.org
Reply-To: yamt@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: indent improvements from pg_bsd_indent
X-Send-Pr-Version: 3.95

>Number:         45682
>Category:       bin
>Synopsis:       indent improvements from pg_bsd_indent
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 05 08:30:00 +0000 2011
>Closed-Date:    Sun Mar 13 20:12:47 +0000 2022
>Last-Modified:  Sun Mar 13 20:12:47 +0000 2022
>Originator:     YAMAMOTO Takashi
>Release:        NetBSD current
>Organization:

>Environment:


>Description:
	PostgreSQL has a fork of our indent.
	at least some of their changes are worth to incorporate.
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/tools/pgindent/indent.bsd.patch;hb=HEAD
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Alistair Crooks <agc@pkgsrc.org>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: bin/45682: indent improvements from pg_bsd_indent
Date: Fri, 9 Dec 2011 21:26:58 +0100

 On Mon, Dec 05, 2011 at 08:30:00AM +0000, yamt@NetBSD.org wrote:
 > >Description:
 > 	PostgreSQL has a fork of our indent.
 > 	at least some of their changes are worth to incorporate.
 > http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/tools/pgindent/indent.bsd.patch;hb=HEAD

 At least the source I looked at was written in perl. I'm sure there are
 things that we could take (// style comments, for a start :-)), but I
 don't think it's a 1:1 mapping.

 Thanks for the heads-up, though.

 Best,
 Alistair

From: yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi)
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, yamt@NetBSD.org
Subject: Re: bin/45682: indent improvements from pg_bsd_indent
Date: Wed, 11 Jan 2012 00:01:21 +0000 (UTC)

 >  On Mon, Dec 05, 2011 at 08:30:00AM +0000, yamt@NetBSD.org wrote:
 >  > >Description:
 >  > 	PostgreSQL has a fork of our indent.
 >  > 	at least some of their changes are worth to incorporate.
 >  > http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/tools/pgindent/indent.bsd.patch;hb=HEAD
 >  
 >  At least the source I looked at was written in perl. I'm sure there are
 >  things that we could take (// style comments, for a start :-)), but I
 >  don't think it's a 1:1 mapping.

 perl?  the source you looked was a wrong one, i guess.
 have you followed the above URL?

 YAMAMOTO Takashi

 >  
 >  Thanks for the heads-up, though.
 >  
 >  Best,
 >  Alistair

From: Alistair Crooks <agc@pkgsrc.org>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: gnats-bugs@NetBSD.org, gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org,
        yamt@NetBSD.org
Subject: Re: bin/45682: indent improvements from pg_bsd_indent
Date: Wed, 11 Jan 2012 01:25:12 +0100

 On Wed, Jan 11, 2012 at 12:01:21AM +0000, YAMAMOTO Takashi wrote:
 > >  On Mon, Dec 05, 2011 at 08:30:00AM +0000, yamt@NetBSD.org wrote:
 > >  > >Description:
 > >  > 	PostgreSQL has a fork of our indent.
 > >  > 	at least some of their changes are worth to incorporate.
 > >  > http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/tools/pgindent/indent.bsd.patch;hb=HEAD
 > >  
 > >  At least the source I looked at was written in perl. I'm sure there are
 > >  things that we could take (// style comments, for a start :-)), but I
 > >  don't think it's a 1:1 mapping.
 > 
 > perl?  the source you looked was a wrong one, i guess.
 > have you followed the above URL?

 Ah, I think we're talking about different things: I was looking at:

 	http://people.planetpostgresql.org/andrew/index.php?/archives/193-pgindent-makeover.html

 and

 	https://github.com/adunstan/pgindent

 Thanks,
 Alistair

State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Sun, 13 Mar 2022 20:12:47 +0000
State-Changed-Why:
The indent from PostgreSQL is largely based on FreeBSD indent, which was
imported on 2019-04-04 into NetBSD.  This import resulted in so many new
and unexpected bugs that I rewrote large parts of NetBSD indent and
decoupled it from FreeBSD indent.  I have no plans of importing any
future changes from FreeBSD, as long as their test suite is so minimal
that they don't notice when a change breaks everything else in obvious
ways.


>Unformatted:

Home	PR Database Search