NetBSD Problem Report #45727

From www@NetBSD.org  Tue Dec 20 22:17:22 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9A8A663C3DB
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Dec 2011 22:17:22 +0000 (UTC)
Message-Id: <20111220221721.EC15963BB83@www.NetBSD.org>
Date: Tue, 20 Dec 2011 22:17:21 +0000 (UTC)
From: noud4@home.nl
Reply-To: noud4@home.nl
To: gnats-bugs@NetBSD.org
Subject: misc/openoffice3 does not build with PKG_OPTIONS.openoffice3+=-xulrunner
X-Send-Pr-Version: www-1.0

>Number:         45727
>Category:       pkg
>Synopsis:       misc/openoffice3 does not build with PKG_OPTIONS.openoffice3+=-xulrunner
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 20 22:20:00 +0000 2011
>Closed-Date:    Sat Jul 07 13:05:17 +0000 2018
>Last-Modified:  Sat Jul 07 13:05:17 +0000 2018
>Originator:     B.ICT A.P. deBROUWER Jr.
>Release:        5.1
>Organization:
-none-
>Environment:
NetBSD host066.template 5.1 NetBSD 5.1 (GENERIC) #0: Sun Nov  7 14:39:56 UTC 2010  builds@b6.netbsd.org:/home/builds/ab/netbsd-5-1-RELEASE/i386/201011061943Z-obj/home/builds/ab/netbsd-5-1-RELEASE/src/sys/arch/i386/compile/GENERIC i386
>Description:
3 weeks ago openoffice3/patches/patch-ae changed and did make NPP_GetMIMEDescription into a constant.

now if build with:
PKG_OPTIONS.openoffice3+=-xulrunner
(so using openoffices own mozilla things) we get:

/obj/misc/openoffice3/work/OOO310_m19/extensions/source/nsplugin/source/npshell.cxx:406: error:
declaration of C function 'const char* NPP_GetMIMEDescription()' conflicts with
/obj/misc/openoffice3/work/OOO310_m19/solver/310/unxbsdi3.pro/inc/npsdk/npapi.h:539: error:
previous declaration 'char* NPP_GetMIMEDescription()' here
>How-To-Repeat:
echo 'PKG_OPTIONS.openoffice3+=-xulrunner'>>${PKGMAKECONF}/mk.conf
cd pkgsrc/misc/openoffice3 && make
>Fix:
$NetBSD$

--- np_sdk/mozsrc/npapi.h.orig        2011-12-20 15:38:28.000000000 +0000
+++ np_sdk/mozsrc/npapi.h     2011-12-20 15:38:59.000000000 +0000
@@ -536,7 +536,7 @@
  * NPP_* functions are provided by the plugin and called by the navigator.
  */

-char* NPP_GetMIMEDescription(void);
+const char* NPP_GetMIMEDescription(void);

 NPError NP_LOADDS NPP_Initialize(void);
 void    NP_LOADDS NPP_Shutdown(void);

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45727: misc/openoffice3 does not build with
 PKG_OPTIONS.openoffice3+=-xulrunner
Date: Wed, 21 Dec 2011 05:48:32 +0000

 On Tue, Dec 20, 2011 at 10:20:00PM +0000, noud4@home.nl wrote:
  > >Description:
  > 3 weeks ago openoffice3/patches/patch-ae changed and did make
  > NPP_GetMIMEDescription into a constant.
  > 
  > now if build with:
  > PKG_OPTIONS.openoffice3+=-xulrunner
  > (so using openoffices own mozilla things) we get:
  > [failure]

 Well of course, that patch was to allow building with a newer
 xulrunner.

 Is there any reason to not use the pkgsrc xulrunner? (Why does this
 option even exist?)

 -- 
 David A. Holland
 dholland@netbsd.org

From: "B.ICT A.P. deBROUWER Jr." <noud4@home.nl>
To: gnats-bugs@NetBSD.org, David Holland <dholland-pbugs@netbsd.org>
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45727: misc/openoffice3 does not build with
 PKG_OPTIONS.openoffice3+=-xulrunner
Date: Wed, 21 Dec 2011 08:59:08 +0000

 (morning)

 On Wed, 2011-12-21 at 05:50 +0000, David Holland wrote:
 >  Well of course, that patch was to allow building with a newer
 >  xulrunner.

 I know, i'm not questioning that patch.
 just want an extra patch to build w/o pkgsrcs xulrunner again.
 (the option worked in the past and now not any more)

 >  Is there any reason to not use the pkgsrc xulrunner? (Why does this
 >  option even exist?)

 (That's near the same question as why xulrunner192 and firefox36 exist.)

 Me, for myself, need the firefox36 for a native Eclipse build.
 For now, using firefox36 is not facilitated in openoffice3 so i have to
 disable, so the patch-ae does need the pr-ed patch as companion to
 patch-ae.

 pls be so kind to add the patch so -xulrunner does work again.

 Noud
 -- 


From: "B.ICT A.P. deBROUWER Jr." <noud4@home.nl>
To: gnats-bugs@NetBSD.org, David Holland <dholland-pbugs@netbsd.org>
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45727: misc/openoffice3 does not build with
 PKG_OPTIONS.openoffice3+=-xulrunner
Date: Wed, 21 Dec 2011 20:54:30 +0000

 (i think i made a language error, intended the polite version of the use
 of pls)

 On Wed, 2011-12-21 at 09:00 +0000, B.ICT A.P. deBROUWER Jr. wrote:
 > The following reply was made to PR pkg/45727; it has been noted by GNATS.
 > 
 > From: "B.ICT A.P. deBROUWER Jr." <noud4@home.nl>
 >  pls be so kind to add the patch so -xulrunner does work again.

 Can/will you be so kind to add the patch so -xulrunner does work again,
 please.

 Noud
 -- 


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45727: misc/openoffice3 does not build with
 PKG_OPTIONS.openoffice3+=-xulrunner
Date: Sun, 22 Jan 2012 17:01:31 +0000

 On Wed, Dec 21, 2011 at 08:55:02PM +0000, B.ICT A.P. deBROUWER Jr. wrote:
  >  (i think i made a language error, intended the polite version of the use
  >  of pls)

 not really important :-)

 (english doesn't have structured polite forms)

  >  On Wed, 2011-12-21 at 09:00 +0000, B.ICT A.P. deBROUWER Jr. wrote:
  >  > The following reply was made to PR pkg/45727; it has been noted by GNATS.
  >  > 
  >  > From: "B.ICT A.P. deBROUWER Jr." <noud4@home.nl>
  >  >  pls be so kind to add the patch so -xulrunner does work again.
  >  
  >  Can/will you be so kind to add the patch so -xulrunner does work again,
  >  please.

 Isn't it also necessary to change the definition of the function in
 the included xulrunner and not just the header file?

 -- 
 David A. Holland
 dholland@netbsd.org

From: Noud de Brouwer <noud4@home.nl>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45727: misc/openoffice3 does not build with
 PKG_OPTIONS.openoffice3+=-xulrunner
Date: Fri, 27 Jan 2012 10:27:33 +0000

 On Sun, 2012-01-22 at 17:05 +0000, David Holland wrote:
 >  Isn't it also necessary to change the definition of the function in
 >  the included xulrunner and not just the header file?

 well (the other way around), the included xulrunner is done|changed by
 openoffice3/patches/patch-ae.

 and thus i noticed the header has to be changed as well conform the
 given patch.

 Noud
 -- 

State-Changed-From-To: open->closed
State-Changed-By: bsiegert@NetBSD.org
State-Changed-When: Sat, 07 Jul 2018 13:05:17 +0000
State-Changed-Why:
openoffice3 has been removed in 2016


>Unformatted:

Home	PR Database Search