NetBSD Problem Report #45729
From khorben@defora.org Wed Dec 21 13:06:07 2011
Return-Path: <khorben@defora.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id B58BD63BB83
for <gnats-bugs@gnats.NetBSD.org>; Wed, 21 Dec 2011 13:06:07 +0000 (UTC)
Message-Id: <20111221130502.E3B83169@kwarx.defora.lan>
Date: Wed, 21 Dec 2011 14:05:02 +0100 (CET)
From: Pierre Pronchery <khorben@defora.org>
To: gnats-bugs@gnats.NetBSD.org
Subject: Build fix and minor improvements for security/p0f
X-Send-Pr-Version: 3.95
>Number: 45729
>Category: pkg
>Synopsis: security/p0f does not build on NetBSD
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Dec 21 13:10:00 +0000 2011
>Closed-Date: Sun Jan 22 16:57:27 +0000 2012
>Last-Modified: Sun Jan 22 16:57:27 +0000 2012
>Originator: Pierre Pronchery
>Release: NetBSD 5.1_STABLE, pkgsrc-2011Q3, pkgsrc HEAD
>Organization:
>Environment:
System: NetBSD kwarx.defora.lan 5.1_STABLE NetBSD 5.1_STABLE (GENERIC) #3: Tue Sep 27 18:50:09 CEST 2011 khorben@kwarx.defora.lan:/home/amd64/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
The patch-aa patch for security/p0f adds a dependency on the ".WAIT"
rule to the build, which breaks on my system (NetBSD/amd64 5.1 with
pkgsrc-2011Q3). Removing this dependency fixes the build for me.
Then, the patch-aa patch for security/p0f uses gmake explicitly; I have
therefore added it to the list of tools required.
Finally, the file doc/COPYING within p0f 2.0.8 contains the text for the
GNU LGPL version 2.1 license, which I have also added to the Makefile.
>How-To-Repeat:
Build security/p0f from pkgsrc:
$ cd /usr/pkgsrc/security/p0f
$ make build
[...]
gmake[1]: *** No rule to make target `.WAIT', needed by `all'. Stop.
gmake[1]: Leaving directory `/home/netbsd/pkgsrc/work/security/p0f/work/p0f'
gmake: *** [all] Error 2
*** Error code 2
Stop.
make: stopped in /usr/pkgsrc/security/p0f
*** Error code 1
Stop.
make: stopped in /usr/pkgsrc/security/p0f
>Fix:
Apply this:
? .Makefile.swp
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/Makefile,v
retrieving revision 1.27
diff -p -u -r1.27 Makefile
--- Makefile 7 Jan 2011 04:16:14 -0000 1.27
+++ Makefile 21 Dec 2011 13:04:15 -0000
@@ -9,6 +9,7 @@ EXTRACT_SUFX= .tgz
MAINTAINER= pkgsrc-users@NetBSD.org
HOMEPAGE= http://lcamtuf.coredump.cx/p0f.shtml
COMMENT= Passive OS fingerprinting tool
+LICENSE= gnu-lgpl-v2.1
PKG_DESTDIR_SUPPORT= user-destdir
@@ -16,6 +17,8 @@ WRKSRC= ${WRKDIR}/p0f
PKG_SYSCONFSUBDIR= p0f
+USE_TOOLS+= gmake
+
MAKE_ENV+= LIBPCAP_PREFIX=${BUILDLINK_PREFIX.libpcap}
CONF_FILES= ${PREFIX}/share/examples/p0f/p0f.fp ${PKG_SYSCONFDIR}/p0f.fp
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/distinfo,v
retrieving revision 1.18
diff -p -u -r1.18 distinfo
--- distinfo 2 Oct 2011 05:04:03 -0000 1.18
+++ distinfo 21 Dec 2011 13:04:15 -0000
@@ -3,6 +3,6 @@ $NetBSD: distinfo,v 1.18 2011/10/02 05:0
SHA1 (p0f-2.0.8.tgz) = 7b4d5b2f24af4b5a299979134bc7f6d7b1eaf875
RMD160 (p0f-2.0.8.tgz) = 87d5b30d2d5e156b9fdcb026160155f413ce13d3
Size (p0f-2.0.8.tgz) = 136877 bytes
-SHA1 (patch-aa) = 0e79fc52b7711a8cb31565f2da8a52761947853d
+SHA1 (patch-aa) = e64830b1000eeb7eb6240c64d1cab7e9de990f65
SHA1 (patch-ad) = 378d9480c88d9a447684323c4a59f3c2f6f10d74
SHA1 (patch-ae) = 581817151df41d320f7d36efa8a87e4f13c97adc
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/security/p0f/patches/patch-aa,v
retrieving revision 1.10
diff -p -u -r1.10 patch-aa
--- patches/patch-aa 2 Oct 2011 05:04:03 -0000 1.10
+++ patches/patch-aa 21 Dec 2011 13:04:15 -0000
@@ -17,7 +17,7 @@ $NetBSD: patch-aa,v 1.10 2011/10/02 05:0
TOOLS = test/sendack test/sendack2 test/sendsyn
-all: $(FILE) strip
-+all: $(FILE) .WAIT strip
++all: $(FILE) strip
@echo ">> You can also try 'make p0fq' to compile a sample query"
@echo ">> client (see README for more information)."
>Release-Note:
>Audit-Trail:
From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45729 CVS commit: pkgsrc/security/p0f
Date: Wed, 21 Dec 2011 14:24:32 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Wed Dec 21 14:24:32 UTC 2011
Modified Files:
pkgsrc/security/p0f: Makefile
Log Message:
Set LICENSE, from Pierre Pronchery in PR 45729.
To generate a diff of this commit:
cvs rdiff -u -r1.27 -r1.28 pkgsrc/security/p0f/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc:
Subject: Re: pkg/45729: Build fix and minor improvements for security/p0f
Date: Wed, 21 Dec 2011 15:25:32 +0100
On Wed, Dec 21, 2011 at 01:10:02PM +0000, Pierre Pronchery wrote:
> The patch-aa patch for security/p0f adds a dependency on the ".WAIT"
> rule to the build, which breaks on my system (NetBSD/amd64 5.1 with
> pkgsrc-2011Q3). Removing this dependency fixes the build for me.
Well, it only breaks if you build the package using gmake.
BSD make knows about .WAIT.
Why did you build it using gmake?
> Finally, the file doc/COPYING within p0f 2.0.8 contains the text for the
> GNU LGPL version 2.1 license, which I have also added to the Makefile.
I've done that, thanks.
Thomas
From: Pierre Pronchery <khorben@defora.org>
To: gnats-bugs@NetBSD.org
Cc: Thomas Klausner <wiz@NetBSD.org>, pkg-manager@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45729: Build fix and minor improvements for security/p0f
Date: Wed, 21 Dec 2011 15:55:19 +0100
Hi,
On 21/12/2011 15:30, Thomas Klausner wrote:
>
> On Wed, Dec 21, 2011 at 01:10:02PM +0000, Pierre Pronchery wrote:
> > The patch-aa patch for security/p0f adds a dependency on the ".WAIT"
> > rule to the build, which breaks on my system (NetBSD/amd64 5.1 with
> > pkgsrc-2011Q3). Removing this dependency fixes the build for me.
>
> Well, it only breaks if you build the package using gmake.
> BSD make knows about .WAIT.
>
> Why did you build it using gmake?
actually, I did not. But the actual problem is there indeed: p0f
auto-detects if gmake is available in Build, trying to run it without
arguments. Then it defaults to using gmake if it is available.
I guess we have at least two options then:
- patching Build to disable this check,
- apply my patch, with which gmake can still build the project.
> > Finally, the file doc/COPYING within p0f 2.0.8 contains the text for the
> > GNU LGPL version 2.1 license, which I have also added to the Makefile.
>
> I've done that, thanks.
Thank you,
--
khorben
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc:
Subject: Re: pkg/45729: Build fix and minor improvements for security/p0f
Date: Wed, 21 Dec 2011 16:02:00 +0100
On Wed, Dec 21, 2011 at 03:55:19PM +0100, Pierre Pronchery wrote:
> actually, I did not. But the actual problem is there indeed: p0f
> auto-detects if gmake is available in Build, trying to run it without
> arguments. Then it defaults to using gmake if it is available.
Oh, weird.
> I guess we have at least two options then:
> - patching Build to disable this check,
> - apply my patch, with which gmake can still build the project.
The problem that .WAIT solves is that the package does not build well
with multiple make jobs, i.e. "make -j 16" or so. If we remove it, we
break it for that case again, so I'd prefer the first option.
Can you come up with a patch for that?
Or add proper dependencies to the Makefile even for gmake...
Thomas
From: David Holland <dholland-gnats@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/45729: Build fix and minor improvements for security/p0f
Date: Wed, 21 Dec 2011 15:41:39 +0000
On Wed, Dec 21, 2011 at 03:00:17PM +0000, Pierre Pronchery wrote:
> > Why did you build it using gmake?
>
> actually, I did not. But the actual problem is there indeed: p0f
> auto-detects if gmake is available in Build, trying to run it without
> arguments. Then it defaults to using gmake if it is available.
That should be removed or disabled.
> I guess we have at least two options then:
> - patching Build to disable this check,
> - apply my patch, with which gmake can still build the project.
No, it can't, because the makefile isn't MAKE_JOBS_SAFE without that
.WAIT and gmake has no equivalent feature...
--
David A. Holland
dholland@netbsd.org
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45729 CVS commit: pkgsrc/security/p0f
Date: Wed, 21 Dec 2011 15:52:17 +0000
Module Name: pkgsrc
Committed By: dholland
Date: Wed Dec 21 15:52:17 UTC 2011
Modified Files:
pkgsrc/security/p0f: distinfo
pkgsrc/security/p0f/patches: patch-ae
Log Message:
Disable probe for gmake; PR 45729
To generate a diff of this commit:
cvs rdiff -u -r1.18 -r1.19 pkgsrc/security/p0f/distinfo
cvs rdiff -u -r1.1 -r1.2 pkgsrc/security/p0f/patches/patch-ae
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 24 Dec 2011 22:21:29 +0000
State-Changed-Why:
should work now, please check
From: Pierre Pronchery <khorben@defora.org>
To: gnats-bugs@NetBSD.org
Cc: dholland@NetBSD.org, pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org,
gnats-admin@netbsd.org
Subject: Re: pkg/45729 (security/p0f does not build on NetBSD)
Date: Wed, 04 Jan 2012 11:24:00 +0100
On 24/12/2011 23:21, dholland@NetBSD.org wrote:
> Synopsis: security/p0f does not build on NetBSD
>
> State-Changed-From-To: open->feedback
> State-Changed-By: dholland@NetBSD.org
> State-Changed-When: Sat, 24 Dec 2011 22:21:29 +0000
> State-Changed-Why:
> should work now, please check
It does, thank you!
Besides, for the issue with "make -j", I have tried to patch mk/NetBSD,
changing line 28 from:
strip:
to
strip: $(FILE)
and I believe it should work (it does here).
HTH,
--
khorben
State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 22 Jan 2012 16:57:27 +0000
State-Changed-Why:
Confirmed fixed, thanks.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.