NetBSD Problem Report #45747

From www@NetBSD.org  Tue Dec 27 12:06:19 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id DED8463DD5A
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 27 Dec 2011 12:06:18 +0000 (UTC)
Message-Id: <20111227120618.016E963DD3F@www.NetBSD.org>
Date: Tue, 27 Dec 2011 12:06:17 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Comparsion with icmp6_type -
X-Send-Pr-Version: www-1.0

>Number:         45747
>Category:       bin
>Synopsis:       Comparsion with icmp6_type -
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 27 12:10:00 +0000 2011
>Closed-Date:    Tue Dec 27 18:41:47 +0000 2011
>Last-Modified:  Tue Dec 27 18:41:47 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Fix comparsion with icmp6_type in print-icmp6.c .
Fixed in tcpdump release 4.2.0 .
>How-To-Repeat:

>Fix:
diff -u -p -r1.2 print-icmp6.c
--- external/bsd/tcpdump/dist/print-icmp6.c	5 Dec 2010 05:11:30 -0000	1.2
+++ external/bsd/tcpdump/dist/print-icmp6.c	20 Dec 2011 07:00:18 -0000
@@ -355,14 +355,13 @@ icmp6_print(netdissect_options *ndo,
         printf("ICMP6, %s", tok2str(icmp6_type_values,"unknown icmp6 type (%u)",dp->icmp6_type));

         /* display cosmetics: print the packet length for printer that use the vflag now */
-        if (vflag && (dp->icmp6_type ==
-                      ND_ROUTER_SOLICIT ||
-                      ND_ROUTER_ADVERT ||
-                      ND_NEIGHBOR_ADVERT ||
-                      ND_NEIGHBOR_SOLICIT ||
-                      ND_REDIRECT ||
-                      ICMP6_HADISCOV_REPLY ||
-                      ICMP6_MOBILEPREFIX_ADVERT ))
+        if (vflag && (dp->icmp6_type == ND_ROUTER_SOLICIT ||
+                      dp->icmp6_type == ND_ROUTER_ADVERT ||
+                      dp->icmp6_type == ND_NEIGHBOR_ADVERT ||
+                      dp->icmp6_type == ND_NEIGHBOR_SOLICIT ||
+                      dp->icmp6_type == ND_REDIRECT ||
+                      dp->icmp6_type == ICMP6_HADISCOV_REPLY ||
+                      dp->icmp6_type == ICMP6_MOBILEPREFIX_ADVERT))
             printf(", length %u", length);

 	switch (dp->icmp6_type) {

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45747 CVS commit: src/external/bsd/tcpdump/dist
Date: Tue, 27 Dec 2011 10:12:45 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Tue Dec 27 15:12:45 UTC 2011

 Modified Files:
 	src/external/bsd/tcpdump/dist: print-icmp6.c

 Log Message:
 PR/45747: Henning Petersen: Fix icmp6 verbose printing.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/external/bsd/tcpdump/dist/print-icmp6.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 27 Dec 2011 16:14:41 +0000
State-Changed-Why:
Christos committed, ok to close?


From: henning petersen <henning.petersen@t-online.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/45747 (Comparsion with icmp6_type -)
Date: Tue, 27 Dec 2011 17:17:28 +0100

 Am 27.12.2011 17:14, schrieb wiz@NetBSD.org:
 > Synopsis: Comparsion with icmp6_type -
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: wiz@NetBSD.org
 > State-Changed-When: Tue, 27 Dec 2011 16:14:41 +0000
 > State-Changed-Why:
 > Christos committed, ok to close?
 >
 >
 >
 >
 Fixed OK.

State-Changed-From-To: feedback->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 27 Dec 2011 18:41:47 +0000
State-Changed-Why:
Fixed, thanks.


>Unformatted:

Home	PR Database Search