NetBSD Problem Report #458

From gnats  Mon Sep  5 12:56:16 1994
Received: from bloom-beacon.mit.edu (BLOOM-BEACON.MIT.EDU [18.181.0.26]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with SMTP id MAA01124; Mon, 5 Sep 1994 12:56:15 -0700
Message-Id: <199409051733.NAA00340@kolvir.blrc.ma.us>
Date: Mon, 5 Sep 1994 13:33:36 -0400
From: John Kohl <jtk@kolvir.blrc.ma.us>
Reply-To: jtk@kolvir.blrc.ma.us
To: gnats-bugs@netbsd.org
Cc: current-users@netbsd.org, proven@mit.edu, raeburn@mit.edu
Subject: bug in /sys/arch/i386/isa/com.c:1.31.2.4: discards output bytes
X-Send-Pr-Version: 3.2

>Number:         458
>Category:       port-i386
>Synopsis:       com.c will discard in-transit FIFO data if tcsetattr() invoked
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnats-admin (GNATS administrator)
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 05 13:05:03 +0000 1994
>Closed-Date:    Fri Sep 16 02:25:42 +0000 1994
>Last-Modified:  
>Originator:     John Kohl
>Release:        1.0_BETA
>Organization:
"MIT SIPB"
>Environment:
	NetBSD 1.0_BETA i386 (-current)
System: NetBSD kolvir 1.0_BETA NetBSD 1.0_BETA (KOLVIR) #42: Mon Sep 5 13:18:51 EDT 1994 jtk@kolvir:/local/usr/src/local/NetBSD/src/sys/arch/i386/compile/KOLVIR i386


>Description:
	The serial line COM code can destroy in-transit FIFO data if
comparam() is invoked to set some parameters.  This can cause UUCP to fail
in mysterious ways, and probably causes other programs some problems.

>How-To-Repeat:
	Open a com port with a FIFO, shove data down it, then do
something to affect the hardware (e.g. toggle CRTSCTS).  Note that the
receiver doesn't get all the in-transit bytes.

>Fix:
	The problem lies in the FIFO reset code inside comparam().
There's no need to adjust the FIFO trigger level unless the baud rate is
being changed.

The patch below includes a reinstatement of the FIFO trigger
initialization in comopen(); otherwise the trigger level would not be
set until the baud rate is changed from the default baud rate.  [This
code was removed when the trigger level stuff was moved to comparam()]

The patch is relative to:
!  *	$Id: com.c,v 1.31.2.4 1994/08/24 07:29:42 mycroft Exp $

*** 1.1	1994/09/05 15:15:28
--- com.c	1994/09/05 17:24:23
***************
*** 297,302 ****
--- 297,308 ----

  		iobase = sc->sc_iobase;
  		/* flush any pending I/O */
+ 		if (sc->sc_hwflags & COM_HW_FIFO)
+ 			outb(iobase + com_fifo,
+ 			    FIFO_ENABLE | FIFO_RCV_RST | FIFO_XMT_RST |
+ 			    FIFO_TRIGGER_8);
+ 		/* The FIFO trigger level is adjusted when speed
+                    changes, see below */
  		(void) inb(iobase + com_lsr);
  		(void) inb(iobase + com_data);
  		/* you turn me on, baby */
***************
*** 555,562 ****

  	s = spltty();

! 	/* Set the FIFO threshold based on the receive speed. */
! 	if (sc->sc_hwflags & COM_HW_FIFO)
  		outb(iobase + com_fifo,
  		    FIFO_ENABLE | FIFO_RCV_RST | FIFO_XMT_RST |
  		    (t->c_ispeed <= 1200 ? FIFO_TRIGGER_1 : FIFO_TRIGGER_8));
--- 561,570 ----

  	s = spltty();

! 	/* Set the FIFO threshold based on the receive speed, but only
! 	   if we're changing speed (otherwise we may destroy
! 	   in-transit characters). */
! 	if (tp->t_ospeed != t->c_ospeed && (sc->sc_hwflags & COM_HW_FIFO))
  		outb(iobase + com_fifo,
  		     FIFO_ENABLE | FIFO_RCV_RST | FIFO_XMT_RST |
  		    (t->c_ispeed <= 1200 ? FIFO_TRIGGER_1 : FIFO_TRIGGER_8));
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mycroft 
State-Changed-When: Thu Sep 15 19:25:42 PDT 1994 
State-Changed-Why:  
Fixed, though the entire driver could use more work. 
>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.