NetBSD Problem Report #45866
From yamt@NetBSD.org Mon Jan 23 06:35:48 2012
Return-Path: <yamt@NetBSD.org>
Received: by www.NetBSD.org (Postfix, from userid 1270)
id 24CBC63B9DD; Mon, 23 Jan 2012 06:35:48 +0000 (UTC)
Message-Id: <20120123063548.24CBC63B9DD@www.NetBSD.org>
Date: Mon, 23 Jan 2012 06:35:48 +0000 (UTC)
From: yamt@NetBSD.org
Reply-To: yamt@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: dbench patch-aa seems bogus
X-Send-Pr-Version: 3.95
>Number: 45866
>Category: pkg
>Synopsis: dbench patch-aa seems bogus
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jan 23 06:40:01 +0000 2012
>Closed-Date: Mon Jan 23 09:40:23 +0000 2012
>Last-Modified: Mon Jan 23 09:40:23 +0000 2012
>Originator: YAMAMOTO Takashi
>Release: latest
>Organization:
>Environment:
>Description:
the following part of patch-aa seems bogus. while the code in
question might not do anything "useful", benchmark programs like
this are not expected to do anything useful in that sense.
void nb_qfsinfo(struct child_struct *child, int level, const char *status)
{
+#if 0 /* does this code do anything useful? */
struct statvfs st;
(void)level;
(void)status;
statvfs(child->directory, &st);
+#endif
}
>How-To-Repeat:
code inspection.
>Fix:
>Release-Note:
>Audit-Trail:
From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45866 CVS commit: pkgsrc/benchmarks/dbench
Date: Mon, 23 Jan 2012 09:39:53 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Mon Jan 23 09:39:52 UTC 2012
Modified Files:
pkgsrc/benchmarks/dbench: Makefile distinfo
pkgsrc/benchmarks/dbench/patches: patch-aa
Log Message:
Remove chunk that was added for 1.6.2 compatibility, but affects the
run-time. Noted by yamt@ in PR 45866.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 pkgsrc/benchmarks/dbench/Makefile
cvs rdiff -u -r1.11 -r1.12 pkgsrc/benchmarks/dbench/distinfo
cvs rdiff -u -r1.5 -r1.6 pkgsrc/benchmarks/dbench/patches/patch-aa
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 23 Jan 2012 09:40:23 +0000
State-Changed-Why:
Removed, thanks!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.