NetBSD Problem Report #45905
From www@NetBSD.org Wed Feb 1 06:44:40 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
by www.NetBSD.org (Postfix) with ESMTP id 85DBC63D5F9
for <gnats-bugs@gnats.NetBSD.org>; Wed, 1 Feb 2012 06:44:40 +0000 (UTC)
Message-Id: <20120201064439.E031863D5E6@www.NetBSD.org>
Date: Wed, 1 Feb 2012 06:44:39 +0000 (UTC)
From: dogan@tesmer.org.tr
Reply-To: dogan@tesmer.org.tr
To: gnats-bugs@NetBSD.org
Subject: lang/php53 doesn't compile on -current
X-Send-Pr-Version: www-1.0
>Number: 45905
>Category: pkg
>Synopsis: lang/php53 doesn't compile on -current
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Feb 01 06:45:00 +0000 2012
>Closed-Date: Wed Feb 15 12:36:25 +0000 2012
>Last-Modified: Wed Feb 15 12:36:25 +0000 2012
>Originator: Mustafa Dogan
>Release: NetBSD 5.99.62
>Organization:
TESMER
>Environment:
NetBSD md.dogan.biz.tr 5.99.62 NetBSD 5.99.62 (GENERIC) #0: Sun Jan 29 14:56:29 EET 2012 root@md.dogan.biz.tr:/root/OBJ/sys/arch/i386/compile/GENERIC i386
>Description:
lang/php53 doesn't be compiled due to fpos_t change.
>How-To-Repeat:
cd /usr/pkgsrc/lang/php53
make
>Fix:
This patch fixed my problem.
--- main/streams/cast.c.orig 2012-02-01 08:18:32.000000000 +0200
+++ main/streams/cast.c 2012-02-01 08:19:20.000000000 +0200
@@ -34,7 +34,7 @@
typedef struct {
int (*reader)(void *, char *, int);
int (*writer)(void *, const char *, int);
- fpos_t (*seeker)(void *, fpos_t, int);
+ off_t (*seeker)(void *, off_t, int);
int (*closer)(void *);
} COOKIE_IO_FUNCTIONS_T;
@@ -68,11 +68,11 @@
return php_stream_write((php_stream *)cookie, (char *)buffer, size);
}
-static fpos_t stream_cookie_seeker(void *cookie, off_t position, int whence)
+static off_t stream_cookie_seeker(void *cookie, off_t position, int whence)
{
TSRMLS_FETCH();
- return (fpos_t)php_stream_seek((php_stream *)cookie, position, whence);
+ return (off_t)php_stream_seek((php_stream *)cookie, position, whence);
}
static int stream_cookie_closer(void *cookie)
>Release-Note:
>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: dogan@tesmer.org.tr
Cc:
Subject: Re: pkg/45905: lang/php53 doesn't compile on -current
Date: Thu, 2 Feb 2012 13:36:24 +0100
On Wed, Feb 01, 2012 at 06:45:00AM +0000, dogan@tesmer.org.tr wrote:
> >Number: 45905
> >Category: pkg
> >Synopsis: lang/php53 doesn't compile on -current
...
> This patch fixed my problem.
>
> --- main/streams/cast.c.orig 2012-02-01 08:18:32.000000000 +0200
> +++ main/streams/cast.c 2012-02-01 08:19:20.000000000 +0200
> @@ -34,7 +34,7 @@
> typedef struct {
> int (*reader)(void *, char *, int);
> int (*writer)(void *, const char *, int);
> - fpos_t (*seeker)(void *, fpos_t, int);
> + off_t (*seeker)(void *, off_t, int);
> int (*closer)(void *);
> } COOKIE_IO_FUNCTIONS_T;
>
Thanks.
We can't commit this as-is, because it will break systems where the interface still uses fpos_t.
Thomas
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
pkgsrc-bugs@netbsd.org, dogan@tesmer.org.tr
Cc:
Subject: Re: pkg/45905: lang/php53 doesn't compile on -current
Date: Thu, 2 Feb 2012 09:06:28 -0500
On Feb 2, 12:40pm, wiz@NetBSD.org (Thomas Klausner) wrote:
-- Subject: Re: pkg/45905: lang/php53 doesn't compile on -current
| The following reply was made to PR pkg/45905; it has been noted by GNATS.
|
| From: Thomas Klausner <wiz@NetBSD.org>
| To: dogan@tesmer.org.tr
| Cc:
| Subject: Re: pkg/45905: lang/php53 doesn't compile on -current
| Date: Thu, 2 Feb 2012 13:36:24 +0100
|
| On Wed, Feb 01, 2012 at 06:45:00AM +0000, dogan@tesmer.org.tr wrote:
| > >Number: 45905
| > >Category: pkg
| > >Synopsis: lang/php53 doesn't compile on -current
| ...
| > This patch fixed my problem.
| >
| > --- main/streams/cast.c.orig 2012-02-01 08:18:32.000000000 +0200
| > +++ main/streams/cast.c 2012-02-01 08:19:20.000000000 +0200
| > @@ -34,7 +34,7 @@
| > typedef struct {
| > int (*reader)(void *, char *, int);
| > int (*writer)(void *, const char *, int);
| > - fpos_t (*seeker)(void *, fpos_t, int);
| > + off_t (*seeker)(void *, off_t, int);
| > int (*closer)(void *);
| > } COOKIE_IO_FUNCTIONS_T;
| >
|
| Thanks.
| We can't commit this as-is, because it will break systems where the interface still uses fpos_t.
| Thomas
It should work, at least on NetBSD, because fpos_t used to be == off_t.
christos
State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Wed, 15 Feb 2012 12:36:25 +0000
State-Changed-Why:
fixed by following commit
Module Name: pkgsrc
Committed By: taca
Date: Thu Feb 2 15:44:09 UTC 2012
Modified Files:
pkgsrc/lang/php53: distinfo
Added Files:
pkgsrc/lang/php53/patches: patch-main_streams_cast.c
Log Message:
Trying to fix build problem on NetBSD current recently.
To generate a diff of this commit:
cvs rdiff -u -r1.31 -r1.32 pkgsrc/lang/php53/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/lang/php53/patches/patch-main_streams_cast.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.