NetBSD Problem Report #45995

From www@NetBSD.org  Sun Feb 12 11:26:23 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 123AE63E028
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Feb 2012 11:26:23 +0000 (UTC)
Message-Id: <20120212112622.70BA863B86B@www.NetBSD.org>
Date: Sun, 12 Feb 2012 11:26:22 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Use the right return value.
X-Send-Pr-Version: www-1.0

>Number:         45995
>Category:       kern
>Synopsis:       Use the right return value.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 11:30:00 +0000 2012
>Closed-Date:    Sun Feb 12 13:49:04 +0000 2012
>Last-Modified:  Sun Feb 12 13:50:14 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Return value false.
Founf by clang.
>How-To-Repeat:

>Fix:
diff -u -p -r1.2 ar5212_misc.c
--- sys/external/isc/atheros_hal/dist/ar5212/ar5212_misc.c	7 Mar 2011 11:25:43 -0000	1.2
+++ sys/external/isc/atheros_hal/dist/ar5212/ar5212_misc.c	5 Feb 2012 07:37:35 -0000
@@ -570,7 +570,7 @@ ar5212SetDecompMask(struct ath_hal *ah, 
 	struct ath_hal_5212 *ahp = AH5212(ah);

         if (keyidx >= HAL_DECOMP_MASK_SIZE)
-                return HAL_EINVAL; 
+                return AH_FALSE; 
         OS_REG_WRITE(ah, AR_DCM_A, keyidx);
         OS_REG_WRITE(ah, AR_DCM_D, en ? AR_DCM_D_EN : 0);
         ahp->ah_decompMask[keyidx] = en;

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 12 Feb 2012 13:49:04 +0000
State-Changed-Why:
Committed, thanks


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45995 CVS commit: src/sys/external/isc/atheros_hal/dist/ar5212
Date: Sun, 12 Feb 2012 13:48:46 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Feb 12 13:48:45 UTC 2012

 Modified Files:
 	src/sys/external/isc/atheros_hal/dist/ar5212: ar5212_misc.c

 Log Message:
 Use correct return value. From clang via Henning Petersen in PR 45995.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 \
     src/sys/external/isc/atheros_hal/dist/ar5212/ar5212_misc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search