NetBSD Problem Report #45996

From www@NetBSD.org  Sun Feb 12 11:29:05 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id CFFCD63E028
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Feb 2012 11:29:05 +0000 (UTC)
Message-Id: <20120212112905.4AF1263B86B@www.NetBSD.org>
Date: Sun, 12 Feb 2012 11:29:05 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Use the right return value.
X-Send-Pr-Version: www-1.0

>Number:         45996
>Category:       kern
>Synopsis:       Use the right return value.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 11:30:00 +0000 2012
>Closed-Date:    Sun Feb 12 13:47:30 +0000 2012
>Last-Modified:  Sun Feb 12 13:50:02 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Return value false.
Found by clang.
>How-To-Repeat:

>Fix:
diff -u -p -r1.1.1.1 ar5416_misc.c
--- sys/external/isc/atheros_hal/dist/ar5416/ar5416_misc.c	11 Dec 2008 04:46:48 -0000	1.1.1.1
+++ sys/external/isc/atheros_hal/dist/ar5416/ar5416_misc.c	5 Feb 2012 07:42:45 -0000
@@ -113,7 +113,7 @@ ar5416SetAntennaSwitch(struct ath_hal *a
 HAL_BOOL
 ar5416SetDecompMask(struct ath_hal *ah, uint16_t keyidx, int en)
 {
-	return HAL_OK;
+	return AH_TRUE;
 }

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 12 Feb 2012 13:47:30 +0000
State-Changed-Why:
Committed, thanks 


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45996 CVS commit: src/sys/external/isc/atheros_hal/dist/ar5416
Date: Sun, 12 Feb 2012 13:47:19 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Feb 12 13:47:19 UTC 2012

 Modified Files:
 	src/sys/external/isc/atheros_hal/dist/ar5416: ar5416_misc.c

 Log Message:
 Use correct return value. From clang via Henning Petersen in PR 45996.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.1 -r1.2 \
     src/sys/external/isc/atheros_hal/dist/ar5416/ar5416_misc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search