NetBSD Problem Report #45997

From www@NetBSD.org  Sun Feb 12 11:34:30 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id B360063E02D
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Feb 2012 11:34:30 +0000 (UTC)
Message-Id: <20120212113429.A27DF63E028@www.NetBSD.org>
Date: Sun, 12 Feb 2012 11:34:29 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Remove unused variables.Remove un
X-Send-Pr-Version: www-1.0

>Number:         45997
>Category:       lib
>Synopsis:       Remove unused variables.Remove un
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 11:35:01 +0000 2012
>Closed-Date:    Sun Feb 12 13:51:37 +0000 2012
>Last-Modified:  Sun Feb 12 13:55:01 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Remove unused variables.
Found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -p -r1.15 citrus_iconv_std.c
--- lib/libc/citrus/modules/citrus_iconv_std.c	13 Nov 2006 19:08:19 -0000	1.15
+++ lib/libc/citrus/modules/citrus_iconv_std.c	5 Feb 2012 08:14:51 -0000
@@ -418,7 +418,6 @@ _citrus_iconv_std_iconv_init_context(str
 {
 	const struct _citrus_iconv_std_shared *is = cv->cv_shared->ci_closure;
 	struct _citrus_iconv_std_context *sc;
-	int ret;
 	size_t szpssrc, szpsdst, sz;
 	char *ptr;

==========================================================================

diff -u -p -r1.2 citrus_ues.c
--- lib/libc/citrus/modules/citrus_ues.c	7 Dec 2010 22:01:22 -0000	1.2
+++ lib/libc/citrus/modules/citrus_ues.c	5 Feb 2012 08:19:58 -0000
@@ -212,7 +212,7 @@ _citrus_UES_mbrtowc_priv(_UESEncodingInf
 	_UESState * __restrict psenc, size_t * __restrict nresult)
 {
 	const char *s0;
-	int ch, head, tail, i, num;
+	int ch, head, tail, num;
 	wchar_t hi, wc;

 	_DIAGASSERT(ei != NULL);
=====================================================================

diff -u -p -r1.11 citrus_utf1632.c
--- lib/libc/citrus/modules/citrus_utf1632.c	20 Mar 2010 18:15:32 -0000	1.11
+++ lib/libc/citrus/modules/citrus_utf1632.c	5 Feb 2012 08:19:59 -0000
@@ -250,7 +250,6 @@ _citrus_UTF1632_wcrtomb_priv(_UTF1632Enc
 			     wchar_t wc, _UTF1632State *psenc,
 			     size_t *nresult)
 {
-	int ret;
 	wchar_t wc2;
 	static const char _bom[4] = {
 #if BYTE_ORDER == BIG_ENDIAN

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 12 Feb 2012 13:51:37 +0000
State-Changed-Why:
Committed, thanks


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45997 CVS commit: src/lib/libc/citrus/modules
Date: Sun, 12 Feb 2012 13:51:29 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Feb 12 13:51:29 UTC 2012

 Modified Files:
 	src/lib/libc/citrus/modules: citrus_iconv_std.c citrus_ues.c
 	    citrus_utf1632.c

 Log Message:
 Remove unused variables. From cppcheck via Henning Petersen in PR 45997.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 src/lib/libc/citrus/modules/citrus_iconv_std.c
 cvs rdiff -u -r1.2 -r1.3 src/lib/libc/citrus/modules/citrus_ues.c
 cvs rdiff -u -r1.11 -r1.12 src/lib/libc/citrus/modules/citrus_utf1632.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search