NetBSD Problem Report #46000

From www@NetBSD.org  Sun Feb 12 11:45:49 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 1F6BF63E028
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Feb 2012 11:45:49 +0000 (UTC)
Message-Id: <20120212114548.88DD563B86B@www.NetBSD.org>
Date: Sun, 12 Feb 2012 11:45:48 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Remove duplicat RS_LOCAL in defs.h from routed.
X-Send-Pr-Version: www-1.0

>Number:         46000
>Category:       bin
>Synopsis:       Remove duplicat RS_LOCAL in defs.h from routed.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 11:50:00 +0000 2012
>Closed-Date:    Sun Feb 12 13:57:07 +0000 2012
>Last-Modified:  Sun Feb 12 14:00:10 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Remove duplicat RS_LOCAL in defs.h from routed.
Founf by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -p -r1.26 defs.h
--- sbin/routed/defs.h	29 Aug 2011 14:35:04 -0000	1.26
+++ sbin/routed/defs.h	2 Feb 2012 09:46:09 -0000
@@ -207,9 +207,9 @@ struct rt_entry {
 #	    define RS_IF	0x001	/* for network interface */
 #	    define RS_NET_INT	0x002	/* authority route */
 #	    define RS_NET_SYN	0x004	/* fake net route for subnet */
-#	    define RS_NO_NET_SYN (RS_LOCAL | RS_LOCAL | RS_IF)
 #	    define RS_SUBNET	0x008	/* subnet route from any source */
 #	    define RS_LOCAL	0x010	/* loopback for pt-to-pt */
+#	    define RS_NO_NET_SYN (RS_LOCAL | RS_IF)
 #	    define RS_MHOME	0x020	/* from -m */
 #	    define RS_STATIC	0x040	/* from the kernel */
 #	    define RS_RDISC     0x080	/* from router discovery */

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 12 Feb 2012 13:57:07 +0000
State-Changed-Why:
Committed, thanks


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46000 CVS commit: src/sbin/routed
Date: Sun, 12 Feb 2012 13:56:57 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Feb 12 13:56:57 UTC 2012

 Modified Files:
 	src/sbin/routed: defs.h

 Log Message:
 Remove duplicate RS_LOCAL. From cppcheck via Henning Petersen in PR 46000.


 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.27 src/sbin/routed/defs.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search