NetBSD Problem Report #46002

From www@NetBSD.org  Sun Feb 12 11:51:47 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id C539063E02D
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 12 Feb 2012 11:51:47 +0000 (UTC)
Message-Id: <20120212115147.2D19263E028@www.NetBSD.org>
Date: Sun, 12 Feb 2012 11:51:47 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Remove unused variable.
X-Send-Pr-Version: www-1.0

>Number:         46002
>Category:       bin
>Synopsis:       Remove unused variable.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 12 11:55:00 +0000 2012
>Closed-Date:    Mon Feb 13 12:55:44 +0000 2012
>Last-Modified:  Mon Feb 13 13:00:03 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Remove unused variable.
Found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -p -r1.118 print.c
--- bin/ps/print.c	13 Jun 2011 03:42:15 -0000	1.118
+++ bin/ps/print.c	11 Jan 2012 18:10:00 -0000
@@ -554,13 +554,12 @@ void
 lstate(void *arg, VARENT *ve, int mode)
 {
 	struct kinfo_lwp *k;
-	int flag, is_zombie;
+	int flag;
 	char *cp;
 	VAR *v;
 	char buf[16];

 	k = arg;
-	is_zombie = 0;
 	v = ve->var;
 	flag = k->l_flag;
 	cp = buf;
@@ -590,7 +589,6 @@ lstate(void *arg, VARENT *ve, int mode)
 	case LSZOMB:
 	case LSDEAD:
 		*cp = 'Z';
-		is_zombie = 1;
 		break;

 	case LSSUSPENDED:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 13 Feb 2012 12:55:44 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46002 CVS commit: src/bin/ps
Date: Mon, 13 Feb 2012 12:55:28 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Mon Feb 13 12:55:28 UTC 2012

 Modified Files:
 	src/bin/ps: print.c

 Log Message:
 Remove unused variable.
 From cppcheck via Henning Petersen in PR 46002.


 To generate a diff of this commit:
 cvs rdiff -u -r1.118 -r1.119 src/bin/ps/print.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search