NetBSD Problem Report #46015

From dholland@netbsd.org  Mon Feb 13 06:33:46 2012
Return-Path: <dholland@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0D95D63B86B
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 13 Feb 2012 06:33:46 +0000 (UTC)
Message-Id: <20120213063346.4CD8514AAC9@mail.netbsd.org>
Date: Mon, 13 Feb 2012 06:33:46 +0000 (UTC)
From: dholland@NetBSD.org
Reply-To: dholland@NetBSD.org
To: gnats-bugs@gnats.NetBSD.org
Subject: atf rquotad test no longer runnable
X-Send-Pr-Version: 3.95

>Number:         46015
>Category:       bin
>Synopsis:       atf rquotad test no longer runnable
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bouyer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 13 06:35:00 +0000 2012
>Closed-Date:    Mon Feb 13 22:42:19 +0000 2012
>Last-Modified:  Mon Feb 13 22:45:01 +0000 2012
>Originator:     David A. Holland
>Release:        current of 20120213
>Organization:
>Environment:
n/a
>Description:

With the absolute latest HEAD, the rquota test now does this:

test_case_root: not found
fs/nfs/t_rquotad (94/498): 0 test cases
fs/nfs/t_rquotad: BOGUS TEST PROGRAM: Cannot trust its results because of
                  `Invalid format for test case list: 1: Unexpected token
                  `<<EOF>>'; expected a header name'
[0.025856s]

Not sure when this started happening but it was fairly recently; I
expect it was the last atf update.

>How-To-Repeat:

anita test

>Fix:

beats me. something in atf changed I guess...

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/46015: atf rquotad test no longer runnable
Date: Mon, 13 Feb 2012 10:33:34 +0100

 On Mon, Feb 13, 2012 at 06:35:00AM +0000, dholland@NetBSD.org wrote:
 > With the absolute latest HEAD, the rquota test now does this:
 > 
 > test_case_root: not found

 I don't quite understand the make magic involved, but certainly does not
 look like an atf fault to me:

 .for name in t_rquotad
 TESTS_SH+=      ${name}
 TESTS_SH_SRC_${name}=   ../ffs/quotas_common.sh ${name}.sh
 .endfor

 and ../ffs/quotas_common.sh defines the test_case_root function. Seems
 to work for the ../ffs shell based tests, which use it pretty much the
 same way.

 Martin

From: Manuel Bouyer <bouyer@antioche.eu.org>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org, dholland@NetBSD.org
Subject: Re: bin/46015: atf rquotad test no longer runnable
Date: Mon, 13 Feb 2012 16:24:11 +0100

 On Mon, Feb 13, 2012 at 09:35:02AM +0000, Martin Husemann wrote:
 > The following reply was made to PR bin/46015; it has been noted by GNATS.
 > 
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: bin/46015: atf rquotad test no longer runnable
 > Date: Mon, 13 Feb 2012 10:33:34 +0100
 > 
 >  On Mon, Feb 13, 2012 at 06:35:00AM +0000, dholland@NetBSD.org wrote:
 >  > With the absolute latest HEAD, the rquota test now does this:
 >  > 
 >  > test_case_root: not found
 >  
 >  I don't quite understand the make magic involved, but certainly does not
 >  look like an atf fault to me:
 >  
 >  .for name in t_rquotad
 >  TESTS_SH+=      ${name}
 >  TESTS_SH_SRC_${name}=   ../ffs/quotas_common.sh ${name}.sh
 >  .endfor
 >  
 >  and ../ffs/quotas_common.sh defines the test_case_root function. Seems
 >  to work for the ../ffs shell based tests, which use it pretty much the
 >  same way.

 It's probably my fault; I forgot to update this test case when I split
 non-quota parts out of ../ffs/quotas_common.sh. This should probably be:
 TESTS_SH_SRC_${name}=  ../ffs/ffs_common.sh ../ffs/quotas_common.sh ${name}.sh

 I'll look at fixing this this evening, unless someone beats me.

 -- 
 Manuel Bouyer <bouyer@antioche.eu.org>
      NetBSD: 26 ans d'experience feront toujours la difference
 --

From: Manuel Bouyer <bouyer@antioche.eu.org>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org, dholland@NetBSD.org
Subject: Re: bin/46015: atf rquotad test no longer runnable
Date: Mon, 13 Feb 2012 20:56:01 +0100

 --r5Pyd7+fXNt84Ff3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Mon, Feb 13, 2012 at 04:24:11PM +0100, Manuel Bouyer wrote:
 > It's probably my fault; I forgot to update this test case when I split
 > non-quota parts out of ../ffs/quotas_common.sh. This should probably be:
 > TESTS_SH_SRC_${name}=  ../ffs/ffs_common.sh ../ffs/quotas_common.sh ${name}.sh
 > 
 > I'll look at fixing this this evening, unless someone beats me.

 The attached patch fixes it for me; I'll see with releng to commit it.

 -- 
 Manuel Bouyer <bouyer@antioche.eu.org>
      NetBSD: 26 ans d'experience feront toujours la difference
 --

 --r5Pyd7+fXNt84Ff3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=diff

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/src/tests/fs/nfs/Makefile,v
 retrieving revision 1.6
 diff -u -p -u -r1.6 Makefile
 --- Makefile	30 May 2011 14:41:26 -0000	1.6
 +++ Makefile	13 Feb 2012 19:54:59 -0000
 @@ -11,7 +11,7 @@ TESTS_C=	t_mountd

  .for name in t_rquotad
  TESTS_SH+=	${name}
 -TESTS_SH_SRC_${name}=	../ffs/quotas_common.sh ${name}.sh
 +TESTS_SH_SRC_${name}=	../ffs/ffs_common.sh ../ffs/quotas_common.sh ${name}.sh
  .endfor

  VFSTESTDIR != cd ${.CURDIR}/../common && ${PRINTOBJDIR}
 Index: t_rquotad.sh
 ===================================================================
 RCS file: /cvsroot/src/tests/fs/nfs/t_rquotad.sh,v
 retrieving revision 1.1
 diff -u -p -u -r1.1 t_rquotad.sh
 --- t_rquotad.sh	12 Mar 2011 14:03:38 -0000	1.1
 +++ t_rquotad.sh	13 Feb 2012 19:54:59 -0000
 @@ -35,7 +35,7 @@ done

  get_nfs_quota()
  {
 -	create_with_quotas $*
 +	create_ffs $*
  	local q=$3
  	local expect

 @@ -138,5 +138,5 @@ get_nfs_quota()
  	done

  	unset LD_PRELOAD
 -	rump_shutdown
 +	rump_quota_shutdown
  }

 --r5Pyd7+fXNt84Ff3--

Responsible-Changed-From-To: bin-bug-people->bouyer
Responsible-Changed-By: bouyer@NetBSD.org
Responsible-Changed-When: Mon, 13 Feb 2012 22:42:19 +0000
Responsible-Changed-Why:
I broke it


State-Changed-From-To: open->closed
State-Changed-By: bouyer@NetBSD.org
State-Changed-When: Mon, 13 Feb 2012 22:42:19 +0000
State-Changed-Why:
Should be fixed now


From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46015 CVS commit: src/tests/fs/nfs
Date: Mon, 13 Feb 2012 22:40:43 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Mon Feb 13 22:40:43 UTC 2012

 Modified Files:
 	src/tests/fs/nfs: Makefile t_rquotad.sh

 Log Message:
 When I split non-quota-specific functions out from ../ffs/quotas_common.sh
 I forgot to ajust this test.
 Fix PR bin/46015


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/fs/nfs/Makefile
 cvs rdiff -u -r1.1 -r1.2 src/tests/fs/nfs/t_rquotad.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search