NetBSD Problem Report #46075

From asau@inbox.ru  Wed Feb 22 22:55:50 2012
Return-Path: <asau@inbox.ru>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 392BC63BCEF
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 22 Feb 2012 22:55:50 +0000 (UTC)
Message-Id: <8762eyscjz.fsf@inbox.ru>
Date: Thu, 23 Feb 2012 02:55:44 +0400
From: Aleksej Saushev <asau@inbox.ru>
Reply-To: asau@inbox.ru
To: gnats-bugs@gnats.NetBSD.org
Subject: No set_color_pair in terminfo

>Number:         46075
>Category:       lib
>Synopsis:       No set_color_pair in terminfo
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 22 23:00:01 +0000 2012
>Closed-Date:    Fri Feb 24 20:35:13 +0000 2012
>Last-Modified:  Fri Feb 24 20:35:13 +0000 2012
>Originator:     asau@inbox.ru
>Release:        NetBSD 5.99.60
>Organization:
>Environment:
System: NetBSD lithium 5.99.60 NetBSD 5.99.60 (GENERIC) #1: Fri Jan 27 02:12:22 MSK 2012 asau@lithium:/home/asau/var/netbsd/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
	NetBSD's terminfo doesn't define "set_color_pair".
	When looking at the code, one can find that it defines "set_color_paid" macro.

	In particular, term.h defines

#define set_color_paid			 t_set_color_paid(cur_term)

#define t_set_color_paid(t)		(t)->strs[TICODE_scp]

	TICODE_scp maps to "sp" capability as defined in src/lib/libterminfo/termcap_map.c:

	{ "sp", TICODE_scp },

	FreeBSD 9.0 terminfo(5) reports that it corresponds to:

       set_color_pair                scp        sp        Set current color
                                                          pair to #1

>How-To-Repeat:
	Try building any program that uses terminfo's/curses' "set_color_pair".
>Fix:

Rename "set_color_paid" to "set_color_pair" as in other terminfo implementations.

Index: lib/libterminfo/term.h
===================================================================
RCS file: /cvsroot/src/lib/libterminfo/term.h,v
retrieving revision 1.10
diff -u -r1.10 term.h
--- lib/libterminfo/term.h	4 Oct 2011 11:01:14 -0000	1.10
+++ lib/libterminfo/term.h	22 Feb 2012 22:40:09 -0000
@@ -1012,7 +1012,7 @@
 #define t_set_bottom_margin_parm(t)	(t)->strs[TICODE_smgbp]
 #define t_set_clock(t)			(t)->strs[TICODE_sclk]
 #define t_set_color_band(t)		(t)->strs[TICODE_setcolor]
-#define t_set_color_paid(t)		(t)->strs[TICODE_scp]
+#define t_set_color_pair(t)		(t)->strs[TICODE_scp]
 #define t_set_foreground(t)		(t)->strs[TICODE_setf]
 #define t_set_left_margin(t)		(t)->strs[TICODE_smgl]
 #define t_set_left_margin_parm(t)	(t)->strs[TICODE_smglp]
@@ -1407,7 +1407,7 @@
 #define set_bottom_margin_parm		 t_set_bottom_margin_parm(cur_term)
 #define set_clock			 t_set_clock(cur_term)
 #define set_color_band			 t_set_color_band(cur_term)
-#define set_color_paid			 t_set_color_paid(cur_term)
+#define set_color_pair			 t_set_color_pair(cur_term)
 #define set_foreground			 t_set_foreground(cur_term)
 #define set_left_margin			 t_set_left_margin(cur_term)
 #define set_left_margin_parm		 t_set_left_margin_parm(cur_term)

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46075 CVS commit: src/lib/libterminfo
Date: Wed, 22 Feb 2012 18:11:20 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Feb 22 23:11:20 UTC 2012

 Modified Files:
 	src/lib/libterminfo: term.h

 Log Message:
 PR/46075: Asau: fix typo set_color_paid -> set_color_pair


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 src/lib/libterminfo/term.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Thu, 23 Feb 2012 00:03:25 +0000
State-Changed-Why:
Christos committed a fix -- ok to close?


From: Aleksej Saushev <asau@inbox.ru>
To: gnats-bugs@NetBSD.org
Cc: lib-bug-people@netbsd.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org, wiz@NetBSD.org
Subject: Re: lib/46075 (No set_color_pair in terminfo)
Date: Thu, 23 Feb 2012 11:04:44 +0400

 wiz@NetBSD.org writes:

 > Synopsis: No set_color_pair in terminfo
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: wiz@NetBSD.org
 > State-Changed-When: Thu, 23 Feb 2012 00:03:25 +0000
 > State-Changed-Why:
 > Christos committed a fix -- ok to close?

 No, please, I want it in netbsd-6 at least.

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: lib/46075 (No set_color_pair in terminfo)
Date: Thu, 23 Feb 2012 08:57:42 +0100

 On Thu, Feb 23, 2012 at 11:04:44AM +0400, Aleksej Saushev wrote:
 > No, please, I want it in netbsd-6 at least.

 It's probably easiest if you request a pullup then.
  Thomas

State-Changed-From-To: feedback->pending-pullups
State-Changed-By: asau@NetBSD.org
State-Changed-When: Thu, 23 Feb 2012 22:10:07 +0000
State-Changed-Why:
pullup-6 #42


From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46075 CVS commit: [netbsd-6] src/lib/libterminfo
Date: Fri, 24 Feb 2012 16:29:34 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Fri Feb 24 16:29:33 UTC 2012

 Modified Files:
 	src/lib/libterminfo [netbsd-6]: term.h

 Log Message:
 Pull up following revision(s) (requested by asau in ticket #42):
 	lib/libterminfo/term.h: revision 1.11
 PR/46075: Asau: fix typo set_color_paid -> set_color_pair


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.10.4.1 src/lib/libterminfo/term.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: asau@NetBSD.org
State-Changed-When: Fri, 24 Feb 2012 20:35:13 +0000
State-Changed-Why:
Pullups done.


>Unformatted:

Home	PR Database Search