NetBSD Problem Report #46259

From www@NetBSD.org  Mon Mar 26 07:25:09 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 44EBC63E3D8
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 26 Mar 2012 07:25:09 +0000 (UTC)
Message-Id: <20120326072508.B0D0663BBEC@www.NetBSD.org>
Date: Mon, 26 Mar 2012 07:25:08 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Use the correct parameter in ufs_extattr.c
X-Send-Pr-Version: www-1.0

>Number:         46259
>Category:       kern
>Synopsis:       Use the correct parameter in ufs_extattr.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 26 07:30:00 +0000 2012
>Closed-Date:    Mon Apr 02 22:27:50 +0000 2012
>Last-Modified:  Mon Apr 02 22:27:50 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Change parameter from attr to attrname.
>How-To-Repeat:

>Fix:
diff -u -p -r1.37 ufs_extattr.c
--- sys/ufs/ufs/ufs_extattr.c	13 Mar 2012 18:41:14 -0000	1.37
+++ sys/ufs/ufs/ufs_extattr.c	23 Mar 2012 10:18:18 -0000
@@ -133,7 +133,7 @@ from_freebsd_extattr(int attrnamespace, 

 	attr = kmem_alloc(len, KM_SLEEP);

-	snprintf(attr, len, "%s.%s", namespace, attr);
+	snprintf(attr, len, "%s.%s", namespace, attrname);

 	return attr;
 }

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 26 Mar 2012 11:03:55 +0000
State-Changed-Why:
Committed, thank you!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46259 CVS commit: src/sys/ufs/ufs
Date: Mon, 26 Mar 2012 11:03:44 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Mon Mar 26 11:03:44 UTC 2012

 Modified Files:
 	src/sys/ufs/ufs: ufs_extattr.c

 Log Message:
 Fix wrong variable in snprintf. From Henning Petersen in PR 46259,
 ok manu@


 To generate a diff of this commit:
 cvs rdiff -u -r1.37 -r1.38 src/sys/ufs/ufs/ufs_extattr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/46259 CVS commit: src/sys/ufs/ufs
Date: Mon, 26 Mar 2012 16:48:40 +0000

 On Mon, Mar 26, 2012 at 11:05:05AM +0000, Thomas Klausner wrote:
  >  Modified Files:
  >  	src/sys/ufs/ufs: ufs_extattr.c
  >  
  >  Log Message:
  >  Fix wrong variable in snprintf. From Henning Petersen in PR 46259,
  >  ok manu@

 Shouldn't this one be pulled up to -6?

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: closed->pending-pullups
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 26 Mar 2012 22:14:23 +0000
State-Changed-Why:
pullup #142


State-Changed-From-To: pending-pullups->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 02 Apr 2012 22:27:50 +0000
State-Changed-Why:
Actually, the code wasn't in netbsd-6 yet.


>Unformatted:

Home	PR Database Search