NetBSD Problem Report #46303

From www@NetBSD.org  Fri Apr  6 13:37:42 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 1B4E863B9FE
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  6 Apr 2012 13:37:42 +0000 (UTC)
Message-Id: <20120406133741.8711D63B946@www.NetBSD.org>
Date: Fri,  6 Apr 2012 13:37:41 +0000 (UTC)
From: wgstuken@nagler-company.com
Reply-To: wgstuken@nagler-company.com
To: gnats-bugs@NetBSD.org
Subject: PUC devices not in pcidevs - hardcoded numbers in pucdata.c
X-Send-Pr-Version: www-1.0

>Number:         46303
>Category:       kern
>Synopsis:       PUC devices not in pcidevs - hardcoded numbers in pucdata.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    msaitoh
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 06 13:40:00 +0000 2012
>Closed-Date:    Sun Aug 05 17:42:57 +0000 2012
>Last-Modified:  Wed Oct 31 17:30:32 +0000 2012
>Originator:     Wolfgang Stukenbrock
>Release:        current (CVS-repository)
>Organization:
Dr. Nagler & COmpany GmbH
>Environment:
not relevant - found in CVS-repository
>Description:
In src/sys/dev/pci/pucdata.c there are lots of hardcoded devices-ID's for several vendors.
That all should be definitions from pcidevs.
Some affected vendors (not complete ..):
PCI_VENDOR_COMTROL
PCI_VENDOR_EXAR
PCI_VENDOR_LAVA
PCI_VENDOR_LUCENT
CPI_VENDOR_MOXA
....

If there are sets of chips that are matched by masking, there should be a comment that should note  the pcidevs-definitions that are matched.

>How-To-Repeat:
not relevant - found by a look into the CVS-repo
>Fix:
define symbolic names in picdevs and use that one.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->msaitoh
Responsible-Changed-By: msaitoh@NetBSD.org
Responsible-Changed-When: Sun, 05 Aug 2012 17:42:57 +0000
Responsible-Changed-Why:
mine.


State-Changed-From-To: open->closed
State-Changed-By: msaitoh@NetBSD.org
State-Changed-When: Sun, 05 Aug 2012 17:42:57 +0000
State-Changed-Why:
fixed in -current.


From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46303 CVS commit: src/sys/dev/pci
Date: Sun, 5 Aug 2012 17:42:01 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Sun Aug  5 17:42:01 UTC 2012

 Modified Files:
 	src/sys/dev/pci: pucdata.c

 Log Message:
 Use PCI_VENDOR_* and PCI_PRODUCT_*. Fixes PR#46303.


 To generate a diff of this commit:
 cvs rdiff -u -r1.77 -r1.78 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46303 CVS commit: [netbsd-6] src
Date: Wed, 31 Oct 2012 17:27:02 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Wed Oct 31 17:27:02 UTC 2012

 Modified Files:
 	src/share/man/man4 [netbsd-6]: puc.4
 	src/sys/dev/pci [netbsd-6]: pcidevs pucdata.c

 Log Message:
 sys/dev/pci/pucdata.c				1.77-1.82
 sys/dev/pci/pcidevs				1.1125, 1.1129 via patch
 sys/dev/pci/pcidevs.h				regen
 sys/dev/pci/pcidevs_data.h			regen
 share/man/man4/puc.4				1.36-1.38

 Add entries for puc(4) devices into pcidevs.
 Add some Intel devices from document (Intel 7 Series / C216 Chipset
 Family Platform Controller Hub (PCH) Family Specification Update)
 into pcidevs.
 Modify some devices in pcidevs to clarify.
 Add Intel chipset internal serial over lan devices. Closes PR/45567.
 Use PCI_VENDOR_* and PCI_PRODUCT_*. Fixes PR#46303.
 Add EXSYS EX-41098-2 UARTs support. The clock frequency is different
 from other card(s). Fixes PR#46362 reported by Wolfgang Stukenbrock.
 Add Lava Computers SSERIAL-PCI single port serial PCI card.
 Update the manual.


 To generate a diff of this commit:
 cvs rdiff -u -r1.35 -r1.35.4.1 src/share/man/man4/puc.4
 cvs rdiff -u -r1.1102.2.8 -r1.1102.2.9 src/sys/dev/pci/pcidevs
 cvs rdiff -u -r1.76 -r1.76.8.1 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search