NetBSD Problem Report #46311

From www@NetBSD.org  Sun Apr  8 23:33:53 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 3657A63BBEC
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  8 Apr 2012 23:33:53 +0000 (UTC)
Message-Id: <20120408233352.8227063B9FE@www.NetBSD.org>
Date: Sun,  8 Apr 2012 23:33:52 +0000 (UTC)
From: miod@online.fr
Reply-To: miod@online.fr
To: gnats-bugs@NetBSD.org
Subject: sys/arch/sgimips/dev/imc.c refers to uninitialized mach_boardrev variable
X-Send-Pr-Version: www-1.0

>Number:         46311
>Category:       port-sgimips
>Synopsis:       sys/arch/sgimips/dev/imc.c refers to uninitialized mach_boardrev variable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sgimips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 08 23:35:00 +0000 2012
>Originator:     Miod Vallat
>Release:        
>Organization:
>Environment:
>Description:
sys/arch/sgimips/dev/imc.c will select different settings depending upon the value of mach_boardrev, in the IP22/IP24 case. However this variable is never set in machdep.c on those systems (and has a value of zero).

The affected logic is borrowed from Linux, which uses the board revision computed from the IMC SysID register here.
>How-To-Repeat:
Code inspection.
>Fix:
Either initialize mach_boardrev in the IP22/IP24 case, or use the IMC SysID register instead of mach_boardrev in the arbitration logic.

Home	PR Database Search