NetBSD Problem Report #46311

From  Sun Apr  8 23:33:53 2012
Return-Path: <>
Received: from ( [])
	by (Postfix) with ESMTP id 3657A63BBEC
	for <>; Sun,  8 Apr 2012 23:33:53 +0000 (UTC)
Message-Id: <>
Date: Sun,  8 Apr 2012 23:33:52 +0000 (UTC)
Subject: sys/arch/sgimips/dev/imc.c refers to uninitialized mach_boardrev variable
X-Send-Pr-Version: www-1.0

>Number:         46311
>Category:       port-sgimips
>Synopsis:       sys/arch/sgimips/dev/imc.c refers to uninitialized mach_boardrev variable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sgimips-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 08 23:35:00 +0000 2012
>Originator:     Miod Vallat
sys/arch/sgimips/dev/imc.c will select different settings depending upon the value of mach_boardrev, in the IP22/IP24 case. However this variable is never set in machdep.c on those systems (and has a value of zero).

The affected logic is borrowed from Linux, which uses the board revision computed from the IMC SysID register here.
Code inspection.
Either initialize mach_boardrev in the IP22/IP24 case, or use the IMC SysID register instead of mach_boardrev in the arbitration logic.

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD:,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.