NetBSD Problem Report #46369

From www@NetBSD.org  Wed Apr 25 07:51:18 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 3279663CD2A
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 25 Apr 2012 07:51:18 +0000 (UTC)
Message-Id: <20120425075117.A4C0863C4B1@www.NetBSD.org>
Date: Wed, 25 Apr 2012 07:51:17 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Change type of variable rv.
X-Send-Pr-Version: www-1.0

>Number:         46369
>Category:       kern
>Synopsis:       Change type of variable rv.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Apr 25 07:55:00 +0000 2012
>Closed-Date:    Wed Jun 01 12:14:47 +0000 2016
>Last-Modified:  Wed Jun 01 12:15:01 +0000 2016
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Change type of variable rv from int to bool.
>How-To-Repeat:

>Fix:
diff -u -p -r1.144 uvm_mmap.c
--- sys/uvm/uvm_mmap.c	27 Jan 2012 19:48:41 -0000	1.144
+++ sys/uvm/uvm_mmap.c	22 Apr 2012 09:52:35 -0000
@@ -570,7 +570,8 @@ sys___msync13(struct lwp *l, const struc
 	vaddr_t addr;
 	vsize_t size, pageoff;
 	struct vm_map *map;
-	int error, rv, flags, uvmflags;
+	int error, flags, uvmflags;
+	bool rv;

 	/*
 	 * extract syscall args from the uap

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Wed, 01 Jun 2016 12:14:47 +0000
Responsible-Changed-Why:
I picked itup


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 01 Jun 2016 12:14:47 +0000
State-Changed-Why:
Requested change has been committed.


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46369 CVS commit: src/sys/uvm
Date: Wed, 1 Jun 2016 12:14:08 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Wed Jun  1 12:14:08 UTC 2016

 Modified Files:
 	src/sys/uvm: uvm_mmap.c

 Log Message:
 Variable rv is always used as a true/false boolen, so set its type
 correctly.

 From PR kern/46369


 To generate a diff of this commit:
 cvs rdiff -u -r1.158 -r1.159 src/sys/uvm/uvm_mmap.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search