NetBSD Problem Report #46410

From www@NetBSD.org  Fri May  4 12:06:17 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 6F7C263B91F
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  4 May 2012 12:06:17 +0000 (UTC)
Message-Id: <20120504120616.C917563B915@www.NetBSD.org>
Date: Fri,  4 May 2012 12:06:16 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: devel/glib2 2.32.2 fails to compile on Solaris
X-Send-Pr-Version: www-1.0

>Number:         46410
>Category:       pkg
>Synopsis:       devel/glib2 2.32.2 fails to compile on Solaris
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 04 12:10:00 +0000 2012
>Closed-Date:    Tue Apr 09 11:20:58 +0000 2013
>Last-Modified:  Tue Apr 09 11:40:03 +0000 2013
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
I can't compile devel/glib2 on Solaris any longer. See pkg/41601 for reference.

  CC     unix.o
  CCLD   unix
  CCLD   unix-nothreads
  CC     include.o
In file included from /software/local/gcc/sunos5.10-x64/gcc-4.7.0/bin/../lib/gcc/i386-pc-solaris2.10/4.7.0/include-fixed/pthread.h:20:0,
                 from include.c:6:
/software/local/gcc/sunos5.10-x64/gcc-4.7.0/bin/../lib/gcc/i386-pc-solaris2.10/4.7.0/include-fixed/sys/feature_tests.h:341:2: error: #error "Compiler or options invalid for pre-UNIX 03 X/Open applications    and pre-2001 POSIX applications"
gmake[4]: *** [include.o] Error 1
gmake[4]: Leaving directory `/pkgsrc/source/pkgsrc/devel/glib2/work.pkgsrc-i86/glib-2.32.2/glib/tests'

After adding

CFLAGS.SunOS+= -D_XPG6

to Makefile, compilation breaks at

  CC     libgio_2_0_la-gsocket.lo
gsocket.c: In function 'g_socket_get_available_bytes':
gsocket.c:2391:32: error: 'FIONREAD' undeclared (first use in this function)
gsocket.c:2391:32: note: each undeclared identifier is reported only once for each function it appears in
gmake[4]: *** [libgio_2_0_la-gsocket.lo] Error 1

This is fixed by

#ifdef __sun__
#include <sys/filio.h>
#endif

in gio/gsocket.c. After that, compilation succeeds.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sat, 02 Jun 2012 05:09:05 +0000
Responsible-Changed-Why:
Problem on Solaris.


From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/46410
Date: Tue, 9 Apr 2013 10:43:52 +0100

 This was fixed upstream in

 commit cc80ae321fdfdcc90596940c8161861d25b20eed
 Author: Matthias Clasen <mclasen@redhat.com>
 Date:   Mon Aug 6 11:55:59 2012 -0400

     Solaris build fix for GIO

     Solaris/OpenSolaris/OpenIndiana define FIONREAD in sys/filio.h.
     This commit adds a configure check for this header, and includes
     it conditionally in gio/gsocket.c.

     Patch by Fabian Groffen, bug 675524.

 so would have apeared in glib 2.32.3, and fixed in pkgsrc with

 revision 1.18
 date: 2012/05/15 09:20:15;  author: adam;  state: Exp;  lines: +4 -4
 Changes 2.32.3:

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 09 Apr 2013 11:20:58 +0000
State-Changed-Why:
Fixed by update of glib2 to 2.32.3.
Thanks for your notice!


From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Patrick Welche <prlw1@cam.ac.uk>, solaris-pkg-people@NetBSD.org,
 gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/46410
Date: Tue, 09 Apr 2013 12:35:20 +0200

 On 09.04.13 11:45, Patrick Welche wrote:
 > The following reply was made to PR pkg/46410; it has been noted by GNATS.
 >
 > From: Patrick Welche<prlw1@cam.ac.uk>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: pkg/46410
 > Date: Tue, 9 Apr 2013 10:43:52 +0100
 >
 >   This was fixed upstream in
 >
 >   commit cc80ae321fdfdcc90596940c8161861d25b20eed
 >   Author: Matthias Clasen<mclasen@redhat.com>
 >   Date:   Mon Aug 6 11:55:59 2012 -0400
 >
 >       Solaris build fix for GIO
 >
 >       Solaris/OpenSolaris/OpenIndiana define FIONREAD in sys/filio.h.
 >       This commit adds a configure check for this header, and includes
 >       it conditionally in gio/gsocket.c.
 >
 >       Patch by Fabian Groffen, bug 675524.
 >
 >   so would have apeared in glib 2.32.3, and fixed in pkgsrc with
 >
 >   revision 1.18
 >   date: 2012/05/15 09:20:15;  author: adam;  state: Exp;  lines: +4 -4
 >   Changes 2.32.3:

 That is probably correct. At the moment I have no local patches for this 
 problem active, and the package builds for me.

 Thanks for checking. Please close this PR.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

>Unformatted:

Home	PR Database Search