NetBSD Problem Report #46491

From www@NetBSD.org  Mon May 28 17:04:46 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0F6F663B89C
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 28 May 2012 17:04:46 +0000 (UTC)
Message-Id: <20120528170445.293AE63B882@www.NetBSD.org>
Date: Mon, 28 May 2012 17:04:45 +0000 (UTC)
From: ftigeot@wolfpond.org
Reply-To: ftigeot@wolfpond.org
To: gnats-bugs@NetBSD.org
Subject: audio/cdparanoia doesn't build
X-Send-Pr-Version: www-1.0

>Number:         46491
>Category:       pkg
>Synopsis:       audio/cdparanoia doesn't build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 28 17:05:00 +0000 2012
>Last-Modified:  Tue May 29 11:55:01 +0000 2012
>Originator:     Francois Tigeot
>Release:        DragonFly
>Organization:
>Environment:
DragonFly akane.zefyris.com 3.1-DEVELOPMENT DragonFly v3.1.0.803.g000535-DEVELOPMENT #181: Sat May 26 22:02:01 CEST 2012     ftigeot@akane.zefyris.com:/usr/obj/usr/src/sys/X86_64_GENERIC  x86_64
>Description:
audio/cdparanoia fails to build with the following error:

gmake[1]: Entering directory `/usr/pkgsrc/audio/cdparanoia/work/cdparanoia-III-10.2/interface'
/usr/pkg/bin/gmake libcdda_interface.la VERSION=102 CFLAGS="-O -O -march=core2 -g -pipe" 
gmake[2]: Entering directory `/usr/pkgsrc/audio/cdparanoia/work/cdparanoia-III-10.2/interface'
libtool  --mode=compile cc -O -O -march=core2 -g -pipe -c scan_devices.c
libtool  --mode=compile cc -O -O -march=core2 -g -pipe -c common_interface.c
libtool: compile:  cc -O -O -march=core2 -g -pipe -c common_interface.c  -fPIC -DPIC -o .libs/common_interface.o
libtool: compile:  cc -O -O -march=core2 -g -pipe -c scan_devices.c  -fPIC -DPIC -o .libs/scan_devices.o
scan_devices.c: In function 'cdda_identify_scsi':
scan_devices.c:799: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:799: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:803: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:807: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:807: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:825: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:826: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:826: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:838: warning: cast to pointer from integer of different size
scan_devices.c:850: warning: cast to pointer from integer of different size
scan_devices.c:910: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:911: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:911: error: 'cdrom_drive' has no member named 'private'
scan_devices.c:912: error: 'cdrom_drive' has no member named 'private'
gmake[2]: *** [scan_devices.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
libtool: compile:  cc -O -O -march=core2 -g -pipe -c common_interface.c -o common_interface.o >/dev/null 2>&1
gmake[2]: Leaving directory `/usr/pkgsrc/audio/cdparanoia/work/cdparanoia-III-10.2/interface'
gmake[1]: *** [slib] Error 2
gmake[1]: Leaving directory `/usr/pkgsrc/audio/cdparanoia/work/cdparanoia-III-10.2/interface'
gmake: *** [all] Error 2
*** Error code 2

Stop.
bmake: stopped in /usr/pkgsrc/audio/cdparanoia
*** Error code 1

Stop.

>How-To-Repeat:
Using pkgsrc-current, try to build audio/cdparanoia
>Fix:
patches/patch-ch includes the following change:

--  cdda_private_data_t *private;
-+  cdda_private_data_t *private_data;

If it is removed, the package builds and installs as expected.

>Audit-Trail:
From: Francois Tigeot <ftigeot@wolfpond.org>
To: gnats-bugs@NetBSD.org
Cc: ftigeot@wolfpond.org
Subject: Re: pkg/46491: audio/cdparanoia doesn't build
Date: Mon, 28 May 2012 19:07:47 +0200

 --/04w6evG8XlLl3ft
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Mon, May 28, 2012 at 05:05:00PM +0000, gnats-admin@NetBSD.org wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `pkg/46491'.
 > The individual assigned to look at your
 > report is: pkg-manager. 
 > 
 > >Category:       pkg
 > >Responsible:    pkg-manager
 > >Synopsis:       audio/cdparanoia doesn't build
 > >Arrival-Date:   Mon May 28 17:05:00 +0000 2012

 New version of patch-ch


 -- 
 Francois Tigeot

 --/04w6evG8XlLl3ft
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch-ch

 $NetBSD$

 --- interface/cdda_interface.h.orig	2008-09-11 10:43:52.000000000 +0000
 +++ interface/cdda_interface.h
 @@ -18,9 +18,24 @@
  #endif
  #define CD_FRAMESAMPLES (CD_FRAMESIZE_RAW / 4)

 +#if defined(__APPLE__) && defined(__MACH__)
 +#include <IOKit/IOKitLib.h>
 +#include <IOKit/storage/IOCDTypes.h>
 +#endif
 +
  #include <sys/types.h>
  #include <signal.h>

 +#if defined(__FreeBSD__) || defined(__DragonFly__)
 +#define CAM_NO_SCSI_INQUIRY
 +#include <stdio.h>
 +#include <camlib.h>
 +#endif
 +
 +#if defined(__NetBSD__) || (defined(__APPLE__) && defined(__MACH__))
 +#define ENOMEDIUM 12345
 +#endif
 +
  #define MAXTRK 100

  typedef struct TOC {	/* structure of table of contents */
 @@ -35,6 +50,7 @@ typedef struct TOC {	/* structure of tab
  #define TEST_INTERFACE	 2
  #define SGIO_SCSI	 3
  #define SGIO_SCSI_BUGGY1 4
 +#define OSX_IOKIT        5

  #define CDDA_MESSAGE_FORGETIT 0
  #define CDDA_MESSAGE_PRINTIT 1
 @@ -49,13 +65,27 @@ typedef struct cdrom_drive{
    int opened; /* This struct may just represent a candidate for opening */

    char *cdda_device_name;
 +#if !defined(__FreeBSD__)
    char *ioctl_device_name;

    int cdda_fd;
 -  int ioctl_fd;

 -  char *drive_model;
    int drive_type;
 +#else
 +  struct cam_device *dev;
 +  union ccb *ccb;
 +#endif
 +
 +#if defined(__APPLE__) && defined(__MACH__)
 +  io_object_t io;
 +  int fd;
 +  char *dev;
 +  CDTOC *raw_toc;
 +  int descriptor_count;
 +#endif
 +
 +  int ioctl_fd;
 +  char *drive_model;
    int interface;
    int bigendianp;
    int nsectors;

 --/04w6evG8XlLl3ft--

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/46491: audio/cdparanoia doesn't build
Date: Tue, 29 May 2012 20:52:48 +0900

 On Tue, 29 May 2012 02:05:00 +0900, <ftigeot@wolfpond.org> wrote:

 >> Fix:
 > patches/patch-ch includes the following change:
 >
 > --  cdda_private_data_t *private;
 > -+  cdda_private_data_t *private_data;
 >
 > If it is removed, the package builds and installs as expected.

 This change may affect to C++ packages using cdparanoia API,
 because `private' is reserved in C++.

 In package Makefile:
 CFLAGS+=	-Dprivate_data=private

 I don't know why it does not effect for you.

 -- 
 OBATA Akio / obache@NetBSD.org

Home	PR Database Search