NetBSD Problem Report #46521

From jbernard@nool.mines.edu  Sat Jun  2 15:43:16 2012
Return-Path: <jbernard@nool.mines.edu>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0DC9D63BA27
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  2 Jun 2012 15:43:16 +0000 (UTC)
Message-Id: <20120602142714.A22ADA8A0@nool.mines.edu>
Date: Sat,  2 Jun 2012 08:27:14 -0600 (MDT)
From: jbernard@nool.mines.edu
Reply-To: jbernard@nool.mines.edu
To: gnats-bugs@gnats.NetBSD.org
Subject: syntax error in an instance of test in /etc/weekly script 1.26
X-Send-Pr-Version: 3.95

>Number:         46521
>Category:       misc
>Synopsis:       In /etc/weekly 1.26: ... if [ -x /usr/libexec/makewhatis ... -o -o ...
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 02 15:45:00 +0000 2012
>Closed-Date:    Sun Oct 06 12:39:53 +0000 2013
>Last-Modified:  Sun Oct 06 12:39:53 +0000 2013
>Originator:     Jim Bernard
>Release:        NetBSD 6.99.7
>Organization:
self
>Environment:
System: NetBSD 6.99.7 #0: Sat May 26 18:51:11 MDT 2012 i386
Architecture: i386
Machine: i386
>Description:
	The rebuild_whatisdb section contains an invocation of test with
	a folded line (lines 84 and 85), within which "-o" appears twice
	consecutively, once at the end of the first line, and once at the
	beginning of the second.  The offending construct is

	  if [ -x /usr/libexec/makewhatis -a \( -f /etc/man.conf -o \
	      -o -d /usr/share/man \) ]; then

>How-To-Repeat:
	Set rebuild_whatisdb=YES in /etc/weekly.conf and notice the message

	  [: closing paren expected
	  Not rebuilding whatis databases

	in the /etc/weekly report.
>Fix:
	Remove the redundancy.  E.g., change to:

	  if [ -x /usr/libexec/makewhatis \
		-a \( -f /etc/man.conf -o -d /usr/share/man \) ]; then

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46521 CVS commit: src/etc
Date: Sat, 2 Jun 2012 11:52:25 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sat Jun  2 15:52:25 UTC 2012

 Modified Files:
 	src/etc: weekly

 Log Message:
 PR/46521: Jim Bernard: remove duplicate -o


 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.27 src/etc/weekly

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46521 CVS commit: [netbsd-6] src/etc
Date: Sun, 18 Nov 2012 19:07:00 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Sun Nov 18 19:07:00 UTC 2012

 Modified Files:
 	src/etc [netbsd-6]: weekly

 Log Message:
 Pull up following revision(s) (requested by christos in ticket #675):
 	etc/weekly: revision 1.27
 PR/46521: Jim Bernard: remove duplicate -o


 To generate a diff of this commit:
 cvs rdiff -u -r1.25.2.2 -r1.25.2.3 src/etc/weekly

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 06 Oct 2013 12:39:53 +0000
State-Changed-Why:
fixed last year


>Unformatted:

Home	PR Database Search