NetBSD Problem Report #46561

From www@NetBSD.org  Fri Jun  8 07:46:45 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 8F67963B89C
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  8 Jun 2012 07:46:45 +0000 (UTC)
Message-Id: <20120608074644.F415963B882@www.NetBSD.org>
Date: Fri,  8 Jun 2012 07:46:44 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Remove self-assignment from getaddrinfo.c
X-Send-Pr-Version: www-1.0

>Number:         46561
>Category:       lib
>Synopsis:       Remove self-assignment from getaddrinfo.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 08 07:50:00 +0000 2012
>Closed-Date:    Fri Jun 08 07:54:06 +0000 2012
>Last-Modified:  Fri Jun 08 07:55:01 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Remove self-assignment from getaddrinfo.c
>How-To-Repeat:

>Fix:
diff -u -p -r1.100 getaddrinfo.c
--- lib/libc/net/getaddrinfo.c	20 Mar 2012 12:04:01 -0000	1.100
+++ lib/libc/net/getaddrinfo.c	7 Jun 2012 02:54:27 -0000
@@ -436,7 +436,7 @@ getaddrinfo(const char *hostname, const 
 		}
 		error = get_portmatch(pai, servname, &svd);
 		if (error)
-			ERR(error);
+			goto bad;

 		*pai = ai0;
 	}

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Fri, 08 Jun 2012 07:54:06 +0000
State-Changed-Why:
Applied, thanks!


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46561 CVS commit: src/lib/libc/net
Date: Fri, 8 Jun 2012 07:54:14 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri Jun  8 07:54:14 UTC 2012

 Modified Files:
 	src/lib/libc/net: getaddrinfo.c

 Log Message:
 Henning Petersen in PR lib/46561: cosmetic change: avoid self assignement.


 To generate a diff of this commit:
 cvs rdiff -u -r1.100 -r1.101 src/lib/libc/net/getaddrinfo.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search