NetBSD Problem Report #46622

From Wolfgang.Stukenbrock@nagler-company.com  Fri Jun 22 15:23:38 2012
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 6EDC463B85F
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 22 Jun 2012 15:23:38 +0000 (UTC)
Message-Id: <20120622152325.1A3461E80A9@test-s0.nagler-company.com>
Date: Fri, 22 Jun 2012 17:23:25 +0200 (CEST)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0
X-Send-Pr-Version: 3.95

>Number:         46622
>Category:       pkg
>Synopsis:       pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 22 15:25:00 +0000 2012
>Closed-Date:    Sat Jul 14 21:21:32 +0000 2012
>Last-Modified:  Sat Jul 14 21:21:32 +0000 2012
>Originator:     Dr. W. Stukenbrock
>Release:        NetBSD 4.0
>Organization:
Dr. Nagler & Company GmbH
>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	When trying to compile firefox from pkgsrc, xulrunner is requried.
	OK so far, but accedently does xulrunner from pkgsrc2012Q1 no longer
	compile on NetBSD 4.0
	Error Message von Compiler:
	/usr/pkgsrc/devel/xulrunner/work/mozilla-release/js/src/jslock.cpp:325: error: '_SC_NPROCESSORS_ONLN' was not declared in this scope
	A look into the header files show, that this constant is not defined
	on NetBSD 4.0.
>How-To-Repeat:
	Take a NetBSD 4.0 system ant try to install www/firefox from
	pkgsrc-2012Q1. It will fail building xulrunner.
>Fix:
	Not known till now.
	remark: The problem does not happen on 5.1.2.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tnn
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Fri, 22 Jun 2012 19:48:37 +0000
Responsible-Changed-Why:
Over to maintainer.


From: Wolfgang Stukenbrock <wolfgang.stukenbrock@nagler-company.com>
To: gnats-bugs@NetBSD.org
Cc: tnn@NetBSD.org, pkg-manager@NetBSD.org, pkgsrc-bugs@NetBSD.org,
        gnats-admin@NetBSD.org, hauke@NetBSD.org
Subject: Re: pkg/46622 (pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0)
Date: Sun, 24 Jun 2012 16:29:23 +0200

 Hi again,

 here is a patch for the problem.
 It returns the same value aus if the sysconf() call failed and is equal 
 to a simular workaround found in ipc/chronium/src/base/sys_info_posix.cc.

 --- js/src/jslock.cpp.orig      2012-06-24 15:07:53.000000000 +0200
 +++ js/src/jslock.cpp   2012-06-24 15:08:36.000000000 +0200
 @@ -322,8 +322,12 @@
           GetSystemInfo(&sysinfo);
           ncpus = unsigned(sysinfo.dwNumberOfProcessors);
   # else
 +#  ifdef _SC_NPROCESSORS_ONLN
           long n = sysconf(_SC_NPROCESSORS_ONLN);
           ncpus = (n > 0) ? unsigned(n) : 1;
 +#  else
 +       ncpus = 1;
 +#  endif
   # endif
       }
       return ncpus;


 hauke@NetBSD.org wrote:

 > Synopsis: pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0
 > 
 > Responsible-Changed-From-To: pkg-manager->tnn
 > Responsible-Changed-By: hauke@NetBSD.org
 > Responsible-Changed-When: Fri, 22 Jun 2012 19:48:37 +0000
 > Responsible-Changed-Why:
 > Over to maintainer.
 > 
 > 
 > 
 > 
 > 


From: Wolfgang Stukenbrock <wolfgang.stukenbrock@nagler-company.com>
To: gnats-bugs@NetBSD.org
Cc: tnn@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/46622 (pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0)
Date: Fri, 06 Jul 2012 11:40:07 +0200

 Hi again - an alog problem happens with pkgsrc-1012Q2 ...

 Only the file nat needs the patch has changed ..

 new patch for pkgsrc-2012Q2 follows ..


 --- js/src/jsgc.cpp.orig        2012-07-06 11:33:52.000000000 +0200
 +++ js/src/jsgc.cpp     2012-07-06 11:35:11.000000000 +0200
 @@ -2636,8 +2636,12 @@
           GetSystemInfo(&sysinfo);
           ncpus = unsigned(sysinfo.dwNumberOfProcessors);
   # else
 +#  ifdef _SC_NPROCESSORS_ONLN
           long n = sysconf(_SC_NPROCESSORS_ONLN);
           ncpus = (n > 0) ? unsigned(n) : 1;
 +#  else
 +       ncpus = 1;
 +#  endif
   # endif
       }
       return ncpus;

 Wolfgang Stukenbrock wrote:

 > The following reply was made to PR pkg/46622; it has been noted by GNATS.
 > 
 > From: Wolfgang Stukenbrock <wolfgang.stukenbrock@nagler-company.com>
 > To: gnats-bugs@NetBSD.org
 > Cc: tnn@NetBSD.org, pkg-manager@NetBSD.org, pkgsrc-bugs@NetBSD.org,
 >         gnats-admin@NetBSD.org, hauke@NetBSD.org
 > Subject: Re: pkg/46622 (pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0)
 > Date: Sun, 24 Jun 2012 16:29:23 +0200
 > 
 >  Hi again,
 >  
 >  here is a patch for the problem.
 >  It returns the same value aus if the sysconf() call failed and is equal 
 >  to a simular workaround found in ipc/chronium/src/base/sys_info_posix.cc.
 >  
 >  --- js/src/jslock.cpp.orig      2012-06-24 15:07:53.000000000 +0200
 >  +++ js/src/jslock.cpp   2012-06-24 15:08:36.000000000 +0200
 >  @@ -322,8 +322,12 @@
 >            GetSystemInfo(&sysinfo);
 >            ncpus = unsigned(sysinfo.dwNumberOfProcessors);
 >    # else
 >  +#  ifdef _SC_NPROCESSORS_ONLN
 >            long n = sysconf(_SC_NPROCESSORS_ONLN);
 >            ncpus = (n > 0) ? unsigned(n) : 1;
 >  +#  else
 >  +       ncpus = 1;
 >  +#  endif
 >    # endif
 >        }
 >        return ncpus;
 >  
 >  
 >  hauke@NetBSD.org wrote:
 >  
 >  > Synopsis: pkgsrc-2012Q1 xulrunner-11.0nb1 does not compile on NetBSD 4.0
 >  > 
 >  > Responsible-Changed-From-To: pkg-manager->tnn
 >  > Responsible-Changed-By: hauke@NetBSD.org
 >  > Responsible-Changed-When: Fri, 22 Jun 2012 19:48:37 +0000
 >  > Responsible-Changed-Why:
 >  > Over to maintainer.
 >  > 
 >  > 
 >  > 
 >  > 
 >  > 
 >  
 >  
 > 
 > 


 -- 


 Dr. Nagler & Company GmbH
 Hauptstraße 9
 92253 Schnaittenbach

 Tel. +49 9622/71 97-42
 Fax +49 9622/71 97-50

 Wolfgang.Stukenbrock@nagler-company.com
 http://www.nagler-company.com


 Hauptsitz: Schnaittenbach
 Handelregister: Amberg HRB
 Gerichtsstand: Amberg
 Steuernummer: 201/118/51825
 USt.-ID-Nummer: DE 273143997
 Geschäftsführer: Dr. Martin Nagler, Dr. Dr. Karl-Kuno Kunze


Responsible-Changed-From-To: tnn->ryoon
Responsible-Changed-By: ryoon@NetBSD.org
Responsible-Changed-When: Sat, 14 Jul 2012 21:18:27 +0000
Responsible-Changed-Why:
I will take it.


From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46622 CVS commit: pkgsrc/devel/xulrunner
Date: Sat, 14 Jul 2012 21:19:49 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Sat Jul 14 21:19:49 UTC 2012

 Modified Files:
 	pkgsrc/devel/xulrunner: distinfo
 Added Files:
 	pkgsrc/devel/xulrunner/patches: patch-js_src_jsgc.cpp

 Log Message:
 Fix PR pkg/46622

 * Fix build on NetBSD 4


 To generate a diff of this commit:
 cvs rdiff -u -r1.71 -r1.72 pkgsrc/devel/xulrunner/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/devel/xulrunner/patches/patch-js_src_jsgc.cpp

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: ryoon@NetBSD.org
State-Changed-When: Sat, 14 Jul 2012 21:21:32 +0000
State-Changed-Why:
Suggested patch has been committed.
Thank you.


>Unformatted:

Home	PR Database Search