NetBSD Problem Report #46706

From www@NetBSD.org  Sun Jul 15 13:07:55 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id CE68F63B882
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 15 Jul 2012 13:07:54 +0000 (UTC)
Message-Id: <20120715130754.3936D63B85F@www.NetBSD.org>
Date: Sun, 15 Jul 2012 13:07:54 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Move macro into _KERNEL block.
X-Send-Pr-Version: www-1.0

>Number:         46706
>Category:       kern
>Synopsis:       Move macro into _KERNEL block.
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 15 13:10:00 +0000 2012
>Closed-Date:    Wed Jun 01 04:20:42 +0000 2016
>Last-Modified:  Wed Jun 15 04:37:07 +0000 2016
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Move macro into _KERNEL block, is only used in kernel.
>How-To-Repeat:

>Fix:
diff -u -p -r1.129 socketvar.h
--- sys/sys/socketvar.h	1 Feb 2012 02:27:23 -0000	1.129
+++ sys/sys/socketvar.h	14 Jul 2012 02:46:01 -0000
@@ -180,15 +180,6 @@ struct socket {
 	kauth_cred_t	so_cred;	/* socket credentials */
 };

-#define	SB_EMPTY_FIXUP(sb)						\
-do {									\
-	KASSERT(solocked((sb)->sb_so));					\
-	if ((sb)->sb_mb == NULL) {					\
-		(sb)->sb_mbtail = NULL;					\
-		(sb)->sb_lastrecord = NULL;				\
-	}								\
-} while (/*CONSTCOND*/0)
-
 /*
  * Socket state bits.
  */
@@ -234,6 +225,15 @@ struct sockopt {
 	uint8_t		sopt_buf[sizeof(int)];	/* internal storage */
 };

+#define	SB_EMPTY_FIXUP(sb)						\
+do {									\
+	KASSERT(solocked((sb)->sb_so));					\
+	if ((sb)->sb_mb == NULL) {					\
+		(sb)->sb_mbtail = NULL;					\
+		(sb)->sb_lastrecord = NULL;				\
+	}								\
+} while (/*CONSTCOND*/0)
+
 extern u_long		sb_max;
 extern int		somaxkva;
 extern int		sock_loan_thresh;

>Release-Note:

>Audit-Trail:
From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/46706 CVS commit: src/sys/sys
Date: Wed, 1 Jun 2016 04:15:54 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Wed Jun  1 04:15:54 UTC 2016

 Modified Files:
 	src/sys/sys: socketvar.h

 Log Message:
 Move macro inside of #ifdef KERNEL

 PR kern/46706


 To generate a diff of this commit:
 cvs rdiff -u -r1.139 -r1.140 src/sys/sys/socketvar.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: kern-bug-people->pgoyete
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Wed, 01 Jun 2016 04:20:42 +0000
Responsible-Changed-Why:
I dealt with it.


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 01 Jun 2016 04:20:42 +0000
State-Changed-Why:
Suggested fix was committed.


Responsible-Changed-From-To: pgoyete->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Wed, 15 Jun 2016 04:37:07 +0000
Responsible-Changed-Why:
Can't spell my own name!


>Unformatted:

Home	PR Database Search