NetBSD Problem Report #46874

From Wolfgang.Stukenbrock@nagler-company.com  Wed Aug 29 16:15:08 2012
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 7493C63B86D
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 29 Aug 2012 16:15:08 +0000 (UTC)
Message-Id: <20120829161459.D9E191E80A9@test-s0.nagler-company.com>
Date: Wed, 29 Aug 2012 18:14:59 +0200 (CEST)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: missing newline in printout for MFI controler if no subtype is present
X-Send-Pr-Version: 3.95

>Number:         46874
>Category:       kern
>Synopsis:       missing newline in printout for MFI controler if no subtype is present
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 29 16:20:00 +0000 2012
>Closed-Date:    Wed Jun 01 04:38:25 +0000 2016
>Last-Modified:  Wed Jun 01 04:38:25 +0000 2016
>Originator:     Wolfgang Stukenbrock
>Release:        NetBSD current
>Organization:
Dr. Nagler & Company GmbH
>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	On mfi-controler without sub-type a newline is missing in the boot messages prior
	the interrupt-at line.
>How-To-Repeat:
	Boot on a system with such a controler.
>Fix:
	The following patch will solve the problem.
	It will print out the name from pcidevs if possible or simply add the new line to the output.

diff -u -r1.3 mfi_pci.c
--- mfi_pci.c   2012/08/29 16:01:23     1.3
+++ mfi_pci.c   2012/08/29 16:11:03
@@ -207,6 +207,13 @@
                        aprint_normal(": vendor 0x%x product 0x%x\n",
                            PCI_VENDOR(subsysid), PCI_PRODUCT(subsysid));
                }
+       } else {
+               subtype = pci_findproduct(pa->pa_id);
+               if (subtype) {
+                       aprint_normal(": %s\n", subtype);
+               } else {
+                       aprint_normal("\n");
+               }
        }

        aprint_normal("%s: interrupting at %s\n", DEVNAME(sc), intrstr);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 01 Jun 2016 04:38:25 +0000
State-Changed-Why:
The code has already been updated appropriately.


>Unformatted:

Home	PR Database Search