NetBSD Problem Report #46954

From Wolfgang.Stukenbrock@nagler-company.com  Fri Sep 14 08:09:13 2012
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id E55CC63B86D
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 14 Sep 2012 08:09:12 +0000 (UTC)
Message-Id: <20120914080857.D952A1E80A9@test-s0.nagler-company.com>
Date: Fri, 14 Sep 2012 10:08:57 +0200 (CEST)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: amanda-client from 2012Q2 runtar command does not close pipe from popen()
X-Send-Pr-Version: 3.95

>Number:         46954
>Category:       pkg
>Synopsis:       amanda-client from 2012Q2 runtar command does not close pipe from popen()
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 14 08:10:00 +0000 2012
>Last-Modified:  Fri Sep 14 12:45:01 +0000 2012
>Originator:     Dr. Wolfgang Stukenbrock
>Release:        NetBSD 5.1.2 pkgsrc 2012Q2
>Organization:
Dr. Nagler & Company GmbH
>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	The runtar command tries to get the version from the gnutar installed and uses popen()
	to get it. After the input is read by fgets(), the FILE* is not closed by pclose()
	as it should be, resulting a a zomby process and open file descriptor until the
	process exits later.
>How-To-Repeat:
	Found by a look into the sources and the ps-listing
>Fix:
	The following patch will solve this problem:
--- runtar.c    2007-05-04 13:39:05.000000000 +0200
+++ runtar.c-fixed      2012-09-14 10:08:18.000000000 +0200
@@ -98,6 +98,7 @@
                    dbprintf((GNUTAR " version: Read failure; EOF\n"));
                }
            }
+         pclose(version_file);
        } else {
            dbprintf((GNUTAR " version: unavailable: %s\n", strerror(errno)));
        }


>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/46954: amanda-client from 2012Q2 runtar command does not
 close pipe from popen()
Date: Fri, 14 Sep 2012 17:43:43 +0900

 I feel that amanda 3.3.1 in pkgsrc-HEAD still has same issue (and SVN-trunk in upstream).
 Have you reported this issue to upstream?

 -- 
 OBATA Akio / obache@NetBSD.org

From: Wolfgang Stukenbrock <wolfgang.stukenbrock@nagler-company.com>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@NetBSD.org, gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/46954: amanda-client from 2012Q2 runtar command does not close pipe from popen()
Date: Fri, 14 Sep 2012 14:43:31 +0200

 Hi,

 no - we don't use upstream.
 So I haven't seen the same problem there till now.

 best regards

 W. Stukenbrock

 OBATA Akio wrote:

 > The following reply was made to PR pkg/46954; it has been noted by GNATS.
 > 
 > From: "OBATA Akio" <obache@netbsd.org>
 > To: gnats-bugs@netbsd.org
 > Cc: 
 > Subject: Re: pkg/46954: amanda-client from 2012Q2 runtar command does not
 >  close pipe from popen()
 > Date: Fri, 14 Sep 2012 17:43:43 +0900
 > 
 >  I feel that amanda 3.3.1 in pkgsrc-HEAD still has same issue (and SVN-trunk in upstream).
 >  Have you reported this issue to upstream?
 >  
 >  -- 
 >  OBATA Akio / obache@NetBSD.org
 >  




>Unformatted:

Home	PR Database Search