NetBSD Problem Report #47083

From mw@fenrir.wzff.de  Mon Oct 15 22:28:29 2012
Return-Path: <mw@fenrir.wzff.de>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 6D98863E059
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 15 Oct 2012 22:28:29 +0000 (UTC)
Message-Id: <20121015222709.B4C76EEA33F@fenrir.wzff.de>
Date: Tue, 16 Oct 2012 00:27:09 +0200 (CEST)
From: Moritz Wilhelmy <mw@wzff.de>
Reply-To:
To: gnats-bugs@gnats.NetBSD.org
Subject: mail/mutt-devel: missing PLIST entry for compressed mbox patch
X-Send-Pr-Version: 3.95

>Number:         47083
>Category:       pkg
>Synopsis:       mail/mutt-devel: missing PLIST entry for compressed mbox patch
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tonio
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 15 22:30:01 +0000 2012
>Last-Modified:  Thu Dec 27 21:40:13 +0000 2012
>Originator:     Moritz Wilhelmy
>Release:        NetBSD 6.0_BETA2
>Organization:
Fictional Enterprises Ltd
>Environment:
System: NetBSD fenrir.wzff.de 6.0_BETA2 NetBSD 6.0_BETA2 (GENERIC) i386
Architecture: i386
Machine: i386
$NetBSD: DEINSTALL,v 1.3 2006/06/15 20:40:16 jlam Exp $
$NetBSD: INSTALL,v 1.4 2006/06/15 20:40:16 jlam Exp $
$NetBSD: Makefile,v 1.85 2012/09/07 18:36:02 spz Exp $
$NetBSD: PLIST,v 1.23 2010/11/07 14:52:47 tonio Exp $
$NetBSD: distinfo,v 1.72 2012/03/12 14:35:58 wiz Exp $
$NetBSD: options.mk,v 1.43 2012/08/28 20:15:41 tonio Exp $
$NetBSD: patch-aa,v 1.5 2004/07/21 22:37:10 jlam Exp $
$NetBSD: patch-ab,v 1.15 2010/11/07 14:52:47 tonio Exp $
$NetBSD: patch-ac,v 1.8 2009/08/05 11:41:12 hasso Exp $
$NetBSD: patch-ad,v 1.8 2006/08/16 10:42:05 tonio Exp $
$NetBSD: patch-ae,v 1.16 2011/02/03 14:11:51 tron Exp $
$NetBSD: patch-af,v 1.1 2009/08/10 14:18:12 apb Exp $
$NetBSD: patch-ag,v 1.11 2012/03/12 14:35:59 wiz Exp $
$NetBSD: patch-ah,v 1.3 2009/08/10 14:18:12 apb Exp $
$NetBSD: patch-al,v 1.11 2010/11/07 14:52:47 tonio Exp $
$NetBSD: patch-am,v 1.6 2008/05/18 08:26:31 tonio Exp $
$NetBSD: patch-an,v 1.5 2010/11/07 14:52:47 tonio Exp $
$NetBSD: patch-ao,v 1.4 2009/01/26 22:35:03 tonio Exp $
$NetBSD: patch-ap,v 1.2 2009/01/26 22:35:03 tonio Exp $
$NetBSD: patch-aq,v 1.5 2011/07/06 06:24:38 is Exp $
>Description:
Building with compressed mbox patch enabled yields the following error:
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkgsrc/mail/mutt-devel/work/.destdir/usr/pkg/share/doc/mutt/compressed-folders.html
*** Error code 1
>How-To-Repeat:
Install with compressed mbox patch enabled. Watch it fail in PLIST.
>Fix:

Index: options.mk
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/mail/mutt-devel/options.mk,v
retrieving revision 1.43
diff -u -p -r1.43 options.mk
--- options.mk	28 Aug 2012 20:15:41 -0000	1.43
+++ options.mk	15 Oct 2012 22:23:06 -0000
@@ -112,7 +112,9 @@ CONFIGURE_ARGS+=	--disable-hcache
 ###
 ### Compressed mail boxes
 ###
+PLIST_VARS+=		compressed_mbox
 .if !empty(PKG_OPTIONS:Mmutt-compressed-mbox)
+PLIST.compressed_mbox=	yes
 PATCH_SITES+=		http://mutt.org.ua/download/${PKGNAME_NOREV}/
 PATCHFILES+=		patch-${PKGVERSION_NOREV}.rr.compressed.gz
 PATCH_DIST_STRIP=	-p1
Index: PLIST
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/mail/mutt-devel/PLIST,v
retrieving revision 1.23
diff -u -p -r1.23 PLIST
--- PLIST	7 Nov 2010 14:52:47 -0000	1.23
+++ PLIST	15 Oct 2012 22:23:06 -0000
@@ -27,6 +27,7 @@ share/doc/mutt/TODO
 share/doc/mutt/advancedusage.html
 share/doc/mutt/applying-patches.txt
 share/doc/mutt/configuration.html
+${PLIST.compressed_mbox}share/doc/mutt/compressed-folders.html
 share/doc/mutt/devel-notes.txt
 share/doc/mutt/gettingstarted.html
 share/doc/mutt/index.html

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/47083: mail/mutt-devel: missing PLIST entry for compressed
 mbox patch
Date: Tue, 16 Oct 2012 10:13:07 +0200

 On Mon, Oct 15, 2012 at 10:30:01PM +0000, Moritz Wilhelmy wrote:
 > >Number:         47083
 > >Category:       pkg
 > >Synopsis:       mail/mutt-devel: missing PLIST entry for compressed mbox patch

 The file is not installed for me. Please check if additional software
 is needed to generate the file; then we could add it to build depends;
 or disable it's detection.
  Thomas

From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47083: mail/mutt-devel: missing PLIST entry for compressed
 mbox patch
Date: Tue, 16 Oct 2012 10:52:49 +0200

 On Tue, Oct 16, 2012 at 08:15:05 +0000, Thomas Klausner wrote:
 >  The file is not installed for me. Please check if additional software
 >  is needed to generate the file; then we could add it to build depends;
 >  or disable it's detection.

 Quite possible so. I believe the mutt documentation is automatically
 generated from XML with xsltproc(1), if present. Do you have
 textproc/libxslt installed?

 Moritz

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/47083: mail/mutt-devel: missing PLIST entry for compressed
 mbox patch
Date: Tue, 16 Oct 2012 11:11:20 +0200

 On Tue, Oct 16, 2012 at 08:55:07AM +0000, Moritz Wilhelmy wrote:
 >  Quite possible so. I believe the mutt documentation is automatically
 >  generated from XML with xsltproc(1), if present. Do you have
 >  textproc/libxslt installed?

 I tested your patch in an empty sandbox with just the recorded
 dependencies installed, so "no".

 Please extend the patch to either forbid finding it, or
 build-depending on it.

 Thanks,
  Thomas

From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47083: mail/mutt-devel: missing PLIST entry for compressed
 mbox patch
Date: Tue, 16 Oct 2012 11:41:05 +0200

 On Tue, Oct 16, 2012 at 09:15:04 +0000, Thomas Klausner wrote:
 >  I tested your patch in an empty sandbox with just the recorded
 >  dependencies installed, so "no".
 >  
 >  Please extend the patch to either forbid finding it, or
 >  build-depending on it.

 Is this an acceptable solution?


 Index: options.mk
 ===================================================================
 RCS file: /pub/NetBSD-CVS/pkgsrc/mail/mutt-devel/options.mk,v
 retrieving revision 1.43
 diff -u -p -r1.43 options.mk
 --- options.mk	28 Aug 2012 20:15:41 -0000	1.43
 +++ options.mk	16 Oct 2012 09:35:00 -0000
 @@ -112,18 +112,25 @@ CONFIGURE_ARGS+=	--disable-hcache
  ###
  ### Compressed mail boxes
  ###
 +PLIST_VARS+=		compressed_mbox
  .if !empty(PKG_OPTIONS:Mmutt-compressed-mbox)
 +PLIST.compressed_mbox=	yes
 +BUILD_DEPENDS+=		libxslt>=1.0.0:../../textproc/libxslt
  PATCH_SITES+=		http://mutt.org.ua/download/${PKGNAME_NOREV}/
  PATCHFILES+=		patch-${PKGVERSION_NOREV}.rr.compressed.gz
  PATCH_DIST_STRIP=	-p1
  CONFIGURE_ARGS+=	--enable-compressed
 -SUBST_CLASSES+=		compress
 +SUBST_CLASSES+=		compress xsltproc
  SUBST_MESSAGE.compress=	Patch Makefile.in to avoid autoreconf for compress
  SUBST_STAGE.compress=	post-patch
  SUBST_FILES.compress=	Makefile.in
  SUBST_SED.compress=	-e 's,^mutt_SOURCES = ,mutt_SOURCES = compress.c ,'
  SUBST_SED.compress+=	-e 's,^EXTRA_DIST = ,EXTRA_DIST = compress.h ,'
  SUBST_SED.compress+=	-e 's,^mutt_OBJECTS = ,mutt_OBJECTS = compress.o ,'
 +SUBST_STAGE.xsltproc=	Patch Makefile.{in,am} to force xsltproc execution
 +SUBST_STAGE.xsltproc=	post-patch
 +SUBST_FILES.xsltproc=	doc/Makefile.in doc/Makefile.am
 +SUBST_SED.xsltproc=	-e 's,-xsltproc,xsltproc,'
  .endif

  ###

Responsible-Changed-From-To: pkg-manager->tonio
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Thu, 27 Dec 2012 21:40:13 +0000
Responsible-Changed-Why:
Over to maintainer.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.