NetBSD Problem Report #47110

From www@NetBSD.org  Tue Oct 23 00:04:01 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id AE8E063E290
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 23 Oct 2012 00:04:01 +0000 (UTC)
Message-Id: <20121023000401.29F3163CA81@www.NetBSD.org>
Date: Tue, 23 Oct 2012 00:04:01 +0000 (UTC)
From: fhmcatfm@fastmail.fm
Reply-To: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Subject: wsconsctl(8) parsing bug
X-Send-Pr-Version: www-1.0

>Number:         47110
>Category:       bin
>Synopsis:       wsconsctl(8) parsing bug
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 23 00:05:00 +0000 2012
>Last-Modified:  Mon Apr 01 01:05:01 +0000 2013
>Originator:     with held
>Release:        6.0 release
>Organization:
n/a
>Environment:
NetBSD dirty.lan 6.0 NetBSD 6.0 (GENERIC) i386

>Description:
# wsconsctl  -w map+="keycode 56 = Cmd Alt_L"

wsconsctl: parse: syntax error

Notes:

1) Thus used to work in NetBSD 5.x

2) The symbol KS_Cmd is still defined in the file
   /usr/include/dev/wscons/wsksymdef.h
>How-To-Repeat:
Issue the above command as root in a wsconsole.

>Fix:
None.

>Audit-Trail:
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Mon, 22 Oct 2012 21:53:57 -0400

 On Oct 23, 12:05am, fhmcatfm@fastmail.fm (fhmcatfm@fastmail.fm) wrote:
 -- Subject: bin/47110: wsconsctl(8) parsing bug

 | Notes:
 | 
 | 1) Thus used to work in NetBSD 5.x
 | 
 | 2) The symbol KS_Cmd is still defined in the file
 |    /usr/include/dev/wscons/wsksymdef.h
 | >How-To-Repeat:
 | Issue the above command as root in a wsconsole.


 Use:
 wsconsctl  -w map+="keycode 56 = Alt_L"

 Alt_L is a modifier key not a command key.

 This was a bug in 5, where parsing was not strict.

 christos

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Mon, 22 Oct 2012 23:48:53 -0400

 On Mon, Oct 22, 2012, at 09:55 PM, Christos Zoulas wrote:
 >  Alt_L is a modifier key not a command key.

 Thank you for your reply. I note that Cmd2 is on Alt_L by default.
 -- 

   fhmcatfm@fastmail.fm

 -- 
 http://www.fastmail.fm - One of many happy users:
   http://www.fastmail.fm/help/overview_quotes.html

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	fhmcatfm@fastmail.fm
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 08:37:51 -0400

 On Oct 23,  5:10am, fhmcatfm@fastmail.fm (fhmcatfm@fastmail.fm) wrote:
 -- Subject: Re: bin/47110: wsconsctl(8) parsing bug

 |  >  Alt_L is a modifier key not a command key.
 |  
 |  Thank you for your reply. I note that Cmd2 is on Alt_L by default.

 Then perhaps the parser needs to be relaxed.

 christos

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 11:21:21 -0400

 On Tue, Oct 23, 2012, at 08:40 AM, Christos Zoulas wrote:
 >  Then perhaps the parser needs to be relaxed.

 In my pragmatic view, yes, I'd like to see the prior functionality
 restored so that it's possible, for example, to switch wsconsoles with
 Alt-FN rather than Ctrl-Alt-FN, after the pair of commands:

 # wsconsctl  -w map+="keycode 29 = Control_L"

 # wsconsctl  -w map+="keycode 56 = Cmd Alt_L"

 Reference:

 http://www.daemonforums.org/showthread.php?t=6289

 Thanks for considering this.
 -- 

   fhmcatfm@fastmail.fm

 -- 
 http://www.fastmail.fm - A no graphics, no pop-ups email service

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	fhmcatfm@fastmail.fm
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 11:31:08 -0400

 On Oct 23,  3:25pm, fhmcatfm@fastmail.fm (fhmcatfm@fastmail.fm) wrote:
 -- Subject: Re: bin/47110: wsconsctl(8) parsing bug

 | The following reply was made to PR bin/47110; it has been noted by GNATS.
 | 
 | From: fhmcatfm@fastmail.fm
 | To: gnats-bugs@NetBSD.org
 | Cc: 
 | Subject: Re: bin/47110: wsconsctl(8) parsing bug
 | Date: Tue, 23 Oct 2012 11:21:21 -0400
 | 
 |  On Tue, Oct 23, 2012, at 08:40 AM, Christos Zoulas wrote:
 |  >  Then perhaps the parser needs to be relaxed.
 |  
 |  In my pragmatic view, yes, I'd like to see the prior functionality
 |  restored so that it's possible, for example, to switch wsconsoles with
 |  Alt-FN rather than Ctrl-Alt-FN, after the pair of commands:
 |  
 |  # wsconsctl  -w map+="keycode 29 = Control_L"
 |  
 |  # wsconsctl  -w map+="keycode 56 = Cmd Alt_L"
 |  

 Try it now with the head of the tree.

 christos

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 12:30:46 -0400

 On Tue, Oct 23, 2012, at 11:35 AM, Christos Zoulas wrote:
 >  Try it now with the head of the tree.

 Thanks, I would like to test this, but am bandwidth-challenged and don't
 maintain a source tree, so it will require some time and advice to do.

 Will binaries with this change be appearing under

 http://nyftp.netbsd.org/pub/NetBSD-daily/HEAD/

 in the near future? This would be the easiest for me.

 Also, how much material is required, just a new wsconsctl binary, a
 complete upgrade, or something in between?

 Thanks for any advice you can offer.
 -- 

   fhmcatfm@fastmail.fm

 -- 
 http://www.fastmail.fm - IMAP accessible web-mail

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	fhmcatfm@fastmail.fm
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 12:42:24 -0400

 On Oct 23,  4:35pm, fhmcatfm@fastmail.fm (fhmcatfm@fastmail.fm) wrote:
 -- Subject: Re: bin/47110: wsconsctl(8) parsing bug

 |  Thanks, I would like to test this, but am bandwidth-challenged and don't
 |  maintain a source tree, so it will require some time and advice to do.
 |  
 |  Will binaries with this change be appearing under
 |  
 |  http://nyftp.netbsd.org/pub/NetBSD-daily/HEAD/
 |  
 |  in the near future? This would be the easiest for me.

 Yes, that is going to be the case.

 |  Also, how much material is required, just a new wsconsctl binary, a
 |  complete upgrade, or something in between?

 You just need to download:

 cvs -d anoncvs@anoncvs.netbsd.org:/cvsroot checkout src/sbin/wsconsctl

 cd there and 'make USETOOLS=never'; this should produce a binary.

 christos

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Tue, 23 Oct 2012 14:06:36 -0400

 On Tue, Oct 23, 2012, at 12:45 PM, Christos Zoulas wrote:
 >  You just need to download:
 >  
 >  cvs -d anoncvs@anoncvs.netbsd.org:/cvsroot checkout src/sbin/wsconsctl
 >  
 >  cd there and 'make USETOOLS=never'; this should produce a binary.

 Awesome, I didn't realize it would be so easy to test the change.

 I did the cvs and compile, and tested the new binary. It seems to work
 perfectly so far. I'll continue to use it daily and if any issues arise
 will post a follow-up here.

 Thank you for your patient help, it's much appreciated!
 -- 

   fhmcatfm@fastmail.fm

 -- 
 http://www.fastmail.fm - The professional email service

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: Christos Zoulas <christos@netbsd.org>
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Mon, 25 Feb 2013 08:31:38 +0000

 On Tue, Oct 23, 2012 at 03:35:02PM +0000, Christos Zoulas wrote:
  >  | The following reply was made to PR bin/47110; it has been noted by GNATS.
  >  | 
  >  | From: fhmcatfm@fastmail.fm
  >  | To: gnats-bugs@NetBSD.org
  >  | Cc: 
  >  | Subject: Re: bin/47110: wsconsctl(8) parsing bug
  >  | Date: Tue, 23 Oct 2012 11:21:21 -0400
  >  | 
  >  |  On Tue, Oct 23, 2012, at 08:40 AM, Christos Zoulas wrote:
  >  |  >  Then perhaps the parser needs to be relaxed.
  >  |  
  >  |  In my pragmatic view, yes, I'd like to see the prior functionality
  >  |  restored so that it's possible, for example, to switch wsconsoles with
  >  |  Alt-FN rather than Ctrl-Alt-FN, after the pair of commands:
  >  |  
  >  |  # wsconsctl  -w map+="keycode 29 = Control_L"
  >  |  
  >  |  # wsconsctl  -w map+="keycode 56 = Cmd Alt_L"
  >  |  
  >  
  >  Try it now with the head of the tree.

 Does this need to be pulled up? (Or has it been?)

 -- 
 David A. Holland
 dholland@netbsd.org

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Mon, 25 Feb 2013 12:00:15 -0500

 On Mon, Feb 25, 2013, at 03:35 AM, David Holland wrote:
 > The following reply was made to PR bin/47110; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-bugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: Christos Zoulas <christos@netbsd.org>
 > Subject: Re: bin/47110: wsconsctl(8) parsing bug
 > Date: Mon, 25 Feb 2013 08:31:38 +0000
 > 
 >  On Tue, Oct 23, 2012 at 03:35:02PM +0000, Christos Zoulas wrote:
 >   >  | The following reply was made to PR bin/47110; it has been noted by GNATS.
 >   >  | 
 >   >  | From: fhmcatfm@fastmail.fm
 >   >  | To: gnats-bugs@NetBSD.org
 >   >  | Cc: 
 >   >  | Subject: Re: bin/47110: wsconsctl(8) parsing bug
 >   >  | Date: Tue, 23 Oct 2012 11:21:21 -0400
 >   >  | 
 >   >  |  On Tue, Oct 23, 2012, at 08:40 AM, Christos Zoulas wrote:
 >   >  |  >  Then perhaps the parser needs to be relaxed.
 >   >  |  
 >   >  |  In my pragmatic view, yes, I'd like to see the prior functionality
 >   >  |  restored so that it's possible, for example, to switch wsconsoles with
 >   >  |  Alt-FN rather than Ctrl-Alt-FN, after the pair of commands:
 >   >  |  
 >   >  |  # wsconsctl  -w map+="keycode 29 = Control_L"
 >   >  |  
 >   >  |  # wsconsctl  -w map+="keycode 56 = Cmd Alt_L"
 >   >  |  
 >   >  
 >   >  Try it now with the head of the tree.
 >  
 >  Does this need to be pulled up? (Or has it been?)
 >  
 >  -- 
 >  David A. Holland
 >  dholland@netbsd.org
 >  

 Hi and thanks for following up on this.  When I upgraded to 6.0.1 I
 found that the loosened parsing
 re-introduced by Christos was no longer there, but I didn't have a
 chance to follow up on it. I assume
 this means the changes he made need to be pulled up (but I haven't
 checked any recent code).

 -- 

   fhmcatfm@fastmail.fm

 -- 
 http://www.fastmail.fm - A no graphics, no pop-ups email service

From: fhmcatfm@fastmail.fm
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/47110: wsconsctl(8) parsing bug
Date: Sun, 31 Mar 2013 21:03:22 -0400

 Here is an update:

 I upgraded (laptop) to 6.1 RC2 i386, and that version of wsconsctl still
 gives a syntax
 error for the command

 # wsconsctrl -w map+="keycode 56 = Cmd Alt_L"

 Shortly prior to this I tried HEAD version 201303041020Z and it's
 wsconsctrl had no
 trouble with the above command, i.e., it worked as desired.


 -- 
 http://www.fastmail.fm - A fast, anti-spam email service.

Home	PR Database Search