NetBSD Problem Report #47209

From diro@nixsyspaus.org  Sat Nov 17 18:50:21 2012
Return-Path: <diro@nixsyspaus.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id C473363E472
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 17 Nov 2012 18:50:20 +0000 (UTC)
Message-Id: <20121117185012.GB11882@nixsyspaus.org>
Date: Sat, 17 Nov 2012 13:50:15 -0500
From: diro@nixsyspaus.org
Reply-To:
To: gnats-bugs@NetBSD.org
Subject: Please, pull up comms/minicom

>Number:         47209
>Category:       pkg
>Synopsis:       Please, pull up comms/minicom
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 17 18:55:00 +0000 2012
>Closed-Date:    Wed Dec 12 12:35:39 +0000 2012
>Last-Modified:  Wed Dec 12 12:40:02 +0000 2012
>Originator:     diro@nixsyspaus.org
>Release:        NetBSD 6.0
>Organization:
>Environment:
System: NetBSD nguest 6.0 NetBSD 6.0 (GENERIC) amd64
Architecture: amd64
Machine: amd64
>Description:
Relevant ChangeLog entries since 2.5:

	* src/main.c, src/minicom.c: iconv: Handle the case that iconv
	  did not convert anything. Reported by Mike Crowe, Debian #659351.
	* src/ipc.c: Formatting cleanup.
	* src/main.c: ETIME -> ETIMEDOUT as ETIME is not available on BSDs
	* src/main.c: Fix invalid memory used, reported by Larry Baker
	* src/config.c, src/rwconf.c: Do not set modem init and reset string
	  anymore, define them empty. Instead, when editing those offer
	  them as a default.
	* src/minicom.h, src/main.c, src/dial.c: only update statusline
	  if there's a change (e.g. for updates times)
	* src/updown.c: Flush before forking helper program,
	  patch by Domen Puncer, thanks!
	* src/minicom.c, src/minicom.h, src/vt100.c: Add timestamps with
	  milliseconds, based on patch by Rapha�l Ass�nat, thanks!
	* src/dial.c, src/minicom.c, src/main.c: Cleanups. Print
	  basename of current device to statusline if online time is disabled.
	* configure.in, src/Makefile.am, src/main.c, src/minicom.c,
	  src/minicom.h, src/updown.c: Add lockdev support,
	  by Ludwig Nussel <ludwig.nussel@suse.de>
	* src/dial.c: add a dialdir version 6 which does not save the
	  pointer on disk and should now work on 32 and 64 bit
	  systems equally.
	* configure.in: Use AM_ICONV_LINK...
	* src/script.c: Fix a buffer overflow problem. Thanks Frederic Germain.
	* src/minicom.c: Do not use iconv-functions if iconv is not available.
	* src/config.c, src/main.c, src/vt100.c, src/vt100.h: Add transmit
	  delay for every character, based on patch by Nicolas PILLON.
	* src/config.c: Do not extend tilde to home directory for
	  non-path arguments. Debian bug #621741
	* configure.in, src/Makefile.am: Add workaround and then use
	  libiconv for linking, fixes build issue on Mac OS X.
	* src/main.c: Increase serial port open timeout, by
	  Lubomir Rintel
	* src/main.c: Set sensible errno if port open times out,
	  by Lubomir Rintel
	* src/help.c: Help fix for timestamp toggle by Mark Einon
	* src/minicom.c: Code consolidation.
	* src/minicom.c, src/minicom.h, src/vt100.c, man/minicom.1: Make
	  line timestamps three value: every line, every second, and off.
	* man/minicom.1: Wording fix.
	* src/vt100.c: Cleanups: Delete everything that was in OLD blocks.
	  Do not explicitly set global variables to 0.
	* src/vt100.c, man/minicom.1: Change timestamp style, prepend every
	  line. Add in manpage.
	* src/dial.c src/help.c src/ipc.c src/minicom.c src/minicom.h
	  src/vt100.c src/vt100.h: Addition by Mark Einon
	  <mark.einon@gmail.com> to add current date/time to each line.
	* src/file.c: Only enter directory if we have read permissions to
	  get directory listings, by Jan Görig.
	* src/file.c, src/getsdir.c: Cleanup and simplify.
	* man/runscript.1, man/minicom.1: Fixes by John Bradshaw
	* src/main.c: Avoid redraw of status line in Offline mode when
	  nothing changed.
	* src/minicom.c: Do not lose line wrap setting over terminal resizes.
	* src/main.c: Simplify status line update, also makes status
	  messages display the amount of time they are actually supposed
	  to display.
>How-To-Repeat:
	Be looking for newer versions of packages to update.
>Fix:
diff minicom.orig/Makefile minicom/Makefile
3,4c3
< DISTNAME=	minicom-2.5
< PKGREVISION=	1
---
> DISTNAME=	minicom-2.6.1
6c5
< MASTER_SITES=	http://alioth.debian.org/frs/download.php/3487/
---
> MASTER_SITES=	http://alioth.debian.org/frs/download.php/3700/
16c15
< PKG_DESTDIR_SUPPORT=	user-destdir
---
> PKG_DESTDIR_SUPPORT=	destdir
21c20
< USE_TOOLS+=		gmake msgfmt
---
> USE_TOOLS+=		gmake msgfmt msgmerge xgettext
44a44,45
> .include "options.mk"
> 
diff minicom.orig/PLIST minicom/PLIST
10,27c10,27
< share/locale/cs/LC_MESSAGES/minicom.mo
< share/locale/da/LC_MESSAGES/minicom.mo
< share/locale/de/LC_MESSAGES/minicom.mo
< share/locale/es/LC_MESSAGES/minicom.mo
< share/locale/fi/LC_MESSAGES/minicom.mo
< share/locale/fr/LC_MESSAGES/minicom.mo
< share/locale/hu/LC_MESSAGES/minicom.mo
< share/locale/id/LC_MESSAGES/minicom.mo
< share/locale/ja/LC_MESSAGES/minicom.mo
< share/locale/nb/LC_MESSAGES/minicom.mo
< share/locale/pl/LC_MESSAGES/minicom.mo
< share/locale/pt_BR/LC_MESSAGES/minicom.mo
< share/locale/ro/LC_MESSAGES/minicom.mo
< share/locale/ru/LC_MESSAGES/minicom.mo
< share/locale/rw/LC_MESSAGES/minicom.mo
< share/locale/sv/LC_MESSAGES/minicom.mo
< share/locale/vi/LC_MESSAGES/minicom.mo
< share/locale/zh_TW/LC_MESSAGES/minicom.mo
---
> ${PLIST.nls}share/locale/cs/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/da/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/de/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/es/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/fi/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/fr/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/hu/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/id/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/ja/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/nb/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/pl/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/pt_BR/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/ro/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/ru/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/rw/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/sv/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/vi/LC_MESSAGES/minicom.mo
> ${PLIST.nls}share/locale/zh_TW/LC_MESSAGES/minicom.mo
diff minicom.orig/distinfo minicom/distinfo
3,12c3,11
< SHA1 (minicom-2.5.tar.gz) = 442250314de63189b619f8744c0669445e2cdd1d
< RMD160 (minicom-2.5.tar.gz) = 4131b9ef37d25cf8f77a70fc4b4de32e7896cc23
< Size (minicom-2.5.tar.gz) = 822499 bytes
< SHA1 (patch-aa) = 1ce591eb1f9969a8dd72194d10f69a1df77c35a7
< SHA1 (patch-ab) = db913d60191fd1b0830746019c6cc9c125069cfb
< SHA1 (patch-ac) = 6af60d8edb50f4cd10bc4b63a792cec2075ed6d5
< SHA1 (patch-ad) = e57999876f690689d858aa07f5c122ea79bfd2f1
< SHA1 (patch-ae) = 1d3267fc666d857bbab05a542de6d3aa1ba53e14
< SHA1 (patch-ag) = cf6c551736feb77f7f714cb4ba8b9a787eac937d
< SHA1 (patch-ah) = 499f2372a27ffef2b51aa5d9ac21545d1fe5c277
---
> SHA1 (minicom-2.6.1.tar.gz) = ce6b5f3dab6b4179736152e38a806029f8ad222a
> RMD160 (minicom-2.6.1.tar.gz) = d9c7bf6d661427ff1a4007a917574e4ecd872c50
> Size (minicom-2.6.1.tar.gz) = 830485 bytes
> SHA1 (patch-ab) = e87dbe616958b2b1a01a9a7dfa8cb8f8c1a6978f
> SHA1 (patch-ac) = b2ffa106989ea562b8ea85bfd15e516713a37f3f
> SHA1 (patch-ad) = a3e50ae6dcacb6ae6a177e5b6e4d3d959d960eca
> SHA1 (patch-ae) = ea2fb58212de7caaaed4c0817290ca3612212b6c
> SHA1 (patch-ag) = 5f635b67e2e48d13c9df7f3ed4fdca83a1c7f7ef
> SHA1 (patch-ah) = ae6048f6a8e81134a459aaf21527e944c68ae07f

# EOF
% cat options.mk
# $NetBSD$

PKG_OPTIONS_VAR=	PKG_OPTIONS.minicom
PKG_SUPPORTED_OPTIONS=	nls
PKG_SUGGESTED_OPTIONS+=	nls

PLIST_VARS+=		nls

.include "../../mk/bsd.options.mk"

.if !empty(PKG_OPTIONS:Mnls)
CONFIGURE_ARGS+=	--enable-nls
PLIST.nls=		yes
.else
CONFIGURE_ARGS+=	--disable-nls
.endif

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/47209: Please, pull up comms/minicom
Date: Sun, 18 Nov 2012 16:19:45 +0000

 On Sat, Nov 17, 2012 at 06:55:00PM +0000, diro@nixsyspaus.org wrote:
  > diff minicom.orig/Makefile minicom/Makefile
  > 3,4c3
  > < DISTNAME=	minicom-2.5
  > < PKGREVISION=	1
  > ---
  > > DISTNAME=	minicom-2.6.1

 ...please send unified diffs (diff -u) :-/


 -- 
 David A. Holland
 dholland@netbsd.org

From: diro@nixsyspaus.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47209: Please, pull up comms/minicom
Date: Sun, 18 Nov 2012 18:09:10 -0500

 >  ...please send unified diffs (diff -u) :-/

 diff -u minicom.orig/Makefile minicom/Makefile
 --- minicom.orig/Makefile	2011-12-17 10:14:56.000000000 +0000
 +++ minicom/Makefile	2012-11-17 12:56:59.000000000 +0000
 @@ -1,9 +1,8 @@
  # $NetBSD: Makefile,v 1.60 2011/12/17 10:14:56 sbd Exp $

 -DISTNAME=	minicom-2.5
 -PKGREVISION=	1
 +DISTNAME=	minicom-2.6.1
  CATEGORIES=	comms
 -MASTER_SITES=	http://alioth.debian.org/frs/download.php/3487/
 +MASTER_SITES=	http://alioth.debian.org/frs/download.php/3700/

  MAINTAINER=	pkgsrc-users@NetBSD.org
  HOMEPAGE=	http://alioth.debian.org/projects/minicom/
 @@ -13,12 +12,12 @@
  DEPENDS+=	gkermit-[0-9]*:../../comms/gkermit
  DEPENDS+=	lrzsz-[0-9]*:../../comms/lrzsz

 -PKG_DESTDIR_SUPPORT=	user-destdir
 +PKG_DESTDIR_SUPPORT=	destdir
  PKG_INSTALLATION_TYPES=	overwrite pkgviews
  INSTALLATION_DIRS=	share/examples/minicom

  USE_PKGLOCALEDIR=	yes
 -USE_TOOLS+=		gmake msgfmt
 +USE_TOOLS+=		gmake msgfmt msgmerge xgettext
  GNU_CONFIGURE=		yes
  CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}

 @@ -42,6 +41,8 @@
  SUBST_FILES.minicom=	src/rwconf.c
  SUBST_VARS.minicom=	PREFIX GKERMIT_PREFIX LRZSZ_PREFIX

 +.include "options.mk"
 +
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
  .include "../../mk/termcap.buildlink3.mk"
 diff -u minicom.orig/PLIST minicom/PLIST
 --- minicom.orig/PLIST	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/PLIST	2012-11-17 12:52:52.000000000 +0000
 @@ -7,21 +7,21 @@
  man/man1/minicom.1
  man/man1/runscript.1
  man/man1/xminicom.1
 -share/locale/cs/LC_MESSAGES/minicom.mo
 -share/locale/da/LC_MESSAGES/minicom.mo
 -share/locale/de/LC_MESSAGES/minicom.mo
 -share/locale/es/LC_MESSAGES/minicom.mo
 -share/locale/fi/LC_MESSAGES/minicom.mo
 -share/locale/fr/LC_MESSAGES/minicom.mo
 -share/locale/hu/LC_MESSAGES/minicom.mo
 -share/locale/id/LC_MESSAGES/minicom.mo
 -share/locale/ja/LC_MESSAGES/minicom.mo
 -share/locale/nb/LC_MESSAGES/minicom.mo
 -share/locale/pl/LC_MESSAGES/minicom.mo
 -share/locale/pt_BR/LC_MESSAGES/minicom.mo
 -share/locale/ro/LC_MESSAGES/minicom.mo
 -share/locale/ru/LC_MESSAGES/minicom.mo
 -share/locale/rw/LC_MESSAGES/minicom.mo
 -share/locale/sv/LC_MESSAGES/minicom.mo
 -share/locale/vi/LC_MESSAGES/minicom.mo
 -share/locale/zh_TW/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/cs/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/da/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/de/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/es/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/fi/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/fr/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/hu/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/id/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/ja/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/nb/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/pl/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/pt_BR/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/ro/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/ru/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/rw/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/sv/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/vi/LC_MESSAGES/minicom.mo
 +${PLIST.nls}share/locale/zh_TW/LC_MESSAGES/minicom.mo
 diff -u minicom.orig/distinfo minicom/distinfo
 --- minicom.orig/distinfo	2011-12-05 08:10:18.000000000 +0000
 +++ minicom/distinfo	2012-11-17 13:32:20.000000000 +0000
 @@ -1,12 +1,11 @@
  $NetBSD: distinfo,v 1.12 2011/12/05 08:10:18 adam Exp $

 -SHA1 (minicom-2.5.tar.gz) = 442250314de63189b619f8744c0669445e2cdd1d
 -RMD160 (minicom-2.5.tar.gz) = 4131b9ef37d25cf8f77a70fc4b4de32e7896cc23
 -Size (minicom-2.5.tar.gz) = 822499 bytes
 -SHA1 (patch-aa) = 1ce591eb1f9969a8dd72194d10f69a1df77c35a7
 -SHA1 (patch-ab) = db913d60191fd1b0830746019c6cc9c125069cfb
 -SHA1 (patch-ac) = 6af60d8edb50f4cd10bc4b63a792cec2075ed6d5
 -SHA1 (patch-ad) = e57999876f690689d858aa07f5c122ea79bfd2f1
 -SHA1 (patch-ae) = 1d3267fc666d857bbab05a542de6d3aa1ba53e14
 -SHA1 (patch-ag) = cf6c551736feb77f7f714cb4ba8b9a787eac937d
 -SHA1 (patch-ah) = 499f2372a27ffef2b51aa5d9ac21545d1fe5c277
 +SHA1 (minicom-2.6.1.tar.gz) = ce6b5f3dab6b4179736152e38a806029f8ad222a
 +RMD160 (minicom-2.6.1.tar.gz) = d9c7bf6d661427ff1a4007a917574e4ecd872c50
 +Size (minicom-2.6.1.tar.gz) = 830485 bytes
 +SHA1 (patch-ab) = e87dbe616958b2b1a01a9a7dfa8cb8f8c1a6978f
 +SHA1 (patch-ac) = b2ffa106989ea562b8ea85bfd15e516713a37f3f
 +SHA1 (patch-ad) = a3e50ae6dcacb6ae6a177e5b6e4d3d959d960eca
 +SHA1 (patch-ae) = ea2fb58212de7caaaed4c0817290ca3612212b6c
 +SHA1 (patch-ag) = 5f635b67e2e48d13c9df7f3ed4fdca83a1c7f7ef
 +SHA1 (patch-ah) = ae6048f6a8e81134a459aaf21527e944c68ae07f

From: diro@nixsyspaus.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47209
Date: Sun, 18 Nov 2012 18:34:41 -0500

 Only in minicom.orig/patches/: patch-aa (was committed upstream - remove)
 diff -u minicom.orig/patches/patch-ab minicom/patches/patch-ab
 --- minicom.orig/patches/patch-ab	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/patches/patch-ab	2012-11-17 13:00:24.000000000 +0000
 @@ -1,5 +1,7 @@
  $NetBSD: patch-ab,v 1.5 2011/08/01 09:30:33 adam Exp $

 +Fix installed man pages.
 +
  --- man/Makefile.am.orig	2009-12-12 15:47:47.000000000 +0000
  +++ man/Makefile.am
  @@ -1 +1 @@
 diff -u minicom.orig/patches/patch-ac minicom/patches/patch-ac
 --- minicom.orig/patches/patch-ac	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/patches/patch-ac	2012-11-17 12:44:31.000000000 +0000
 @@ -1,8 +1,8 @@
  $NetBSD: patch-ac,v 1.6 2011/08/01 09:30:33 adam Exp $

 ---- src/updown.c.orig	2010-05-30 20:34:00.000000000 +0000
 +--- src/updown.c.orig	2011-09-07 21:04:32.000000000 +0000
  +++ src/updown.c
 -@@ -294,7 +294,7 @@ void updown(int what, int nr)
 +@@ -296,7 +296,7 @@ void updown(int what, int nr)
       do_log("%s", cmdline);   /* jl 22.06.97 */

     if (P_PFULL(g) == 'N') {
 diff -u minicom.orig/patches/patch-ad minicom/patches/patch-ad
 --- minicom.orig/patches/patch-ad	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/patches/patch-ad	2012-11-17 13:01:07.000000000 +0000
 @@ -1,6 +1,8 @@
  $NetBSD: patch-ad,v 1.8 2011/08/01 09:30:33 adam Exp $

 ---- src/rwconf.c.orig	2011-01-16 10:01:18.000000000 +0000
 +Removed hardcoded LRZSZ_PREFIX and PREFIX.
 +
 +--- src/rwconf.c.orig	2011-12-27 22:21:05.000000000 +0000
  +++ src/rwconf.c
  @@ -76,27 +76,15 @@ struct pars mpars[] = {
     { "",			0,   "pname10" },
 diff -u minicom.orig/patches/patch-ae minicom/patches/patch-ae
 --- minicom.orig/patches/patch-ae	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/patches/patch-ae	2012-11-17 13:01:22.000000000 +0000
 @@ -1,8 +1,14 @@
  $NetBSD: patch-ae,v 1.6 2011/08/01 09:30:33 adam Exp $

 ---- src/windiv.c.orig	2003-04-22 01:56:46.000000000 +0200
 -+++ src/windiv.c	2005-06-29 07:03:12.000000000 +0200
 -@@ -22,2 +22,3 @@
 +Needs sys/types.h.
 +
 +--- src/windiv.c.orig	2009-12-12 15:47:47.000000000 +0000
 ++++ src/windiv.c
 +@@ -20,6 +20,7 @@
 + #include <config.h>
 + #endif

  +#include <sys/types.h>
   #include <dirent.h>
 + #include <sys/stat.h>
 + #include "port.h"
 diff -u minicom.orig/patches/patch-ag minicom/patches/patch-ag
 --- minicom.orig/patches/patch-ag	2011-08-01 09:30:33.000000000 +0000
 +++ minicom/patches/patch-ag	2012-11-17 12:45:06.000000000 +0000
 @@ -1,15 +1,17 @@
  $NetBSD: patch-ag,v 1.4 2011/08/01 09:30:33 adam Exp $

 ---- src/getsdir.c.orig	2009-12-12 15:47:47.000000000 +0000
 +Use NAME_MAX, if defined, instead of MAXNAMLEN.
 +
 +--- src/getsdir.c.orig	2011-02-14 10:07:00.000000000 +0000
  +++ src/getsdir.c
 -@@ -185,7 +185,11 @@ int getsdir(const char *dirpath, const c
 -           int l;
 +@@ -232,7 +232,11 @@ int getsdir(const char *dirpath, const c
 +             }

             /* copy the filename */
  +#ifdef NAME_MAX
 -+          strncpy(datb_cur->data[datb_cur->cnt].fname, dp->d_name, NAME_MAX);
 ++          strncpy((*datptr)[cnt].fname, dp->d_name, NAME_MAX);
  +#else
 -           strncpy(datb_cur->data[datb_cur->cnt].fname, dp->d_name, MAXNAMLEN);
 +           strncpy((*datptr)[cnt].fname, dp->d_name, MAXNAMLEN);
  +#endif

             /* get information about the directory entry */
 diff -u minicom.orig/patches/patch-ah minicom/patches/patch-ah
 --- minicom.orig/patches/patch-ah	2011-12-05 08:10:18.000000000 +0000
 +++ minicom/patches/patch-ah	2012-11-17 13:02:38.000000000 +0000
 @@ -1,8 +1,12 @@
  $NetBSD: patch-ah,v 1.3 2011/12/05 08:10:18 adam Exp $

 +Needs limits.h and NAME_MAX defined, if it's not already.
 +
  --- src/getsdir.h.orig	2009-12-12 15:47:47.000000000 +0000
  +++ src/getsdir.h
 -@@ -25,7 +25,12 @@
 +@@ -23,9 +23,14 @@
 +  */
 + 
   #include <dirent.h>
  +#include <limits.h>

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 12 Dec 2012 12:35:39 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47209 CVS commit: pkgsrc/comms/minicom
Date: Wed, 12 Dec 2012 12:35:22 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Wed Dec 12 12:35:21 UTC 2012

 Modified Files:
 	pkgsrc/comms/minicom: Makefile PLIST distinfo
 	pkgsrc/comms/minicom/patches: patch-ab patch-ac patch-ad patch-ae
 	    patch-ag patch-ah
 Added Files:
 	pkgsrc/comms/minicom: options.mk
 Removed Files:
 	pkgsrc/comms/minicom/patches: patch-aa

 Log Message:
 Update to 2.6.1, from diro in PR 47209.

 Relevant ChangeLog entries since 2.5:

 	* src/main.c, src/minicom.c: iconv: Handle the case that iconv
 	  did not convert anything. Reported by Mike Crowe, Debian #659351.
 	* src/ipc.c: Formatting cleanup.
 	* src/main.c: ETIME -> ETIMEDOUT as ETIME is not available on BSDs
 	* src/main.c: Fix invalid memory used, reported by Larry Baker
 	* src/config.c, src/rwconf.c: Do not set modem init and reset string
 	  anymore, define them empty. Instead, when editing those offer
 	  them as a default.
 	* src/minicom.h, src/main.c, src/dial.c: only update statusline
 	  if there's a change (e.g. for updates times)
 	* src/updown.c: Flush before forking helper program,
 	  patch by Domen Puncer, thanks!
 	* src/minicom.c, src/minicom.h, src/vt100.c: Add timestamps with
 	  milliseconds, based on patch by Rapha�l Ass�nat, thanks!
 	* src/dial.c, src/minicom.c, src/main.c: Cleanups. Print
 	  basename of current device to statusline if online time is disabled.
 	* configure.in, src/Makefile.am, src/main.c, src/minicom.c,
 	  src/minicom.h, src/updown.c: Add lockdev support,
 	  by Ludwig Nussel <ludwig.nussel@suse.de>
 	* src/dial.c: add a dialdir version 6 which does not save the
 	  pointer on disk and should now work on 32 and 64 bit
 	  systems equally.
 	* configure.in: Use AM_ICONV_LINK...
 	* src/script.c: Fix a buffer overflow problem. Thanks Frederic Germain.
 	* src/minicom.c: Do not use iconv-functions if iconv is not available.
 	* src/config.c, src/main.c, src/vt100.c, src/vt100.h: Add transmit
 	  delay for every character, based on patch by Nicolas PILLON.
 	* src/config.c: Do not extend tilde to home directory for
 	  non-path arguments. Debian bug #621741
 	* configure.in, src/Makefile.am: Add workaround and then use
 	  libiconv for linking, fixes build issue on Mac OS X.
 	* src/main.c: Increase serial port open timeout, by
 	  Lubomir Rintel
 	* src/main.c: Set sensible errno if port open times out,
 	  by Lubomir Rintel
 	* src/help.c: Help fix for timestamp toggle by Mark Einon
 	* src/minicom.c: Code consolidation.
 	* src/minicom.c, src/minicom.h, src/vt100.c, man/minicom.1: Make
 	  line timestamps three value: every line, every second, and off.
 	* man/minicom.1: Wording fix.
 	* src/vt100.c: Cleanups: Delete everything that was in OLD blocks.
 	  Do not explicitly set global variables to 0.
 	* src/vt100.c, man/minicom.1: Change timestamp style, prepend every
 	  line. Add in manpage.
 	* src/dial.c src/help.c src/ipc.c src/minicom.c src/minicom.h
 	  src/vt100.c src/vt100.h: Addition by Mark Einon
 	  <mark.einon@gmail.com> to add current date/time to each line.
 	* src/file.c: Only enter directory if we have read permissions to
 	  get directory listings, by Jan Görig.
 	* src/file.c, src/getsdir.c: Cleanup and simplify.
 	* man/runscript.1, man/minicom.1: Fixes by John Bradshaw
 	* src/main.c: Avoid redraw of status line in Offline mode when
 	  nothing changed.
 	* src/minicom.c: Do not lose line wrap setting over terminal resizes.
 	* src/main.c: Simplify status line update, also makes status
 	  messages display the amount of time they are actually supposed
 	  to display.


 To generate a diff of this commit:
 cvs rdiff -u -r1.61 -r1.62 pkgsrc/comms/minicom/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/comms/minicom/PLIST \
     pkgsrc/comms/minicom/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/comms/minicom/options.mk
 cvs rdiff -u -r1.10 -r0 pkgsrc/comms/minicom/patches/patch-aa
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/comms/minicom/patches/patch-ab
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/comms/minicom/patches/patch-ac \
     pkgsrc/comms/minicom/patches/patch-ae
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/comms/minicom/patches/patch-ad
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/comms/minicom/patches/patch-ag
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/comms/minicom/patches/patch-ah

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:
 To: gnats-bugs@gnats.netbsd.org
 Subject: Please, pull up comms/minicom
 From: diro
 Reply-To: diro
 X-send-pr-version: 3.95

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.