NetBSD Problem Report #47215
From www@NetBSD.org Mon Nov 19 09:50:29 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
by www.NetBSD.org (Postfix) with ESMTP id 953E863E8D1
for <gnats-bugs@gnats.NetBSD.org>; Mon, 19 Nov 2012 09:50:29 +0000 (UTC)
Message-Id: <20121119095028.7EB2563E8D1@www.NetBSD.org>
Date: Mon, 19 Nov 2012 09:50:28 +0000 (UTC)
From: richard.palo@baou.fr
Reply-To: richard.palo@baou.fr
To: gnats-bugs@NetBSD.org
Subject: print/poppler-cpp fails with error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
X-Send-Pr-Version: www-1.0
>Number: 47215
>Category: pkg
>Synopsis: print/poppler-cpp fails with error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
>Confidential: no
>Severity: critical
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Nov 19 09:55:00 +0000 2012
>Closed-Date: Wed Dec 12 15:52:38 +0000 2012
>Last-Modified: Wed Dec 12 15:55:02 +0000 2012
>Originator: Richard PALO
>Release: pkgsrc trunk
>Organization:
>Environment:
SunOS devzone 5.11 oi_151a7 i86pc i386 i86pc Solaris
>Description:
building print/poppler-cpp errors with:
gmake[1]: Entering directory `/tmp/pkgsrc/print/poppler-cpp/work/poppler-0.20.5/cpp'
CXX libpoppler_cpp_la-poppler-document.lo
CXX libpoppler_cpp_la-poppler-font.lo
CXX libpoppler_cpp_la-PNMWriter.lo
CXX libpoppler_cpp_la-poppler-embedded-file.lo
CXX libpoppler_cpp_la-poppler-global.lo
CXX libpoppler_cpp_la-poppler-image.lo
poppler-global.cpp: In member function 'poppler::byte_array poppler::ustring::to_utf8() const':
poppler-global.cpp:228:96: error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
In file included from poppler-global.cpp:29:0:
/usr/include/iconv.h:44:15: error: initializing argument 2 of 'ulong_t iconv(iconv_t, char**, ulong_t*, char**, ulong_t*)' [-fpermissive]
poppler-global.cpp:234:93: error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
In file included from poppler-global.cpp:29:0:
/usr/include/iconv.h:44:15: error: initializing argument 2 of 'ulong_t iconv(iconv_t, char**, ulong_t*, char**, ulong_t*)' [-fpermissive]
poppler-global.cpp: In static member function 'static poppler::ustring poppler::ustring::from_utf8(const char*, int)':
poppler-global.cpp:279:98: error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
In file included from poppler-global.cpp:29:0:
/usr/include/iconv.h:44:15: error: initializing argument 2 of 'ulong_t iconv(iconv_t, char**, ulong_t*, char**, ulong_t*)' [-fpermissive]
poppler-global.cpp:285:95: error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
In file included from poppler-global.cpp:29:0:
/usr/include/iconv.h:44:15: error: initializing argument 2 of 'ulong_t iconv(iconv_t, char**, ulong_t*, char**, ulong_t*)' [-fpermissive]
gmake[1]: *** [libpoppler_cpp_la-poppler-global.lo] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory `/tmp/pkgsrc/print/poppler-cpp/work/poppler-0.20.5/cpp'
gmake: *** [all-recursive] Error 1
*** Error code 2
Stop.
bmake: stopped in /home/richard/src/pkgsrc/print/poppler-cpp
*** Error code 1
Stop.
bmake: stopped in /home/richard/src/pkgsrc/print/poppler-cpp
>How-To-Repeat:
bmake clean
bmake
>Fix:
I was able to patch poppler-global.cpp replacing 'ICONV_CONST char **' with just 'char **' with as follows (in print/poppler):
richard@devzone:~/src/pkgsrc/print/poppler$ git diff master .
diff --git a/print/poppler/distinfo b/print/poppler/distinfo
index 3a19cf6..8d9107a 100644
--- a/print/poppler/distinfo
+++ b/print/poppler/distinfo
@@ -9,3 +9,4 @@ SHA1 (patch-ag) = 4b914e85bb08ce83305d20de9c0a3e74d3cabdd2
SHA1 (patch-aq) = 17db7fb50937611ff253f48241503281fb642f63
SHA1 (patch-ar) = 4799e084c83167fcd54832c172c2662c745cdba1
SHA1 (patch-as) = f0f4f8d9f5a49173a27e2349be4b7536ed77eaae
+SHA1 (patch-cpp_poppler-global.cpp) = 19999e99db9424289f44ce224a4c4c6f8c506cfc
diff --git a/print/poppler/patches/patch-cpp_poppler-global.cpp b/print/poppler/patches/patch-cpp_poppler-global.cpp
new file mode 100644
index 0000000..13bb338
--- /dev/null
+++ b/print/poppler/patches/patch-cpp_poppler-global.cpp
@@ -0,0 +1,36 @@
+$NetBSD$
+
+--- cpp/poppler-global.cpp.orig 2012-05-10 20:05:44.000000000 +0000
++++ cpp/poppler-global.cpp
+@@ -225,13 +225,13 @@ byte_array ustring::to_utf8() const
+ char *str_data = &str[0];
+ size_t me_len_char = size();
+ size_t str_len_left = str.size();
+- size_t ir = iconv(ic, (ICONV_CONST char **)&me_data, &me_len_char, &str_data, &str_len_left);
++ size_t ir = iconv(ic, (char **)&me_data, &me_len_char, &str_data, &str_len_left);
+ if ((ir == (size_t)-1) && (errno == E2BIG)) {
+ const size_t delta = str_data - &str[0];
+ str_len_left += str.size();
+ str.resize(str.size() * 2);
+ str_data = &str[delta];
+- ir = iconv(ic, (ICONV_CONST char **)&me_data, &me_len_char, &str_data, &str_len_left);
++ ir = iconv(ic, (char **)&me_data, &me_len_char, &str_data, &str_len_left);
+ if (ir == (size_t)-1) {
+ return byte_array();
+ }
+@@ -276,13 +276,13 @@ ustring ustring::from_utf8(const char *s
+ char *str_data = const_cast<char *>(str);
+ size_t str_len_char = len;
+ size_t ret_len_left = ret.size();
+- size_t ir = iconv(ic, (ICONV_CONST char **)&str_data, &str_len_char, &ret_data, &ret_len_left);
++ size_t ir = iconv(ic, (char **)&str_data, &str_len_char, &ret_data, &ret_len_left);
+ if ((ir == (size_t)-1) && (errno == E2BIG)) {
+ const size_t delta = ret_data - reinterpret_cast<char *>(&ret[0]);
+ ret_len_left += ret.size();
+ ret.resize(ret.size() * 2);
+ ret_data = reinterpret_cast<char *>(&ret[delta]);
+- ir = iconv(ic, (ICONV_CONST char **)&str_data, &str_len_char, &ret_data, &ret_len_left);
++ ir = iconv(ic, (char **)&str_data, &str_len_char, &ret_data, &ret_len_left);
+ if (ir == (size_t)-1) {
+ return ustring();
+ }
>Release-Note:
>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc:
Subject: Re: pkg/47215: print/poppler-cpp fails with error: invalid
conversion from 'const char**' to 'char**' [-fpermissive]
Date: Mon, 19 Nov 2012 15:05:13 +0100
On Mon, Nov 19, 2012 at 09:55:00AM +0000, richard.palo@baou.fr wrote:
> I was able to patch poppler-global.cpp replacing 'ICONV_CONST char **' with just 'char **' with as follows (in print/poppler):
This doesn't look like the right fix, since some platforms (e.g.
NetBSD) will need ICONV_CONST to be const.
Please try to find out why ICONV_CONST is defined to const on your
platform instead (when it shouldn't be, as it seems).
Thomas
From: RichardPALO <richard.palo@baou.fr>
To: <gnats-bugs@netbsd.org>
Cc: <pkg-manager@netbsd.org>, <gnats-admin@netbsd.org>,
<pkgsrc-bugs@netbsd.org>
Subject: Re: pkg/47215: print/poppler-cpp fails with error: invalid
conversion from 'const char**' to 'char**' [-fpermissive]
Date: Mon, 19 Nov 2012 15:40:36 +0100
--=_dd7ecab05072227961e4993fe76beaf2
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
> This doesn't look like the right fix, since some platforms
(e.g.
>NetBSD) will need ICONV_CONST to be const.
> Please try to find
out why ICONV_CONST is defined to const on your
> platform instead (when
it shouldn't be, as it seems).
> Thomas
Hmm, doing a global search in
/opt/pkg/include* I notice the following:
richard@devzone:~$ find
/opt/pkg/include -name '*.h' -exec grep ICONV_CONST {} ; -print
#define
DLG_ICONV_CONST const
/opt/pkg/include/dlg_config.h
#define ICONV_CONST
const
/opt/pkg/include/OpenSP/config.h
perhaps the bug is in OpenSP?
--=_dd7ecab05072227961e4993fe76beaf2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body>
<pre>=20
> This doesn't look like the right fix, since some platforms (e.g.
>NetBSD) will need ICONV_CONST to be const.
=20
> Please try to find out why ICONV_CONST is defined to const on your
> platform instead (when it shouldn't be, as it seems).
> Thomas
<br />Hmm, doing a global search in /opt/pkg/include* I notice the follow=
ing:<br /><br />richard@devzone:~$ find /opt/pkg/include -name '*.h' -exec =
grep ICONV_CONST {} \; -print<br />#define DLG_ICONV_CONST const<br />/opt/=
pkg/include/dlg_config.h<br />#define ICONV_CONST const<br />/opt/pkg/inclu=
de/OpenSP/config.h<br /><br />perhaps the bug is in OpenSP?<br /> </pr=
e>
<div> </div>
</body></html>
--=_dd7ecab05072227961e4993fe76beaf2--
From: RichardPALO <richard.palo@baou.fr>
To: <gnats-bugs@netbsd.org>
Cc: <pkg-manager@netbsd.org>, <gnats-admin@netbsd.org>,
<pkgsrc-bugs@netbsd.org>
Subject: Re: pkg/47215: print/poppler-cpp fails with error: invalid
conversion from 'const char**' to 'char**' [-fpermissive]
Date: Mon, 19 Nov 2012 16:29:40 +0100
--=_b143269fc3de720e3e3814b08838195c
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Seems to be even more complicated after looking through
config.log...
It appears that illumos has the following in
/usr/include/iconv.h
#ifdef _XPG6
extern size_t iconv(iconv_t, char
**_RESTRICT_KYWD,
size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
size_t *_RESTRICT_KYWD);
#else
extern size_t iconv(iconv_t, const char
**_RESTRICT_KYWD,
size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
size_t *_RESTRICT_KYWD);
#endif
whereas /opt/pkg/include/iconv.h has
extern size_t iconv (iconv_t cd, const char* * inbuf, size_t
*inbytesleft, char* * outbuf, size_t *outbytesleft);
So there is a
clash as apparently _XPG6 is not being defined and, even though pkgsrc
iconv is installed, it seems to not occlude the system header.
Is
there a "standard" workaround for this? defining _XPG6 or
_XOPEN_SOURCE=600 ?
hints please, I'll be glad to test them.
--=_b143269fc3de720e3e3814b08838195c
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body>
<p> </p>
<p>Seems to be even more complicated after looking through config.log...</p=
>
<p>It appears that illumos has the following in /usr/include/iconv.h</p>
<p>#ifdef _XPG6<br />extern size_t iconv(iconv_t, char **_RESTR=
ICT_KYWD,<br /> =
size_t *_RESTRICT_KYWD, char **_RESTRICT_KYW=
D,<br /> &=
nbsp; size_t *_RESTRICT_KYWD);<br />#else<br />extern siz=
e_t iconv(iconv_t, const char **_RESTRICT_KYWD,<br /> &nbs=
p; &=
nbsp; size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,<br />  =
; s=
ize_t *_RESTRICT_KYWD);<br />#endif</p>
<p>whereas /opt/pkg/include/iconv.h has</p>
<p>extern size_t iconv (iconv_t cd, const char* * inbuf, size_t *inbyteslef=
t, char* * outbuf, size_t *outbytesleft);</p>
<p> </p>
<p>So there is a clash as apparently _XPG6 is not being defined and, even t=
hough pkgsrc iconv is installed, it seems to not occlude the system header=
=2E</p>
<p>Is there a "standard" workaround for this? defining _XPG6 or _XOPE=
N_SOURCE=3D600 ?</p>
<p>hints please, I'll be glad to test them.<br /><br /><br /></p>
<div> </div>
</body></html>
--=_b143269fc3de720e3e3814b08838195c--
From: RichardPALO <richard.palo@baou.fr>
To: <gnats-bugs@netbsd.org>
Cc: <pkg-manager@netbsd.org>, <gnats-admin@netbsd.org>,
<pkgsrc-bugs@netbsd.org>
Subject: Re: pkg/47215: print/poppler-cpp fails with error: invalid
conversion from 'const char**' to 'char**' [-fpermissive]
Date: Mon, 19 Nov 2012 16:08:29 +0100
--=_1eea3211e3e4f2fa35d9c51eba4f3a92
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Ah, in the work directory, I also found the following... will look
deeper ...
richard@devzone:/tmp/pkgsrc/print/poppler-cpp/work$ find .
-name '*.h' -exec grep ICONV_CONST {} ; -print
#define ICONV_CONST
const
./poppler-0.20.5/config.h
/* #undef _GLIBCXX_ICONV_CONST
*/
./.buildlink/gcc47/include/c++/x86_64-sun-solaris2.11/32/bits/c++config.h
/*
#undef _GLIBCXX_ICONV_CONST
*/
./.buildlink/gcc47/include/c++/x86_64-sun-solaris2.11/bits/c++config.h
/*
#undef ICONV_CONST
*/
./.buildlink/gcc47/lib/gcc/x86_64-sun-solaris2.11/4.7.2/plugin/include/auto-host.h
--=_1eea3211e3e4f2fa35d9c51eba4f3a92
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body>
<p>Ah, in the work directory, I also found the following... will look deepe=
r ...</p>
<p>richard@devzone:/tmp/pkgsrc/print/poppler-cpp/work$ find . -name '*.h' -=
exec grep ICONV_CONST {} \; -print<br />#define ICONV_CONST const<br />./po=
ppler-0.20.5/config.h<br />/* #undef _GLIBCXX_ICONV_CONST */<br />./.buildl=
ink/gcc47/include/c++/x86_64-sun-solaris2.11/32/bits/c++config.h<br />/* #u=
ndef _GLIBCXX_ICONV_CONST */<br />./.buildlink/gcc47/include/c++/x86_64-sun=
-solaris2.11/bits/c++config.h<br />/* #undef ICONV_CONST */<br />./.buildli=
nk/gcc47/lib/gcc/x86_64-sun-solaris2.11/4.7.2/plugin/include/auto-host.h<br=
/><br /><br /></p>
<div> </div>
</body></html>
--=_1eea3211e3e4f2fa35d9c51eba4f3a92--
From: Richard PALO <richard.palo@baou.fr>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/47215: print/poppler-cpp fails with error: invalid conversion
from 'const char**' to 'char**' [-fpermissive]
Date: Wed, 21 Nov 2012 08:11:57 +0100
After some digging around, I noticed a mechanism in the Makefile found
in pkgsrc/net/php-xmlrpc/ that I adapted to poppler-cpp and it seems to
work in my case.
For what it is worth:
diff --git a/print/poppler-cpp/Makefile b/print/poppler-cpp/Makefile
index c47e6bf..23704ad 100644
--- a/print/poppler-cpp/Makefile
+++ b/print/poppler-cpp/Makefile
@@ -34,6 +34,19 @@ CONFIGURE_ARGS+= --enable-cms
CONFIGURE_ARGS+= --disable-cms
.endif
+.include "../../converters/libiconv/buildlink3.mk"
+
+CHECK_BUILTIN.iconv:= yes
+.include "../../converters/libiconv/builtin.mk"
+CHECK_BUILTIN.iconv:= no
+
+.if !empty(USE_BUILTIN.iconv:M[nN][oO])
+CONFIGURE_ARGS+= --with-libiconv-prefix=${BUILDLINK_PREFIX.iconv}
+.else
+CONFIGURE_ARGS+= --with-libiconv-prefix
+.endif
+
+
BUILD_DIRS= cpp
INSTALL_DIRS= cpp
State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 12 Dec 2012 15:52:38 +0000
State-Changed-Why:
Committed the patch, thank you!
From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/47215 CVS commit: pkgsrc/print/poppler-cpp
Date: Wed, 12 Dec 2012 15:51:58 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Wed Dec 12 15:51:58 UTC 2012
Modified Files:
pkgsrc/print/poppler-cpp: Makefile
Log Message:
Fix poppler-cpp on Solaris (iconv issue) using a patch from Richard PALO
in PR 47215.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 pkgsrc/print/poppler-cpp/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.