NetBSD Problem Report #47266

From www@NetBSD.org  Fri Nov 30 17:50:16 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 9395263DFC7
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 30 Nov 2012 17:50:16 +0000 (UTC)
Message-Id: <20121130175014.7046263DFC7@www.NetBSD.org>
Date: Fri, 30 Nov 2012 17:50:14 +0000 (UTC)
From: richard.palo@baou.fr
Reply-To: richard.palo@baou.fr
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/net/libvncserver problem with lacking byteswap.h on solaris
X-Send-Pr-Version: www-1.0

>Number:         47266
>Category:       pkg
>Synopsis:       pkgsrc/net/libvncserver problem with lacking byteswap.h on solaris
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 30 17:55:00 +0000 2012
>Closed-Date:    Tue Dec 17 16:44:21 +0000 2013
>Last-Modified:  Tue Dec 17 16:44:21 +0000 2013
>Originator:     Richard PALO
>Release:        pkgsrc trunk
>Organization:
>Environment:
SunOS devzone 5.11 oi_151a7 i86pc i386 i86pc Solaris

>Description:
building libvncserver gives the following error:


--- websockets.lo ---
websockets.c:61:22: fatal error: byteswap.h: No such file or directory
compilation terminated.
*** [websockets.lo] Error code 1




byteswap.h is indeed not provided on solaris2.11
>How-To-Repeat:

>Fix:
proposed patch update:

richard@devzone:~/src/pkgsrc/net/libvncserver$ cvs diff
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/net/libvncserver/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo    6 May 2012 09:08:36 -0000       1.8
+++ distinfo    30 Nov 2012 17:38:01 -0000
@@ -3,4 +3,4 @@ $NetBSD: distinfo,v 1.8 2012/05/06 09:08
 SHA1 (LibVNCServer-0.9.9.tar.gz) = 2004c6ae493baeff3da40b61e0a0f73c83182dad
 RMD160 (LibVNCServer-0.9.9.tar.gz) = e62e0903124abb85746bcac6498214fe09c3b4d7
 Size (LibVNCServer-0.9.9.tar.gz) = 1678609 bytes
-SHA1 (patch-libvncserver_websockets.c) = 059c8a3d0971caa3a43eb48a69b8ca81e6df0a78
+SHA1 (patch-libvncserver_websockets.c) = 173cfe07f283bac6838a2a0ee1857357e6b27d3b
Index: patches/patch-libvncserver_websockets.c
===================================================================
RCS file: /cvsroot/pkgsrc/net/libvncserver/patches/patch-libvncserver_websockets.c,v
retrieving revision 1.1
diff -u -p -r1.1 patch-libvncserver_websockets.c
--- patches/patch-libvncserver_websockets.c     6 May 2012 09:08:36 -0000       1.1
+++ patches/patch-libvncserver_websockets.c     30 Nov 2012 17:38:01 -0000
@@ -4,7 +4,7 @@ $NetBSD: patch-libvncserver_websockets.c

 --- libvncserver/websockets.c.orig     2012-05-04 14:19:00.000000000 +0000
 +++ libvncserver/websockets.c
-@@ -31,12 +31,34 @@
+@@ -31,12 +31,41 @@
  /* errno */
  #include <errno.h>

@@ -35,12 +35,19 @@ $NetBSD: patch-libvncserver_websockets.c
 +#define WS_NTOH16(n) OSSwapBigToHostInt16(n)
 +#define WS_HTON64(n) OSSwapHostToBigInt64(n)
 +#define WS_HTON16(n) OSSwapHostToBitInt16(n)
++#elif defined(__sun)
++#include <sys/byteorder.h>
++#define WS_NTOH64(n) ntohll(n)
++#define WS_NTOH32(n) ntohl(n)
++#define WS_NTOH16(n) ntohs(n)
++#define WS_HTON64(n) htonll(n)
++#define WS_HTON16(n) htons(n)       
 +#else
 +#include <byteswap.h>
  #if defined(__BYTE_ORDER) && defined(__BIG_ENDIAN) && __BYTE_ORDER == __BIG_ENDIAN
  #define WS_NTOH64(n) (n)
  #define WS_NTOH32(n) (n)
-@@ -50,6 +72,7 @@
+@@ -50,6 +79,7 @@
  #define WS_HTON64(n) bswap_64(n)
  #define WS_HTON16(n) bswap_16(n)
  #endif

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Sat, 01 Dec 2012 08:29:15 +0000
Responsible-Changed-Why:
Solaris pkgsrc problem.


State-Changed-From-To: open->closed
State-Changed-By: prlw1@NetBSD.org
State-Changed-When: Tue, 17 Dec 2013 16:44:21 +0000
State-Changed-Why:
Patch was commited in
RCS file: /cvsroot/pkgsrc/net/libvncserver/patches/patch-libvncserver_websockets.c,v
revision 1.2
date: 2013/02/27 18:24:51;  author: jperkin;  state: Exp;  lines: +10 -3
Add SunOS byteswap support.


>Unformatted:

Home	PR Database Search