NetBSD Problem Report #47282

From www@NetBSD.org  Tue Dec  4 08:19:38 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0F78763DFC7
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  4 Dec 2012 08:19:38 +0000 (UTC)
Message-Id: <20121204081937.60EDB63DFC7@www.NetBSD.org>
Date: Tue,  4 Dec 2012 08:19:37 +0000 (UTC)
From: draco@marino.st
Reply-To: draco@marino.st
To: gnats-bugs@NetBSD.org
Subject: security/otptool: portability issue with sed (sed -r)
X-Send-Pr-Version: www-1.0

>Number:         47282
>Category:       pkg
>Synopsis:       security/otptool: portability issue with sed (sed -r)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 04 08:20:01 +0000 2012
>Closed-Date:    Wed Apr 17 14:44:16 +0000 2013
>Last-Modified:  Wed Apr 17 14:44:16 +0000 2013
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
otptool uses the gnu option "-r" which is analogous to "-E" on BSD.  If sed doesn't support -r (as seen with DragonFly), then otptool is fails to build:

--- module ---
if test "." != "."; then /bin/cp ./mod_authn_otp.c .; fi
/usr/pkg/sbin/apxs -c -D_REENTRANT `echo -Wall -Waggregate-return -Wcast-align -Wchar-subscripts -Wcomment -Wformat         -Wimplicit -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-long-long         -Wparentheses -Wpointer-arith -Wredundant-decls -Wreturn-type -Wswitch -Wtrigraphs         -Wuninitialized -Wunused -Wwrite-strings -Wshadow -Wstrict-prototypes -Wcast-qual | sed -r 's/ -/ -Wc,-/g'` -l crypto mod_authn_otp.c
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

full build log:
http://leaf.dragonflybsd.org/~marino/masterbulk/20121121.1619/otptool-1.1.4/build.log
>How-To-Repeat:
Attempt to build it on any release of DragonFly
>Fix:
Likely the fix is to replace "-r" with "-E" but I don't know offhand how Linux or SunOS will react.

>Release-Note:

>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/47282: security/otptool: portability issue with sed (sed -r)
Date: Sun, 30 Dec 2012 16:29:34 +0900

 On Tue, 04 Dec 2012 17:20:02 +0900, <draco@marino.st> wrote:

 >> Description:
 > otptool uses the gnu option "-r" which is analogous to "-E" on BSD.  If sed doesn't support -r (as seen with DragonFly), then otptool is fails to build:
 >
 > --- module ---
 > if test "." != "."; then /bin/cp ./mod_authn_otp.c .; fi
 > /usr/pkg/sbin/apxs -c -D_REENTRANT `echo -Wall -Waggregate-return -Wcast-align -Wchar-subscripts -Wcomment -Wformat         -Wimplicit -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wno-long-long         -Wparentheses -Wpointer-arith -Wredundant-decls -Wreturn-type -Wswitch -Wtrigraphs         -Wuninitialized -Wunused -Wwrite-strings -Wshadow -Wstrict-prototypes -Wcast-qual | sed -r 's/ -/ -Wc,-/g'` -l crypto mod_authn_otp.c
 > sed: illegal option -- r
 > usage: sed script [-Ealn] [-i extension] [file ...]
 >        sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

 Using 's/ -/ -Wc,-/g', which is not a extended regular expressions,
 so it is safe to drop `-r' option.
 (already fixed by upstream, v1.1.5: https://code.google.com/p/mod-authn-otp/source/detail?spec=svn129&r=116 )

 -- 
 OBATA Akio / obache@NetBSD.org

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47282: security/otptool: portability issue with sed (sed
 -r)
Date: Wed, 17 Apr 2013 15:45:51 +0200

 This PR can be closed.
 Upgrading to version 1.1.16 solved this issue:
 http://mail-index.netbsd.org/pkgsrc-changes/2013/04/17/msg087998.html

 Thanks,
 John

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 17 Apr 2013 14:44:16 +0000
State-Changed-Why:
Confirmed fixed, thanks for the updated.


>Unformatted:

Home	PR Database Search