NetBSD Problem Report #47370

From www@NetBSD.org  Thu Dec 27 12:46:33 2012
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 4D5F763D82E
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 27 Dec 2012 12:46:33 +0000 (UTC)
Message-Id: <20121227124631.A174F63D82E@www.NetBSD.org>
Date: Thu, 27 Dec 2012 12:46:31 +0000 (UTC)
From: richard.palo@baou.fr
Reply-To: richard.palo@baou.fr
To: gnats-bugs@NetBSD.org
Subject: update pkgsrc/mail/opendkim to 2.7.3 to get over build problem in opendkim-spam
X-Send-Pr-Version: www-1.0

>Number:         47370
>Category:       pkg
>Synopsis:       update pkgsrc/mail/opendkim to 2.7.3 to get over build problem in opendkim-spam
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pettai
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 27 12:50:01 +0000 2012
>Closed-Date:    Sat Jan 12 07:42:51 +0000 2013
>Last-Modified:  Sat Jan 12 07:42:51 +0000 2013
>Originator:     Richard PALO
>Release:        pkgsrc trunk
>Organization:
>Environment:
SunOS devzoneX 5.11 oi_151a7 i86pc i386 i86pc Solaris

>Description:
There is a build problem in opendkim/opendkim-spam.c involving the "config.h" include file (adding #include "opendkim.h" before the failing include seems to get over the problem). 

I decided first to update to the latest 2.7.3 and now it isn't compiled due to the lack of pkgsrc OpenDBX (http://www.linuxnetworks.de/doc/index.php/OpenDBX)

apparently FreeBSD has OpenDBX already in ports, so it shouldn't be too difficult to add it, if nobody has done it already, I should hope to get to it sometime in january.
>How-To-Repeat:

>Fix:
the following is the cvs diff for the upgrade (not including the patch for opendkim-spam.c):

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/opendkim/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- Makefile	12 Nov 2012 19:23:35 -0000	1.9
+++ Makefile	27 Dec 2012 12:45:37 -0000
@@ -1,6 +1,6 @@
 # $NetBSD: Makefile,v 1.9 2012/11/12 19:23:35 pettai Exp $

-DISTNAME=	opendkim-2.6.7
+DISTNAME=	opendkim-2.7.3
 CATEGORIES=	mail
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE:=opendkim/}

Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/mail/opendkim/PLIST,v
retrieving revision 1.7
diff -u -p -r1.7 PLIST
--- PLIST	12 Nov 2012 19:23:35 -0000	1.7
+++ PLIST	27 Dec 2012 12:45:37 -0000
@@ -1,17 +1,19 @@
 @comment $NetBSD: PLIST,v 1.7 2012/11/12 19:23:35 pettai Exp $
-bin/opendkim-genkey
-bin/opendkim-genzone
-bin/opendkim-testadsp
-bin/opendkim-testkey
-bin/opendkim-testmsg
+sbin/opendkim-genkey
+sbin/opendkim-genzone
+sbin/opendkim-testadsp
+sbin/opendkim-testkey
+sbin/opendkim-testmsg
 include/opendkim/dkim.h
 lib/libopendkim.la
 lib/pkgconfig/opendkim.pc
+man/man5/opendkim.conf.5
 man/man8/opendkim-genkey.8
 man/man8/opendkim-genzone.8
 man/man8/opendkim-testadsp.8
 man/man8/opendkim-testkey.8
 man/man8/opendkim-testmsg.8
+man/man8/opendkim.8
 share/doc/opendkim/FEATURES
 share/doc/opendkim/KNOWNBUGS
 share/doc/opendkim/LICENSE
@@ -26,6 +28,7 @@ share/doc/opendkim/authheaders-check-set
 share/doc/opendkim/chroot
 share/doc/opendkim/convert_keylist.sh
 share/doc/opendkim/dkim.html
+share/doc/opendkim/dkim_add_querymethod.html
 share/doc/opendkim/dkim_add_xtag.html
 share/doc/opendkim/dkim_alg_t.html
 share/doc/opendkim/dkim_body.html
@@ -34,10 +37,20 @@ share/doc/opendkim/dkim_cbstat.html
 share/doc/opendkim/dkim_chunk.html
 share/doc/opendkim/dkim_close.html
 share/doc/opendkim/dkim_diffheaders.html
+share/doc/opendkim/dkim_dns_close.html
+share/doc/opendkim/dkim_dns_config.html
+share/doc/opendkim/dkim_dns_init.html
+share/doc/opendkim/dkim_dns_nslist.html
+share/doc/opendkim/dkim_dns_set_close.html
+share/doc/opendkim/dkim_dns_set_config.html
+share/doc/opendkim/dkim_dns_set_init.html
+share/doc/opendkim/dkim_dns_set_nslist.html
 share/doc/opendkim/dkim_dns_set_query_cancel.html
 share/doc/opendkim/dkim_dns_set_query_service.html
 share/doc/opendkim/dkim_dns_set_query_start.html
 share/doc/opendkim/dkim_dns_set_query_waitreply.html
+share/doc/opendkim/dkim_dns_set_trustanchor.html
+share/doc/opendkim/dkim_dns_trustanchor.html
 share/doc/opendkim/dkim_dnssec.html
 share/doc/opendkim/dkim_eoh.html
 share/doc/opendkim/dkim_eom.html
@@ -146,3 +159,4 @@ share/doc/opendkim/opendkim.spec.in
 share/doc/opendkim/opendkim.xml
 share/doc/opendkim/overview.html
 share/doc/opendkim/stats.lua
+share/examples/rc.d/opendkim
Index: PLIST.stats
===================================================================
RCS file: /cvsroot/pkgsrc/mail/opendkim/PLIST.stats,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST.stats
--- PLIST.stats	16 Jun 2012 20:20:15 -0000	1.5
+++ PLIST.stats	27 Dec 2012 12:45:37 -0000
@@ -1,5 +1,13 @@
 @comment $NetBSD: PLIST.stats,v 1.5 2012/06/16 20:20:15 pettai Exp $
 bin/opendkim-spam
-bin/opendkim-stats
+sbin/opendkim-stats
+sbin/opendkim-expire
+sbin/opendkim-gengraphs
+sbin/opendkim-genstats
+sbin/opendkim-reportstats
+share/doc/opendkim/mkdb.mysql
 man/man1/opendkim-spam.1
 man/man8/opendkim-stats.8
+man/man8/opendkim-expire.8
+man/man8/opendkim-gengraphs.8
+man/man8/opendkim-genstats.8
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/mail/opendkim/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo	19 Nov 2012 18:39:34 -0000	1.8
+++ distinfo	27 Dec 2012 12:45:37 -0000
@@ -1,6 +1,6 @@
-$NetBSD: distinfo,v 1.8 2012/11/19 18:39:34 pettai Exp $
+$NetBSD$

-SHA1 (opendkim-2.6.7.tar.gz) = db689bbb9c2df7c0140a470504f050e6ffe2c24b
-RMD160 (opendkim-2.6.7.tar.gz) = 54fc6693d610f5e746360904415c003396ab5012
-Size (opendkim-2.6.7.tar.gz) = 1129124 bytes
+SHA1 (opendkim-2.7.3.tar.gz) = abaab329ccea5f27166d99030a6e3cac3db63d76
+RMD160 (opendkim-2.7.3.tar.gz) = 83270cc71246b21806e6c3ca83f3e2dcdae6c845
+Size (opendkim-2.7.3.tar.gz) = 1157432 bytes
 SHA1 (patch-configure) = 8e635d41c213f899b31b392b1cdb96c8d5113ca4

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/47370: update pkgsrc/mail/opendkim to 2.7.3 to get over
 build problem in opendkim-spam
Date: Fri, 28 Dec 2012 19:30:13 +0000

 (not sent to gnats)

    ------

 From: Richard PALO <richard.palo@baou.fr>
 To: pkgsrc-bugs@NetBSD.org
 Subject: Re: pkg/47370: update pkgsrc/mail/opendkim to 2.7.3 to get over build
 	problem in opendkim-spam
 Date: Thu, 27 Dec 2012 14:19:46 +0100

 I noticed some warning still during configure probably due to
 reorganisation/cleanup upstream so here is options.mk and a
 PKGCONFIG_OVERRIDE suppression in Makefile.

 richard@devzoneX:~/src/pkgsrc/mail/opendkim$ cvs diff options.mk
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/opendkim/options.mk,v
 retrieving revision 1.3
 diff -u -p -r1.3 options.mk
 --- options.mk  29 Apr 2011 11:48:24 -0000      1.3
 +++ options.mk  27 Dec 2012 13:10:29 -0000
 @@ -24,10 +24,6 @@ RCD_SCRIPTS= opendkim

  CONFIGURE_ARGS+=       --enable-filter
  CONFIGURE_ARGS+=       --with-milter=${PREFIX}
 -SUBST_CLASSES+=                conf
 -SUBST_STAGE.conf=      pre-configure
 -SUBST_FILES.conf=      opendkim/Makefile.in
 -SUBST_SED.conf+=       -e 's|@EGDIR@|${EGDIR}|g'

  #CONF_FILES=           ${EGDIR}/opendkim.conf.sample \
  #                      ${PKG_SYSCONFDIR}/opendkim.conf
 richard@devzoneX:~/src/pkgsrc/mail/opendkim$ cvs diff Makefile
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/opendkim/Makefile,v
 retrieving revision 1.9
 diff -u -p -r1.9 Makefile
 --- Makefile    12 Nov 2012 19:23:35 -0000      1.9
 +++ Makefile    27 Dec 2012 13:12:43 -0000
 @@ -1,6 +1,6 @@
  # $NetBSD: Makefile,v 1.9 2012/11/12 19:23:35 pettai Exp $

 -DISTNAME=      opendkim-2.6.7
 +DISTNAME=      opendkim-2.7.3
  CATEGORIES=    mail
  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=opendkim/}

 @@ -26,7 +26,6 @@ PKG_USERS_VARS+=      DKIM_USER
  OWN_DIRS_PERMS+=       ${VARBASE}/run/opendkim \
                         ${DKIM_USER} ${DKIM_GROUP} 0750

 -PKGCONFIG_OVERRIDE+=   libar/ar.pc.in
  PKGCONFIG_OVERRIDE+=   libopendkim/opendkim.pc.in
  PKGCONFIG_OVERRIDE+=   libvbr/vbr.pc.in

Responsible-Changed-From-To: pkg-manager->pettai
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sun, 30 Dec 2012 06:39:11 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "Fredrik Pettai" <pettai@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47370 CVS commit: pkgsrc/mail/opendkim
Date: Sat, 5 Jan 2013 17:05:07 +0000

 Module Name:	pkgsrc
 Committed By:	pettai
 Date:		Sat Jan  5 17:05:07 UTC 2013

 Modified Files:
 	pkgsrc/mail/opendkim: Makefile PLIST PLIST.filter PLIST.stats distinfo
 	    options.mk

 Log Message:
 2.7.3           2012/11/29
         Log DB error string in dkimf_add_signrequest(), and fix a DSN handling
                 error in dkimf_db_strerror().
         LIBOPENDKIM: Ignore entries in the oversign header field name list
                 that are empty, and an oversign header field name list that
                 is present but empty.
         LIBOPENDKIM: Allow header field lists to be empty, flushing any that
                 were previously defined.
         BUILD: Improve tests for including <strl.h>.
         REPUTATION: Use lowercase for keywords in REPUTE query generation
                 and handling.
         STATS: Clean up a dead link in opendkim-genstats.

 2.7.2           2012/11/14
         Log the author domain name when rejecting or discarding due to ADSP.
         LIBOPENDKIM: Improve re-entrancy of dkim_eoh() when verifying.
         LIBOPENDKIM: Only do a single read attempt of a private key under
                 GNUTLS to avoid hiding a useful error code.
         STATS: Add long option support for opendkim-importstats.
         STATS: Fix overly-strict domain name rules in opendkim-reportstats.
         TOOLS: Fix opendkim-genkey subdomains default.
         TOOLS: Fix opendkim-testmsg GNUTLS initialization.
         TOOLS: Add ability to assert a reporter ID to opendkim-spam.
         TOOLS: Add ability to skip a fixed number of Received: fields.
         TOOLS: Print a warning when asked to generate a key smaller than
                 the recommended minimum.
         BUILD: Fix bug #SF3585163: Use a provided libstrl if detected.
         BUILD: Portability fixes for Solaris 10 from Claus Assmann and
                 Leena Heino.

 2.7.1           2012/10/30
         Fix bug #SF3581657: Fix faulty logic in LDAP open code.
         Fix bug #SF3581743: Properly handle NULLs returned from OpenDBX
                 queries and low field counts in dkimf_db_walk().
         In the _FFR_REPUTATION code, free JSON objects when done with them.
         TOOLS: Fix argument parsing in new version of opendkim-genkey.

 2.7.0           2012/10/24
         Feature request #SF2964375: Reject configuration files that have
                 a SigningTable referencing a missing or malformed KeyTable
                 entry.
         Feature request #SF3544764: Support for libar has been discontinued.
                 For asynchronous and/or thread-safe resolver service,
                 use libunbound or a suitable version of BIND.
         Feature request #SF3545658: Replace "ResolvConf" with "Nameservers"
                 and add support for NS list overrides for versions of bind
                 that have res_setservers().  Also rename "UnboundConfigFile"
                 to "ResolverConfiguration", and make "TrustAnchorFile"
                 generally available.
         Feature request #SF3547124: Skip reputation checks on passing
                 signatures whose keys had a "t=y" value.
         Feature request #SF3555842: Add "ReputationTest" setting.
         Feature request #SF3556439: Update opendkim-atpszone per RFC6541.
         Feature request #SF3559744: Add library option DKIM_OPTS_MINKEYBITS
                 allowing one to specify a minimum number of key bits for
                 acceptable keys and signatures.  This is exposed through new
                 configuration file option "MinimumKeyBits".  The default
                 is 1024.
         Fix bug #SF3536414: Activate _FFR_OVERSIGN, and remove
                 DKIM_OPTS_ALWAYSHDRS.
         Fix bug #SF3536655: Rename "X-Header" to "SoftwareHeader", and rename
                 all header fields added that start "X-" to remove that prefix,
                 per RFC6648.  The old name will be accepted through the end
                 of the 2.7.x line.
         Fix bug #SF3538896: Remove antiquated CVS Id: tags, which cleans up
                 some (harmless) build warnings.
         Fix bug #SF3548741: Add "ReputationTimeout" for use inside
                 _FFR_REPUTATION, rather than using the built-in default
                 or a hard-coded one.
         Fix bug #SF3549307: Remove _FFR_REPUTATION_CACHE, as it is redundant
                 to caching code that's part of _FFR_REPUTATION already.
         Fix bug #SF3555844: Get repute client code in sync with repute.php
                 (and the current REPUTE WG drafts).
         Fix bounds checking in the dstring printf functions.
         Fix loop structure in the C side of odkim.get_rcpt().
         Change all temporary directory defaults from /var/tmp to /tmp.
         Activate _FFR_LUA_GLOBALS.
         Request the milter permissions required to get _FFR_REDIRECT working.
         Add _FFR_REPRRD, which is a second approach to DKIM-based reputation
                 using round robin databases and Holt-Winters foreacasting
                 using rrdtool (see http://oss.oetiker.ch/rrdtool/).  Still
                 experimental.
         Patch #SF3555843: With sufficient verbosity, report the default
                 configuration file path.  Patch from Andreas Schulze.
         BUILD: Fix bug #SF3531658: Move the strlcat() and strlcpy()
                 implementations to their own library so that programs don't
                 drag in crypto and other dependencies they don't need.
                 Also clean up several other unnecessary dependencies imposed
                 by imprecise use of autoconf.
         BUILD: Patch #SF3555845: Add support for older versions of libcurl.
         BUILD: Install non-user things in sbin instead of bin.
         LIBOPENDKIM: Feature request #SF3565006: Add dkim_add_querymethod()
                 and dkim_sig_seterror(), define DKIM_CBSTAT_DEFAULT, and
                 remove an assertion in dkim_get_key_dns(), which together
                 allow for applications to develop non-standard key retrieval
                 mechanisms.
         LIBOPENDKIM: Fix bug #SF3559080: Log correct domains and selectors
                 with SSL errors.
         LIBOPENDKIM: Add DNS functions dkim_dns_config(), dkim_dns_init(),
                 dkim_dns_nslist(), dkim_dns_set_init(), dkim_dns_set_close(),
                 dkim_dns_set_nslist(), dkim_dns_set_config(),
                 dkim_dns_set_trustanchor(), dkim_dns_trustanchor().
         LIBOPENDKIM: Patch #SF3562496: Add DKIM_OPTS_REQUIREDHDRS to allow
                 alteration of the mandatory header field set.
         LIBOPENDKIM: If "q=" is present and method "dns" is specified, it
                 must be followed by "/txt", per RFC6376.
         LIBOPENDKIM: For dkim_add_xtag(), copy the provided values so the
                 caller doesn't have to keep them around.
         LIBOPENDKIM: Allow dual signing of a single body with dkim_resign().
         STATS: Fix bug #SF3555847: Add "--nocircles" to opendkim-gengraphs
                 to allow operation with versions of gnuplot that don't know
                 what "with circles" means.
         STATS: Patch #SF3555841: Temporary table SQL correction.
         TOOLS: Feature request #SF3553918: Add "-u" flag to opendkim-atpszone
                 and opendkim-genzone enabling them to produce output suitable
                 for use as input to nsupdate(8).
         TOOLS: Feature request #SF3558818: Teach opendkim-testkey about the new
                 "ResolverConfiguration" setting.
         TOOLS: Fix bug #SF3565013: Replace opendkim-genkey with a perl script
                 that knows how to do splitting of character-strings in DNS
                 TXT records.
         TOOLS: Fix bug #SF3568846: Add "-t" to opendkim-testmsg to allow
                 override of the directory where temporary files go.  Also,
                 clean up temporary files after creating them.
         TOOLS: Add opendkim-rephistory.

 This should fix PR pkg/47370.


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/mail/opendkim/Makefile
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/mail/opendkim/PLIST
 cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/mail/opendkim/PLIST.filter
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/mail/opendkim/PLIST.stats
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/mail/opendkim/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/mail/opendkim/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 12 Jan 2013 07:05:19 +0000
State-Changed-Why:
Did the update fix your problem?


From: Richard PALO <Richard.PALO@baou.fr>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47370 (update pkgsrc/mail/opendkim to 2.7.3 to get over build
 problem in opendkim-spam)
Date: Sat, 12 Jan 2013 08:09:54 +0100

 This is a multi-part message in MIME format.
 --------------010001000108040907000305
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit

 Le 12/01/13 08:05, dholland@NetBSD.org a écrit :
 > Synopsis: update pkgsrc/mail/opendkim to 2.7.3 to get over build problem in opendkim-spam
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Sat, 12 Jan 2013 07:05:19 +0000
 > State-Changed-Why:
 > Did the update fix your problem?
 >
 >
 >
 >
 >
 Yes, I'm now able to build with cvs trunk.
 Thanks

 --------------010001000108040907000305
 Content-Type: text/x-vcard; charset=utf-8;
  name="Richard_PALO.vcf"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="Richard_PALO.vcf"

 YmVnaW46dmNhcmQNCmZuOlJpY2hhcmQgUEFMTw0KbjpQQUxPO1JpY2hhcmQNCm9yZzpTQVMg
 QkFPVTtUTlQgUEFDQQ0KYWRyOlpJIENhbXAgTGF1cmVudDs7MTE3LCBhdiBNYXJjZWwgQmVy
 cmU7TEEgU0VZTkUgU1VSIE1FUjtWQVI7ODM1MDA7RlJBTkNFDQplbWFpbDtpbnRlcm5ldDpy
 aWNoYXJkLnBhbG9AYmFvdS5mcg0KdGVsO3dvcms6KzMzIDQgOTQgOTQgMzkgOTQNCnRlbDtm
 YXg6KzMzIDQgOTQgODcgODYgNjcNCngtbW96aWxsYS1odG1sOkZBTFNFDQp2ZXJzaW9uOjIu
 MQ0KZW5kOnZjYXJkDQoNCg==
 --------------010001000108040907000305--

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 12 Jan 2013 07:42:51 +0000
State-Changed-Why:
Confirmed fixed, thanks.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.