NetBSD Problem Report #47404

From www@NetBSD.org  Fri Jan  4 13:05:49 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id BD1FD63E77A
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  4 Jan 2013 13:05:49 +0000 (UTC)
Message-Id: <20130104130548.6825863E77A@www.NetBSD.org>
Date: Fri,  4 Jan 2013 13:05:48 +0000 (UTC)
From: richard.palo@baou.fr
Reply-To: richard.palo@baou.fr
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/devel/py-pysvn build problem
X-Send-Pr-Version: www-1.0

>Number:         47404
>Category:       pkg
>Synopsis:       pkgsrc/devel/py-pysvn build problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    richard
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 04 13:10:00 +0000 2013
>Closed-Date:    Sun Dec 20 08:30:25 +0000 2015
>Last-Modified:  Sun Dec 20 08:30:25 +0000 2015
>Originator:     Richard PALO
>Release:        pkgsrc trunk
>Organization:
>Environment:
SunOS devzone 5.11 oi_151a7 i86pc i386 i86pc Solaris

>Description:
py-pysvn doesn't build correctly (at least not using the solaris ld)

   "LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath ...."

an extra '-' when specifying rpath seems to cause the problem
>How-To-Repeat:

>Fix:
richard@devzone:~/src/pkgsrc/devel/py-pysvn$ cvs diff
? patches/patch-Source_setup__configure.py
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/py-pysvn/distinfo,v
retrieving revision 1.4
diff -u -p -r1.4 distinfo
--- distinfo    16 Nov 2012 00:43:11 -0000      1.4
+++ distinfo    4 Jan 2013 12:59:44 -0000
@@ -4,3 +4,4 @@ SHA1 (pysvn-1.7.5.tar.gz) = 912d7081a829
 RMD160 (pysvn-1.7.5.tar.gz) = d412aab74737d371a184a327ceadc971a00340ab
 Size (pysvn-1.7.5.tar.gz) = 333366 bytes
 SHA1 (patch-Source_pysvn__client__cmd__checkin.cpp) = d4a6ab9709fea7728519fa3a34044bf93ef24bd2
+SHA1 (patch-Source_setup__configure.py) = 2d2fd50f90a32be2f646b4f0b4fe3860d6af411a


richard@devzone:~/src/pkgsrc/devel/py-pysvn$ diff -u -p /dev/null patches/patch-Source_setup__configure.py 
--- /dev/null   2013-01-04 13:23:59.000000000 +0100
+++ patches/patch-Source_setup__configure.py    2013-01-04 13:59:33.222582141 +0100
@@ -0,0 +1,40 @@
+$NetBSD$
+
+--- Source/setup_configure.py.orig     2010-12-31 13:19:01.000000000 +0000
++++ Source/setup_configure.py
+@@ -458,7 +458,7 @@ CCFLAGS=-Wall -fPIC %(includes)s %(debug
+ PYCXX=%(pycxx_dir)s
+ PYCXXSRC=%(pycxx_src_dir)s
+ LDSHARED=g++ -shared %(debug_cflags)s
+-LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath -Wl,%(svn_lib_dir)s \
++LDLIBS=-L%(svn_lib_dir)s -Wl,-rpath -Wl,%(svn_lib_dir)s \
+ -lsvn_client-1 \
+ -lsvn_diff-1 \
+ -lsvn_repos-1 \
+@@ -480,7 +480,7 @@ CCFLAGS=-Wall -fPIC %(includes)s %(debug
+ PYCXX=%(pycxx_dir)s
+ PYCXXSRC=%(pycxx_src_dir)s
+ LDSHARED=g++ -shared %(debug_cflags)s
+-LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath -Wl,%(svn_lib_dir)s \
++LDLIBS=-L%(svn_lib_dir)s -Wl,-rpath -Wl,%(svn_lib_dir)s \
+ -lsvn_client-1 \
+ -lsvn_diff-1 \
+ -lsvn_repos-1 \
+@@ -502,7 +502,7 @@ CCFLAGS=-Wall -fPIC %(includes)s %(debug
+ PYCXX=%(pycxx_dir)s
+ PYCXXSRC=%(pycxx_src_dir)s
+ LDSHARED=g++ -shared %(debug_cflags)s
+-LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath -Wl,%(svn_lib_dir)s \
++LDLIBS=-L%(svn_lib_dir)s -Wl,-rpath -Wl,%(svn_lib_dir)s \
+ -lsvn_client-1 \
+ -lsvn_diff-1 \
+ -lsvn_repos-1 \
+@@ -548,7 +548,7 @@ CCFLAGS=-Wall -fPIC %(includes)s %(debug
+ PYCXX=%(pycxx_dir)s
+ PYCXXSRC=%(pycxx_src_dir)s
+ LDSHARED=g++ -shared %(debug_cflags)s
+-LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath -Wl,/usr/lib:/usr/local/lib:%(svn_lib_dir)s \
++LDLIBS=-L%(svn_lib_dir)s -Wl,-rpath -Wl,/usr/lib:/usr/local/lib:%(svn_lib_dir)s \
+ -lsvn_client-1 \
+ -lsvn_diff-1 \
+ -lsvn_repos-1

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47404: pkgsrc/devel/py-pysvn build problem
Date: Sat, 12 Jan 2013 03:34:54 +0000

 On Fri, Jan 04, 2013 at 01:10:01PM +0000, richard.palo@baou.fr wrote:
  > >Description:
  > py-pysvn doesn't build correctly (at least not using the solaris ld)
  > 
  >    "LDLIBS=-L%(svn_lib_dir)s -Wl,--rpath ...."
  > 
  > an extra '-' when specifying rpath seems to cause the problem

 We can patch this package, but I think it might be a good idea to
 teach the wrappers to convert -Wl,--rpath to -Wl,-rpath, since this is
 probably not the only place this construction appears.

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Mon, 15 Apr 2013 13:32:59 +0000
State-Changed-Why:
should be fixed.
please confirm it and feedback.


From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
Date: Mon, 15 Apr 2013 13:31:29 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Mon Apr 15 13:31:28 UTC 2013

 Modified Files:
 	pkgsrc/devel/py-pysvn: Makefile

 Log Message:
 substitute hard-coded compiler rpath flag with ${COMPILER_RPATH_FLAG}.
 PR pkg/47404.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/devel/py-pysvn/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Richard PALO <Richard.PALO@baou.fr>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
Date: Sat, 20 Apr 2013 19:20:31 +0200

 This is a multi-part message in MIME format.
 --------------060201000800000203070908
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit

 Le 15/04/13 15:35, OBATA Akio a écrit :
 > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 >
 > From: "OBATA Akio" <obache@netbsd.org>
 >   To generate a diff of this commit:
 >   cvs rdiff -u -r1.18 -r1.19 pkgsrc/devel/py-pysvn/Makefile
 >

 First, testing *without* the above patch shows that the latest 
 (upgraded) version of py-pysvn seems to build fine.

 Therefore I think this patch is ultimately unnecessary.

 As Mr Holland suggested, I took a look at "fixing" the wrappers...

 First, the following:
 > richard@x3200:~/src/pkgsrc/mk/wrapper$ git diff master .
 > diff --git a/mk/wrapper/arg-source b/mk/wrapper/arg-source
 > index 111bb4d..f6231a5 100644
 > --- a/mk/wrapper/arg-source
 > +++ b/mk/wrapper/arg-source
 > @@ -88,6 +88,7 @@ while $test $# -gt 0; do
 >         ##############################################################
 >         # Split "-Wl,-R/dir1:/dir2" into "-Wl,-R/dir1 -Wl,-R/dir2".
 >         # Same for -R and -Wl,-rpath and -Wl,-rpath-link.
 > +       # (at the same time suppress the double dash in --rpath to -rpath
 >         ##############################################################
 >         -R*:*|-Wl,-R*:*|\
 >         -Wl,-rpath,*:*|-Wl,-rpath-link,*:*|-Wl,--rpath,*:*)
 > @@ -96,7 +97,7 @@ while $test $# -gt 0; do
 >                 -Wl,-R*)                R="-Wl,-R" ;;
 >                 -Wl,-rpath,*)           R="-Wl,-rpath," ;;
 >                 -Wl,-rpath-link,*)      R="-Wl,-rpath-link," ;;
 > -               -Wl,--rpath,*)          R="-Wl,--rpath," ;;
 > +               -Wl,--rpath,*)          R="-Wl,-rpath," ;;
 >                 esac
 >                 list="${arg#$R}"
 >                 save_IFS="${IFS}"; IFS=":"
 > @@ -111,6 +112,7 @@ while $test $# -gt 0; do
 >         # Merge and split "-Wl,-R -Wl,/dir1:/dir2" into
 >         # "-Wl,-R/dir1 -Wl,-R/dir2".  Same for -Wl,-rpath and
 >         # -Wl,-rpath-link.
 > +       # (at the same time suppress the double dash in --rpath to -rpath
 >         ##############################################################
 >         -Wl,-R|-Wl,-rpath|-Wl,-rpath-link|-Wl,--rpath)
 >                 nextarg="$1"; shift
 > @@ -118,7 +120,7 @@ while $test $# -gt 0; do
 >                 -Wl,-R)                 R="-Wl,-R" ;;
 >                 -Wl,-rpath)             R="-Wl,-rpath," ;;
 >                 -Wl,-rpath-link)        R="-Wl,-rpath-link," ;;
 > -               -Wl,--rpath)            R="-Wl,--rpath," ;;
 > +               -Wl,--rpath)            R="-Wl,-rpath," ;;
 >                 esac
 >                 nextarg="${nextarg#-Wl,}"
 >                 case $nextarg in

 seems to be able to do the trick...

 I originally worked on transform-gcc but this seemed to be a more global 
 solution.

 At the moment, in any pkgsrc/*/Makefile I can only easily find 
 pkgsrc/chat/inspircd which also has a workaround put in for this issue 
 (but seems a bit broken since migration to openssl 1.0.1x, at least on 
 solaris)...

 By searching patches, I notice no real workarounds, but that there do 
 exist a number of cases of '--rpath' used and as well '--rpath='

 I believe the split case above could be adapted to easily handle 
 '--rpath=' in addition to '--rpath,' .

 This seems in any event a reasonable patch for the case cited originally 
 *as*, after searching _COMPILER_RPATH_FLAG and _LINKER_RPATH_FLAG (nor 
 _OPSYS_COMPILER_RPATH_FLAG), I can find no explicit instances of "--rpath".

 Observations?

 --------------060201000800000203070908
 Content-Type: text/x-vcard; charset=utf-8;
  name="Richard_PALO.vcf"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="Richard_PALO.vcf"

 YmVnaW46dmNhcmQNCmZuOlJpY2hhcmQgUEFMTw0KbjpQQUxPO1JpY2hhcmQNCm9yZzpTQVMg
 QkFPVTtUTlQgUEFDQQ0KYWRyOlpJIENhbXAgTGF1cmVudDs7MTE3LCBhdiBNYXJjZWwgQmVy
 cmU7TEEgU0VZTkUgU1VSIE1FUjtWQVI7ODM1MDA7RlJBTkNFDQplbWFpbDtpbnRlcm5ldDpy
 aWNoYXJkLnBhbG9AYmFvdS5mcg0KdGVsO3dvcms6KzMzIDQgOTQgOTQgMzkgOTQNCnRlbDtm
 YXg6KzMzIDQgOTQgODcgODYgNjcNCngtbW96aWxsYS1odG1sOkZBTFNFDQp2ZXJzaW9uOjIu
 MQ0KZW5kOnZjYXJkDQoNCg==
 --------------060201000800000203070908--

From: Richard PALO <Richard.PALO@baou.fr>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
Date: Mon, 20 May 2013 07:39:51 +0200

 Le 20/04/13 19:25, Richard PALO a écrit :
 > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 >
 > From: Richard PALO <Richard.PALO@baou.fr>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
 > Date: Sat, 20 Apr 2013 19:20:31 +0200
 >
 >   This is a multi-part message in MIME format.
 >   --------------060201000800000203070908
 >   Content-Type: text/plain; charset=UTF-8; format=flowed
 >   Content-Transfer-Encoding: 8bit
 >
 >   Le 15/04/13 15:35, OBATA Akio a écrit :
 >   > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 >   >
 >   > From: "OBATA Akio" <obache@netbsd.org>
 >   >   To generate a diff of this commit:
 >   >   cvs rdiff -u -r1.18 -r1.19 pkgsrc/devel/py-pysvn/Makefile
 >   >
 >
 >   First, testing *without* the above patch shows that the latest
 >   (upgraded) version of py-pysvn seems to build fine.
 >
 >   Therefore I think this patch is ultimately unnecessary.
 >
 >   As Mr Holland suggested, I took a look at "fixing" the wrappers...
 >
 >   First, the following:
 >   > richard@x3200:~/src/pkgsrc/mk/wrapper$ git diff master .
 >   > diff --git a/mk/wrapper/arg-source b/mk/wrapper/arg-source
 >   > index 111bb4d..f6231a5 100644
 >   > --- a/mk/wrapper/arg-source
 >   > +++ b/mk/wrapper/arg-source
 >   > @@ -88,6 +88,7 @@ while $test $# -gt 0; do
 >   >         ##############################################################
 >   >         # Split "-Wl,-R/dir1:/dir2" into "-Wl,-R/dir1 -Wl,-R/dir2".
 >   >         # Same for -R and -Wl,-rpath and -Wl,-rpath-link.
 >   > +       # (at the same time suppress the double dash in --rpath to -rpath
 >   >         ##############################################################
 >   >         -R*:*|-Wl,-R*:*|\
 >   >         -Wl,-rpath,*:*|-Wl,-rpath-link,*:*|-Wl,--rpath,*:*)
 >   > @@ -96,7 +97,7 @@ while $test $# -gt 0; do
 >   >                 -Wl,-R*)                R="-Wl,-R" ;;
 >   >                 -Wl,-rpath,*)           R="-Wl,-rpath," ;;
 >   >                 -Wl,-rpath-link,*)      R="-Wl,-rpath-link," ;;
 >   > -               -Wl,--rpath,*)          R="-Wl,--rpath," ;;
 >   > +               -Wl,--rpath,*)          R="-Wl,-rpath," ;;
 >   >                 esac
 >   >                 list="${arg#$R}"
 >   >                 save_IFS="${IFS}"; IFS=":"
 >   > @@ -111,6 +112,7 @@ while $test $# -gt 0; do
 >   >         # Merge and split "-Wl,-R -Wl,/dir1:/dir2" into
 >   >         # "-Wl,-R/dir1 -Wl,-R/dir2".  Same for -Wl,-rpath and
 >   >         # -Wl,-rpath-link.
 >   > +       # (at the same time suppress the double dash in --rpath to -rpath
 >   >         ##############################################################
 >   >         -Wl,-R|-Wl,-rpath|-Wl,-rpath-link|-Wl,--rpath)
 >   >                 nextarg="$1"; shift
 >   > @@ -118,7 +120,7 @@ while $test $# -gt 0; do
 >   >                 -Wl,-R)                 R="-Wl,-R" ;;
 >   >                 -Wl,-rpath)             R="-Wl,-rpath," ;;
 >   >                 -Wl,-rpath-link)        R="-Wl,-rpath-link," ;;
 >   > -               -Wl,--rpath)            R="-Wl,--rpath," ;;
 >   > +               -Wl,--rpath)            R="-Wl,-rpath," ;;
 >   >                 esac
 >   >                 nextarg="${nextarg#-Wl,}"
 >   >                 case $nextarg in
 >
 >   seems to be able to do the trick...
 >
 >   I originally worked on transform-gcc but this seemed to be a more global
 >   solution.
 >
 >   At the moment, in any pkgsrc/*/Makefile I can only easily find
 >   pkgsrc/chat/inspircd which also has a workaround put in for this issue
 >   (but seems a bit broken since migration to openssl 1.0.1x, at least on
 >   solaris)...
 >
 >   By searching patches, I notice no real workarounds, but that there do
 >   exist a number of cases of '--rpath' used and as well '--rpath='
 >
 >   I believe the split case above could be adapted to easily handle
 >   '--rpath=' in addition to '--rpath,' .
 >
 >   This seems in any event a reasonable patch for the case cited originally
 >   *as*, after searching _COMPILER_RPATH_FLAG and _LINKER_RPATH_FLAG (nor
 >   _OPSYS_COMPILER_RPATH_FLAG), I can find no explicit instances of "--rpath".
 >
 >   Observations?
 >
 I don't have a problem with the "quick" fix to py-pysvn,
 but perhaps consideration should be taken for a possible global solution 
 as Mr Holland suggested perhaps with an adaptation of the above patch if 
 anybody else has tested it...

 -- 
 Richard PALO
 TNT PACA, dénomination commerciale de la société BAOU
 SAS au capital de 50.000 € - RCS TOULON 441 322 385 - APE 4322B
 117, av Marcel Berre - ZI Camp Laurent - 83500 LA SEYNE SUR MER
 tél:04.94.94.39.94 fax:04.94.87.86.67 mailto:Richard.PALO@baou.fr
 » Avant d'imprimer, pensez aux conséquences environnementales «

State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 23 Dec 2013 23:45:58 +0000
State-Changed-Why:
feedback was received.

what's still in here is a wrappers patch for fixing the -Wl,--rpath form
in general; this should be committed after the current pkgsrc freeze ends.


Responsible-Changed-From-To: pkg-manager->richard
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Mon, 23 Dec 2013 23:46:24 +0000
Responsible-Changed-Why:
you can commit your own patches now :-)


From: Richard PALO <richard@netbsd.org>
To: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, richard.palo@baou.fr
Cc: 
Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
Date: Sat, 20 Jun 2015 07:15:27 +0200

 Le 20/05/13 07:40, Richard PALO a écrit :
 > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 > 
 > From: Richard PALO <Richard.PALO@baou.fr>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
 > Date: Mon, 20 May 2013 07:39:51 +0200
 > 
 >  Le 20/04/13 19:25, Richard PALO a écrit :
 >  > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 >  >
 >  > From: Richard PALO <Richard.PALO@baou.fr>
 >  > To: gnats-bugs@NetBSD.org
 >  > Cc:
 >  > Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
 >  > Date: Sat, 20 Apr 2013 19:20:31 +0200
 >  >
 >  >   This is a multi-part message in MIME format.
 >  >   --------------060201000800000203070908
 >  >   Content-Type: text/plain; charset=UTF-8; format=flowed
 >  >   Content-Transfer-Encoding: 8bit
 >  >
 >  >   Le 15/04/13 15:35, OBATA Akio a écrit :
 >  >   > The following reply was made to PR pkg/47404; it has been noted by GNATS.
 >  >   >
 >  >   > From: "OBATA Akio" <obache@netbsd.org>
 >  >   >   To generate a diff of this commit:
 >  >   >   cvs rdiff -u -r1.18 -r1.19 pkgsrc/devel/py-pysvn/Makefile
 >  >   >
 >  >
 >  >   First, testing *without* the above patch shows that the latest
 >  >   (upgraded) version of py-pysvn seems to build fine.
 >  >
 >  >   Therefore I think this patch is ultimately unnecessary.
 >  >
 >  >   As Mr Holland suggested, I took a look at "fixing" the wrappers...
 >  >
 >  >   First, the following:
 >  >   > richard@x3200:~/src/pkgsrc/mk/wrapper$ git diff master .
 >  >   > diff --git a/mk/wrapper/arg-source b/mk/wrapper/arg-source
 >  >   > index 111bb4d..f6231a5 100644
 >  >   > --- a/mk/wrapper/arg-source
 >  >   > +++ b/mk/wrapper/arg-source
 >  >   > @@ -88,6 +88,7 @@ while $test $# -gt 0; do
 >  >   >         ##############################################################
 >  >   >         # Split "-Wl,-R/dir1:/dir2" into "-Wl,-R/dir1 -Wl,-R/dir2".
 >  >   >         # Same for -R and -Wl,-rpath and -Wl,-rpath-link.
 >  >   > +       # (at the same time suppress the double dash in --rpath to -rpath
 >  >   >         ##############################################################
 >  >   >         -R*:*|-Wl,-R*:*|\
 >  >   >         -Wl,-rpath,*:*|-Wl,-rpath-link,*:*|-Wl,--rpath,*:*)
 >  >   > @@ -96,7 +97,7 @@ while $test $# -gt 0; do
 >  >   >                 -Wl,-R*)                R="-Wl,-R" ;;
 >  >   >                 -Wl,-rpath,*)           R="-Wl,-rpath," ;;
 >  >   >                 -Wl,-rpath-link,*)      R="-Wl,-rpath-link," ;;
 >  >   > -               -Wl,--rpath,*)          R="-Wl,--rpath," ;;
 >  >   > +               -Wl,--rpath,*)          R="-Wl,-rpath," ;;
 >  >   >                 esac
 >  >   >                 list="${arg#$R}"
 >  >   >                 save_IFS="${IFS}"; IFS=":"
 >  >   > @@ -111,6 +112,7 @@ while $test $# -gt 0; do
 >  >   >         # Merge and split "-Wl,-R -Wl,/dir1:/dir2" into
 >  >   >         # "-Wl,-R/dir1 -Wl,-R/dir2".  Same for -Wl,-rpath and
 >  >   >         # -Wl,-rpath-link.
 >  >   > +       # (at the same time suppress the double dash in --rpath to -rpath
 >  >   >         ##############################################################
 >  >   >         -Wl,-R|-Wl,-rpath|-Wl,-rpath-link|-Wl,--rpath)
 >  >   >                 nextarg="$1"; shift
 >  >   > @@ -118,7 +120,7 @@ while $test $# -gt 0; do
 >  >   >                 -Wl,-R)                 R="-Wl,-R" ;;
 >  >   >                 -Wl,-rpath)             R="-Wl,-rpath," ;;
 >  >   >                 -Wl,-rpath-link)        R="-Wl,-rpath-link," ;;
 >  >   > -               -Wl,--rpath)            R="-Wl,--rpath," ;;
 >  >   > +               -Wl,--rpath)            R="-Wl,-rpath," ;;
 >  >   >                 esac
 >  >   >                 nextarg="${nextarg#-Wl,}"
 >  >   >                 case $nextarg in
 >  >
 >  >   seems to be able to do the trick...
 >  >
 >  >   I originally worked on transform-gcc but this seemed to be a more global
 >  >   solution.
 >  >
 >  >   At the moment, in any pkgsrc/*/Makefile I can only easily find
 >  >   pkgsrc/chat/inspircd which also has a workaround put in for this issue
 >  >   (but seems a bit broken since migration to openssl 1.0.1x, at least on
 >  >   solaris)...
 >  >
 >  >   By searching patches, I notice no real workarounds, but that there do
 >  >   exist a number of cases of '--rpath' used and as well '--rpath='
 >  >
 >  >   I believe the split case above could be adapted to easily handle
 >  >   '--rpath=' in addition to '--rpath,' .
 >  >
 >  >   This seems in any event a reasonable patch for the case cited originally
 >  >   *as*, after searching _COMPILER_RPATH_FLAG and _LINKER_RPATH_FLAG (nor
 >  >   _OPSYS_COMPILER_RPATH_FLAG), I can find no explicit instances of "--rpath".
 >  >
 >  >   Observations?
 >  >
 >  I don't have a problem with the "quick" fix to py-pysvn,
 >  but perhaps consideration should be taken for a possible global solution 
 >  as Mr Holland suggested perhaps with an adaptation of the above patch if 
 >  anybody else has tested it...
 >  
 >  -- 
 >  Richard PALO

 This bug report is still open (even though the quick fix to py-pysvn was made by obache@ at the time),
 I'm still in favour of fixing mk/wrapper/arg-source after the freeze is lifted.

 Any objections?

 -- 
 Richard PALO

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/47404 CVS commit: pkgsrc/devel/py-pysvn
Date: Sun, 28 Jun 2015 20:03:31 +0000

 On Sat, Jun 20, 2015 at 05:25:01AM +0000, Richard PALO wrote:
  > This bug report is still open (even though the quick fix to
  > py-pysvn was made by obache@ at the time), I'm still in favour of
  > fixing mk/wrapper/arg-source after the freeze is lifted.
  >  
  >  Any objections?

 Not from me!

 -- 
 David A. Holland
 dholland@netbsd.org

From: "Richard PALO" <richard@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47404 CVS commit: pkgsrc/mk/wrapper
Date: Fri, 20 Nov 2015 05:49:24 +0000

 Module Name:	pkgsrc
 Committed By:	richard
 Date:		Fri Nov 20 05:49:24 UTC 2015

 Modified Files:
 	pkgsrc/mk/wrapper: arg-source

 Log Message:
 PR pkg/47404
 wrapper should convert '--rpath' to '-rpath', fixing pysvn as well as
 many other packages inadvertently using double-dash form of rpath.


 To generate a diff of this commit:
 cvs rdiff -u -r1.15 -r1.16 pkgsrc/mk/wrapper/arg-source

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: richard@NetBSD.org
State-Changed-When: Sun, 20 Dec 2015 08:30:25 +0000
State-Changed-Why:
patches commited, mark as closed.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.