NetBSD Problem Report #47405

From www@NetBSD.org  Fri Jan  4 14:34:40 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 3B79663E77A
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  4 Jan 2013 14:34:40 +0000 (UTC)
Message-Id: <20130104143439.6C78A63E77A@www.NetBSD.org>
Date: Fri,  4 Jan 2013 14:34:39 +0000 (UTC)
From: richard.palo@baou.fr
Reply-To: richard.palo@baou.fr
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/devel/splint: another patch fixed to correctly involve sunstudio
X-Send-Pr-Version: www-1.0

>Number:         47405
>Category:       pkg
>Synopsis:       pkgsrc/devel/splint: another patch fixed to correctly involve sunstudio
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 04 14:35:00 +0000 2013
>Closed-Date:    
>Last-Modified:  Mon May 15 17:17:23 +0000 2017
>Originator:     Richard PALO
>Release:        pkgsrc trunk
>Organization:
>Environment:
SunOS devzone 5.11 oi_151a7 i86pc i386 i86pc Solaris

>Description:
Building devel/splint on solaris with gcc (4.7.2) bombs out with the following sort of errors:

Compiling cgrammar.c...
In file included from Headers/general.h:17:0,
                 from Headers/basic.h:42,
                 from cgrammar.c:553:
Headers/forwardTypes.h:97:15: error: expected declaration specifiers or '...' before '*' token
In file included from Headers/misc.h:15:0,
                 from Headers/general.h:25,
                 from Headers/basic.h:42,
                 from cgrammar.c:553:
Headers/lclMisc.h:6:1: error: unknown type name 'bool'

>How-To-Repeat:

>Fix:
patches/patch-aa excludes *all* solaris targets 
instead of _only_ sunstudio compilers on solaris.

richard@devzone:~/src/pkgsrc/devel/splint$ cvs diff
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/splint/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo    2 Jun 2012 05:43:07 -0000       1.9
+++ distinfo    4 Jan 2013 14:33:12 -0000
@@ -3,6 +3,6 @@ $NetBSD: distinfo,v 1.9 2012/06/02 05:43
 SHA1 (splint-3.1.2.src.tgz) = 0df489cb228dcfffb149b38c57614c2c3e200501
 RMD160 (splint-3.1.2.src.tgz) = 52e9786d3cbeaa437877a33b18e42b32dff3b96b
 Size (splint-3.1.2.src.tgz) = 2284033 bytes
-SHA1 (patch-aa) = 3324bff7178957f25bab17cb8ab4d3d25a2d0397
+SHA1 (patch-aa) = 569d0f6d0300b35dec72b4883c0478741e572274
 SHA1 (patch-src_Headers_scan_h) = 9d286990abcad9f3df49c19c6302f1a4a590ee1b
 SHA1 (patch-src_osd.c) = 84499ef0e9bd23ea89dcb14b8951fa0dfcfed198
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/devel/splint/patches/patch-aa,v
retrieving revision 1.3
diff -u -p -r1.3 patch-aa
--- patches/patch-aa    3 Mar 2009 08:58:23 -0000       1.3
+++ patches/patch-aa    4 Jan 2013 14:33:12 -0000
@@ -9,7 +9,7 @@ Some systems don't have <stdbool.h>.
  # include <stdio.h>

 -# if !defined (WIN32) &&  !(defined (OS2) && defined (__IBMC__))
-+# if !defined (WIN32) &&  !(defined (OS2) && defined (__IBMC__)) && !(defined(__GNUC__) && (__GNUC__ == 2)) && !(defined(__sun) && !(__STDC_VERSION__ >= 199901L))
++# if !defined (WIN32) &&  !(defined (OS2) && defined (__IBMC__)) && !(defined(__GNUC__) && (__GNUC__ == 2)) && !(defined(__sun) && defined(__SUNPRO_C) && !(__STDC_VERSION__ >= 199901L))
  /* Microsoft VC++ still doesn't support ISO C99... */
  # include <stdbool.h>
  # endif

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47405 CVS commit: pkgsrc/devel/splint
Date: Fri, 5 May 2017 07:34:06 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Fri May  5 07:34:06 UTC 2017

 Modified Files:
 	pkgsrc/devel/splint: distinfo
 	pkgsrc/devel/splint/patches: patch-aa

 Log Message:
 splint: use the standard check for C99 before including a C99 header

 If PR pkg/47405 was not fixed before (it probably was), this should
 definitely do the trick.


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/devel/splint/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/splint/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Benny Siegert" <bsiegert@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47405 CVS commit: [pkgsrc-2017Q1] pkgsrc/devel/splint
Date: Sat, 6 May 2017 15:32:44 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Sat May  6 15:32:43 UTC 2017

 Modified Files:
 	pkgsrc/devel/splint [pkgsrc-2017Q1]: distinfo
 	pkgsrc/devel/splint/patches [pkgsrc-2017Q1]: patch-aa

 Log Message:
 Pullup ticket #5402 - requested by sevan
 devel/splint: build fix

 Revisions pulled up:
 - devel/splint/distinfo                                         1.11
 - devel/splint/patches/patch-aa                                 1.4

 ---
    Module Name:    pkgsrc
    Committed By:   maya
    Date:           Fri May  5 07:34:06 UTC 2017

    Modified Files:
            pkgsrc/devel/splint: distinfo
            pkgsrc/devel/splint/patches: patch-aa

    Log Message:
    splint: use the standard check for C99 before including a C99 header

    If PR pkg/47405 was not fixed before (it probably was), this should
    definitely do the trick.


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.10.12.1 pkgsrc/devel/splint/distinfo
 cvs rdiff -u -r1.3 -r1.3.66.1 pkgsrc/devel/splint/patches/patch-aa

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 15 May 2017 17:17:23 +0000
State-Changed-Why:
Is this fixed now?


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.