NetBSD Problem Report #47419

From www@NetBSD.org  Tue Jan  8 00:24:17 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id F031863E9FB
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  8 Jan 2013 00:24:16 +0000 (UTC)
Message-Id: <20130108002415.C235263E9FB@www.NetBSD.org>
Date: Tue,  8 Jan 2013 00:24:15 +0000 (UTC)
From: anthony.mallet@laas.fr
Reply-To: anthony.mallet@laas.fr
To: gnats-bugs@NetBSD.org
Subject: ifconfig on a gif(4) interface doesn't display the MTU
X-Send-Pr-Version: www-1.0

>Number:         47419
>Category:       kern
>Synopsis:       ifconfig on a gif(4) interface doesn't display the MTU
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 08 00:25:00 +0000 2013
>Closed-Date:    Sat Jul 13 17:02:45 +0000 2013
>Last-Modified:  Sat Jul 13 17:02:45 +0000 2013
>Originator:     Anthony Mallet
>Release:        -current
>Organization:
>Environment:
NetBSD cactus 6.99.16 NetBSD 6.99.16 (CACTUS) #26: Tue Jan  8 01:14:43 CET 2013
>Description:
ifconfig on a gif(4) does not display the MTU.

The attached patch fixes this for me. It deletes the driver specific
handling of the SIOCGIFMTU ioctl() and let ifioctl_common() handle it,
as there is no driver specific action to be done.

>How-To-Repeat:

ifconfig gif0 | grep mtu


>Fix:
Index: if_gif.c
===================================================================
RCS file: /cvsroot/src/sys/net/if_gif.c,v
retrieving revision 1.80
diff -u -r1.80 if_gif.c
--- if_gif.c    28 Oct 2011 16:42:52 -0000      1.80
+++ if_gif.c    8 Jan 2013 00:18:06 -0000
@@ -496,9 +496,6 @@
                }
                break;

-       case SIOCGIFMTU:
-               break;
-
        case SIOCSIFMTU:
                if (ifr->ifr_mtu < GIF_MTU_MIN || ifr->ifr_mtu > GIF_MTU_MAX)
                        return EINVAL;

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/47419: ifconfig on a gif(4) interface doesn't display the
 MTU
Date: Thu, 10 Jan 2013 16:39:04 +0000

 Please use gnats-bugs@ for bug database traffic and don't send to the
 mailing list directly.

    ------

 From: David Young <dyoung@pobox.com>
 To: netbsd-bugs@netbsd.org
 Subject: Re: kern/47419: ifconfig on a gif(4) interface doesn't display the MTU
 Date: Mon, 7 Jan 2013 20:48:29 -0600
 Mail-Followup-To: David Young <dyoung@pobox.com>, netbsd-bugs@netbsd.org

 On Tue, Jan 08, 2013 at 12:25:00AM +0000, anthony.mallet@laas.fr wrote:
 > >Number:         47419
 > >Category:       kern
 > >Synopsis:       ifconfig on a gif(4) interface doesn't display the MTU
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    kern-bug-people
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Tue Jan 08 00:25:00 +0000 2013
 > >Originator:     Anthony Mallet
 > >Release:        -current
 > >Organization:
 > >Environment:
 > NetBSD cactus 6.99.16 NetBSD 6.99.16 (CACTUS) #26: Tue Jan  8 01:14:43 CET 2013
 > >Description:
 > ifconfig on a gif(4) does not display the MTU.
 > 
 > The attached patch fixes this for me. It deletes the driver specific
 > handling of the SIOCGIFMTU ioctl() and let ifioctl_common() handle it,
 > as there is no driver specific action to be done.
 > 
 > >How-To-Repeat:
 > 
 > ifconfig gif0 | grep mtu
 > 
 > 
 > >Fix:
 > Index: if_gif.c
 > ===================================================================
 > RCS file: /cvsroot/src/sys/net/if_gif.c,v
 > retrieving revision 1.80
 > diff -u -r1.80 if_gif.c
 > --- if_gif.c    28 Oct 2011 16:42:52 -0000      1.80
 > +++ if_gif.c    8 Jan 2013 00:18:06 -0000
 > @@ -496,9 +496,6 @@
 >                 }
 >                 break;
 >  
 > -       case SIOCGIFMTU:
 > -               break;
 > -
 >         case SIOCSIFMTU:
 >                 if (ifr->ifr_mtu < GIF_MTU_MIN || ifr->ifr_mtu > GIF_MTU_MAX)
 >                         return EINVAL;

 FWIW, this looks like the right fix to me.

 It's possible I broke that when I did one of several ifioctl()
 overhauls, sorry!

 Dave

 -- 
 David Young
 dyoung@pobox.com    Urbana, IL    (217) 721-9981

From: "DEGROOTE Arnaud" <degroote@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47419 CVS commit: src/sys/net
Date: Sat, 19 Jan 2013 16:18:32 +0000

 Module Name:	src
 Committed By:	degroote
 Date:		Sat Jan 19 16:18:32 UTC 2013

 Modified Files:
 	src/sys/net: if_gif.c

 Log Message:
 PR kern/47419: Antony Mallet: ifconfig doesn't diplay MTU on gif(4)

 There is no special treatment for SIOCGITMTU in gif(4), so just pass it to
 ifioctl_common().


 To generate a diff of this commit:
 cvs rdiff -u -r1.80 -r1.81 src/sys/net/if_gif.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47419 CVS commit: [netbsd-6] src/sys/net
Date: Fri, 8 Feb 2013 20:42:51 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Fri Feb  8 20:42:51 UTC 2013

 Modified Files:
 	src/sys/net [netbsd-6]: if_gif.c

 Log Message:
 Pull up following revision(s) (requested by degroote in ticket #792):
 	sys/net/if_gif.c: revision 1.81
 PR kern/47419: Antony Mallet: ifconfig doesn't diplay MTU on gif(4)
 There is no special treatment for SIOCGITMTU in gif(4), so just pass it to
 ifioctl_common().


 To generate a diff of this commit:
 cvs rdiff -u -r1.80 -r1.80.8.1 src/sys/net/if_gif.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sat, 13 Jul 2013 17:02:45 +0000
State-Changed-Why:
Patch committed and pulled up to netbsd-6.  Thanks!


>Unformatted:

Home	PR Database Search