NetBSD Problem Report #47440

From campbell@mumble.net  Sun Jan 13 21:16:04 2013
Return-Path: <campbell@mumble.net>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 0436363ECE1
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 13 Jan 2013 21:16:03 +0000 (UTC)
Message-Id: <20130113211545.7D611604DE@jupiter.mumble.net>
Date: Sun, 13 Jan 2013 21:15:45 +0000 (UTC)
From: Taylor R Campbell <campbell+pkgsrc@mumble.net>
Reply-To: Taylor R Campbell <campbell+pkgsrc@mumble.net>
To: gnats-bugs@gnats.NetBSD.org
Subject: `make checksum' doesn't refetch even if FAILOVER_FETCH is set
X-Send-Pr-Version: 3.95

>Number:         47440
>Category:       pkg
>Synopsis:       `bmake checksum' doesn't refetch even if FAILOVER_FETCH is set
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 13 21:20:01 +0000 2013
>Last-Modified:  Mon Jan 14 02:35:02 +0000 2013
>Originator:     Taylor R Campbell <campbell+pkgsrc@mumble.net>
>Release:        pkgsrc-current
>Organization:
>Environment:
>Description:

	If a downloaded distfile has a bad checksum, `bmake fetch' does
	nothing to refetch it since it appears to be up-to-date, and
	`bmake checksum' simply fails.  If you set FAILOVER_FETCH=yes,
	`bmake fetch' looks at the checksum only if the file was absent
	to begin with in order to decide whether to refetch it, which
	doesn't help if the file has already been downloaded but got
	corrupted on disk.

>How-To-Repeat:

	Corrupt some of your distfiles on disk and try to run a bulk
	build or whatever.

>Fix:

	Yes, please!

>Audit-Trail:
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47440: `make checksum' doesn't refetch even if
 FAILOVER_FETCH is set
Date: Sun, 13 Jan 2013 23:10:59 +0100

 On Sun, Jan 13, 2013 at 09:20:01PM +0000, Taylor R Campbell wrote:
 > 	If a downloaded distfile has a bad checksum, `bmake fetch' does
 > 	nothing to refetch it since it appears to be up-to-date, and
 > 	`bmake checksum' simply fails.  If you set FAILOVER_FETCH=yes,
 > 	`bmake fetch' looks at the checksum only if the file was absent
 > 	to begin with in order to decide whether to refetch it, which
 > 	doesn't help if the file has already been downloaded but got
 > 	corrupted on disk.

 This is at least somewhat intentional. Otherwise if upstream does manage
 to mess up the distfile, it will retry to fetch the file on every run,
 which can add a lot of volume...

 Joerg

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/47440: `make checksum' doesn't refetch even if
 FAILOVER_FETCH is set
Date: Mon, 14 Jan 2013 01:21:02 +0000

 On Sun, Jan 13, 2013 at 10:15:07PM +0000, Joerg Sonnenberger wrote:
  >  On Sun, Jan 13, 2013 at 09:20:01PM +0000, Taylor R Campbell wrote:
  >  > 	If a downloaded distfile has a bad checksum, `bmake fetch' does
  >  > 	nothing to refetch it since it appears to be up-to-date, and
  >  > 	`bmake checksum' simply fails.  If you set FAILOVER_FETCH=yes,
  >  > 	`bmake fetch' looks at the checksum only if the file was absent
  >  > 	to begin with in order to decide whether to refetch it, which
  >  > 	doesn't help if the file has already been downloaded but got
  >  > 	corrupted on disk.
  >  
  >  This is at least somewhat intentional. Otherwise if upstream does manage
  >  to mess up the distfile, it will retry to fetch the file on every run,
  >  which can add a lot of volume...

 How about 'make delete-distfiles' and 'make delete-bad-distfiles'?

 -- 
 David A. Holland
 dholland@netbsd.org

From: Taylor R Campbell <campbell+pkgsrc@mumble.net>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/47440: `make checksum' doesn't refetch even if
	FAILOVER_FETCH is set
Date: Mon, 14 Jan 2013 02:31:39 +0000

    Date: Mon, 14 Jan 2013 01:25:02 +0000 (UTC)
    From: David Holland <dholland-pbugs@netbsd.org>

    How about 'make delete-distfiles' and 'make delete-bad-distfiles'?

 Apparently we already have that, but it's spelled `lintpkgsrc -m -r'.

Home	PR Database Search