NetBSD Problem Report #47631

From nakayosh@leto.eonet.ne.jp  Fri Mar  8 14:52:16 2013
Return-Path: <nakayosh@leto.eonet.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 4F9F063EC10
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  8 Mar 2013 14:52:16 +0000 (UTC)
Message-Id: <20130308145213.16EFF1CF1B3@ae0000-mailauth11.eo.k-opti.ad.jp>
Date: Fri,  8 Mar 2013 23:52:13 +0900 (JST)
From: nakayosh@leto.eonet.ne.jp
Reply-To: nakayosh@leto.eonet.ne.jp
To: gnats-bugs@gnats.NetBSD.org
Subject: utimes.2
X-Send-Pr-Version: 3.95

>Number:         47631
>Category:       lib
>Synopsis:       utimes.2
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 08 14:55:00 +0000 2013
>Closed-Date:    Sat Jun 01 23:38:03 +0000 2013
>Last-Modified:  Sat Jun 01 23:38:03 +0000 2013
>Originator:     NAKAJIMA Yoshihiro
>Release:        NetBSD-current/20130308
>Organization:
>Environment:
System: NetBSD vajra 6.99.17 NetBSD 6.99.17 (VAJRA) #1: Fri Mar 8 23:10:35 JST 2013 nakayosh@vajra:/usr/src/sys/arch/i386/compile/VAJRA i386
Architecture: i386
Machine: i386
>Description:

Issues of utimes.2:

1. Utimens and lutimens don't require timeval but timespec.
2. The order of functions doesn't have a uniformity.
3. Utimens.2 and lutimens.2 aren't installed.


>How-To-Repeat:
>Fix:

diff -u src/lib/libc/sys/Makefile.inc.ORIG src/lib/libc/sys/Makefile.inc
--- src/lib/libc/sys/Makefile.inc.ORIG	2012-11-19 02:41:53.000000000 +0900
+++ src/lib/libc/sys/Makefile.inc	2012-12-02 17:01:51.000000000 +0900
@@ -334,7 +334,8 @@
 MLINKS+=truncate.2 ftruncate.2
 MLINKS+=unlink.2 unlinkat.2
 MLINKS+=utimes.2 futimes.2 utimes.2 lutimes.2
-MLINKS+=utimes.2 futimens.2 utimes.2 utimensat.2
+MLINKS+=utimes.2 utimens.2 utimes.2 futimens.2 utimes.2 lutimens.2
+MLINKS+=utimes.2 utimensat.2
 MLINKS+=wait.2 wait3.2 wait.2 wait4.2 wait.2 waitpid.2
 MLINKS+=write.2 writev.2 write.2 pwrite.2 write.2 pwritev.2
 MLINKS+=pipe.2 pipe2.2
diff -u src/lib/libc/sys/utimes.2.ORIG src/lib/libc/sys/utimes.2
--- src/lib/libc/sys/utimes.2.ORIG	2013-01-13 17:15:02.000000000 +0900
+++ src/lib/libc/sys/utimes.2	2013-01-19 14:07:10.000000000 +0900
@@ -50,11 +50,11 @@
 .Ft int
 .Fn lutimes "const char *path" "const struct timeval times[2]"
 .Ft int
-.Fn utimens "const char *path" "const struct timeval times[2]"
+.Fn futimes "int fd" "const struct timeval times[2]"
 .Ft int
-.Fn lutimens "const char *path" "const struct timeval times[2]"
+.Fn utimens "const char *path" "const struct timespec times[2]"
 .Ft int
-.Fn futimes "int fd" "const struct timeval times[2]"
+.Fn lutimens "const char *path" "const struct timespec times[2]"
 .Ft int
 .Fn futimens "int fd" "const struct timespec times[2]"
 .In fcntl.h

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47631 CVS commit: src/lib/libc/sys
Date: Fri, 8 Mar 2013 11:52:11 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Fri Mar  8 16:52:11 UTC 2013

 Modified Files:
 	src/lib/libc/sys: utimes.2

 Log Message:
 PR/47631: NAKAJIMA Yoshihiro

 1. Utimens and lutimens don't require timeval but timespec.
 2. The order of functions doesn't have a uniformity.
 3. Utimens.2 and lutimens.2 aren't installed.


 To generate a diff of this commit:
 cvs rdiff -u -r1.36 -r1.37 src/lib/libc/sys/utimes.2

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 01 Jun 2013 23:38:03 +0000
State-Changed-Why:
christos committed it


>Unformatted:

Home	PR Database Search