NetBSD Problem Report #47642

From www@NetBSD.org  Tue Mar 12 09:01:20 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id BFB5C63ECA3
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 12 Mar 2013 09:01:19 +0000 (UTC)
Message-Id: <20130312090119.00E9863ECA3@www.NetBSD.org>
Date: Tue, 12 Mar 2013 09:01:18 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: graphics/gimp-ufraw does not compile on Solaris
X-Send-Pr-Version: www-1.0

>Number:         47642
>Category:       pkg
>Synopsis:       graphics/gimp-ufraw does not compile on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gdt
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 12 09:05:00 +0000 2013
>Closed-Date:    Fri Mar 15 23:11:48 +0000 2013
>Last-Modified:  Fri Mar 15 23:11:48 +0000 2013
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
graphics/gimp-ufraw does not compile on Solaris 10 using GCC 4.7.0. I have already reported this upstream.
>How-To-Repeat:

>Fix:
Until an official fix is released, these two patches should help:

--- dcraw.cc.orig       2013-03-08 03:57:35.000000000 +0000
+++ dcraw.cc
@@ -2253,7 +2253,7 @@ void CLASS lossy_dng_load_raw()
       coeff[i] = getreal(12);
     for (i=0; i < 256; i++) {
       for (tot=j=0; j <= deg; j++)
-       tot += coeff[j] * pow(i/255.0, j);
+       tot += coeff[j] * pow(i/255.0, (int)j);
       curve[c][i] = tot*0xffff;
     }
   }



--- dcraw_indi.c.orig   2013-03-05 03:40:55.000000000 +0000
+++ dcraw_indi.c
@@ -148,7 +148,7 @@ void CLASS wavelet_denoise_INDI(ushort(*
     if ((nc = colors) == 3 && filters) nc++;
     progress(PROGRESS_WAVELET_DENOISE, -nc * 5);
 #ifdef _OPENMP
-#ifdef __sun                   /* Fix bug #3205673 - NKBJ */
+#ifdef __SUNPRO_C                      /* Fix bug #3205673 - NKBJ */
     #pragma omp parallel for                           \
     default(none)                                      \
     shared(nc,image,size,noise)                                \


See also ufraw bug 275 (http://sourceforge.net/p/ufraw/bugs/275/) as reference for earlier attempts to fix the second problem.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->gdt
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 12 Mar 2013 09:31:25 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->closed
State-Changed-By: gdt@NetBSD.org
State-Changed-When: Fri, 15 Mar 2013 23:11:48 +0000
State-Changed-Why:
problem fixed upstream; will get picked up in next version


>Unformatted:

 I can not find this in the tracker or on the mailinglist (I am an
 upstream maintainer).

 For the pow(), can you explain why this is needed?  pow is defined to
 take a double, and passing unsigned seems legitimate.

 For the second patch, is this right for all users?  It seems that
 perhaps this ifdef is about a compiler rather than a platform; are you
 running into wanting to have the second half of the ifdef with gcc on
 Solaris?

Home	PR Database Search