NetBSD Problem Report #47825

From www@NetBSD.org  Fri May 17 14:37:56 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 592A163ECDD
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 17 May 2013 14:37:56 +0000 (UTC)
Message-Id: <20130517143755.A277063ECDD@www.NetBSD.org>
Date: Fri, 17 May 2013 14:37:55 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] Fix hardcoding of NetBSD in t_grep.sh
X-Send-Pr-Version: www-1.0

>Number:         47825
>Category:       misc
>Synopsis:       [PATCH] Fix hardcoding of NetBSD in t_grep.sh
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 17 14:40:00 +0000 2013
>Closed-Date:    Wed Aug 07 23:05:02 +0000 2013
>Last-Modified:  Wed Aug 07 23:05:02 +0000 2013
>Originator:     Garrett Cooper
>Release:        CURRENT
>Organization:
EMC Isilon
>Environment:
n/a
>Description:
The attached patch fixes hardcoding of $(uname) so it makes the test easier to port over to FreeBSD and other BSDs, as well as custom branded NetBSD variants.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Garrett Cooper <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/47825: [PATCH] Fix hardcoding of NetBSD in t_grep.sh
Date: Fri, 17 May 2013 10:46:48 -0400

 --Apple-Mail=_5EFB02D0-4E4F-4442-8ADD-C37021AEC32C
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 	And.. here's the patch!
 -Garrett

 --Apple-Mail=_5EFB02D0-4E4F-4442-8ADD-C37021AEC32C
 Content-Disposition: attachment;
 	filename=t_grep-fix-uname-hardcoding.patch
 Content-Type: application/octet-stream;
 	name="t_grep-fix-uname-hardcoding.patch"
 Content-Transfer-Encoding: 7bit

 Index: tests/usr.bin/grep/t_grep.sh
 ===================================================================
 RCS file: /cvsroot/src/tests/usr.bin/grep/t_grep.sh,v
 retrieving revision 1.1
 diff -u -r1.1 t_grep.sh
 --- tests/usr.bin/grep/t_grep.sh	17 Mar 2012 16:33:13 -0000	1.1
 +++ tests/usr.bin/grep/t_grep.sh	17 May 2013 14:35:34 -0000
 @@ -43,7 +43,7 @@
  }
  binary_body()
  {
 -	atf_check -o file:"$(atf_get_srcdir)/d_binary.out" grep NetBSD /bin/sh
 +	atf_check -o file:"$(atf_get_srcdir)/d_binary.out" grep $(uname) /bin/sh
  }

  atf_test_case recurse

 --Apple-Mail=_5EFB02D0-4E4F-4442-8ADD-C37021AEC32C--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47825 CVS commit: src/tests/usr.bin/grep
Date: Fri, 17 May 2013 11:39:17 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri May 17 15:39:17 UTC 2013

 Modified Files:
 	src/tests/usr.bin/grep: t_grep.sh

 Log Message:
 PR/47825: Garrett Cooper: Fix hardcoding of NetBSD in t_grep.sh


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/usr.bin/grep/t_grep.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Wed, 07 Aug 2013 23:05:02 +0000
State-Changed-Why:
christos committed this patch back in May.  Thanks!



>Unformatted:

Home	PR Database Search