NetBSD Problem Report #47836

From www@NetBSD.org  Sun May 19 11:19:23 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 4757263C77F
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 19 May 2013 11:19:23 +0000 (UTC)
Message-Id: <20130519111922.7EB9263C77F@www.NetBSD.org>
Date: Sun, 19 May 2013 11:19:22 +0000 (UTC)
From: bbartlomiej@gmail.com
Reply-To: bbartlomiej@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Patch for lldpd to support options framework and xml option. Some cleaning up.
X-Send-Pr-Version: www-1.0

>Number:         47836
>Category:       pkg
>Synopsis:       Patch for lldpd to support options framework and xml option. Some cleaning up.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun May 19 11:20:01 +0000 2013
>Originator:     Bartek Krawczyk
>Release:        6.1_RC4
>Organization:
>Environment:
NetBSD test.krawczyk.it 6.1_RC4 NetBSD 6.1_RC4 (XEN3_DOMU) amd64
>Description:
Please find attached a patch for lately imported lldpd package. It adds options support and initial "xml" option. It also cleans some things with user and group.
It's my first patch so please review it.


>How-To-Repeat:

>Fix:
@@ -22,8 +22,10 @@
 CONFIGURE_ARGS+=	--with-privsep-chroot=${PKG_HOME._lldpd}

 RCD_SCRIPTS=		lldpd
-PKG_GROUPS=		_lldpd
-PKG_USERS=		_lldpd:_lldpd
+LLDPD_USER?=	_lldpd
+LLDPD_GROUP?=	_lldpd
+PKG_GROUPS=		${LLDPD_GROUP}
+PKG_USERS=		${LLDPD_USER}:${LLDPD_GROUP}
 PKG_HOME._lldpd=	${VARBASE}/chroot/lldpd

 OWN_DIRS=		${VARBASE}/chroot/lldpd
@@ -31,6 +33,8 @@

 INSTALLATION_DIRS+=	sbin ${PKGMANDIR}/man5 ${PKGMANDIR}/man8

+.include "options.mk"
+
 BUILDLINK_API_DEPENDS.libevent+=	libevent>=2.0.5
 .include "../../devel/libevent/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk







--- empty	2013-05-19 12:47:18.000000000 +0200
+++ options.mk	2013-05-19 12:44:38.000000000 +0200
@@ -0,0 +1,9 @@
+PKG_OPTIONS_VAR=	PKG_OPTIONS.lldpd
+PKG_SUPPORTED_OPTIONS=	xml
+PKG_SUGGESTED_OPTIONS=
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mxml)
+.	include "../../textproc/libxml2/buildlink3.mk"
+CONFIGURE_ARGS+=	--with-xml
+.endif

Home	PR Database Search