NetBSD Problem Report #47837

From www@NetBSD.org  Sun May 19 14:14:13 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	by www.NetBSD.org (Postfix) with ESMTP id 1033A63ECD7
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 19 May 2013 14:14:13 +0000 (UTC)
Message-Id: <20130519141412.6771063ECD7@www.NetBSD.org>
Date: Sun, 19 May 2013 14:14:12 +0000 (UTC)
From: gal.sagie@gmail.com
Reply-To: gal.sagie@gmail.com
To: gnats-bugs@NetBSD.org
Subject: need to initilize return value (rv) argument
X-Send-Pr-Version: www-1.0

>Number:         47837
>Category:       lib
>Synopsis:       need to initilize return value (rv) argument
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pooka
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 19 14:15:00 +0000 2013
>Closed-Date:    Mon May 20 10:25:18 +0000 2013
>Last-Modified:  Mon May 20 10:35:02 +0000 2013
>Originator:     Gal Sagie
>Release:        Ubuntu 12.04 LTS
>Organization:
>Environment:
Linux digipen 3.5.0-30-generic #51~precise1-Ubuntu SMP Wed May 15 08:48:19 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
>Description:
in file /sys/rump/net/lib/libvirtif/runcomp_user.c
 in rumpcomp_virtif_create(int devnum, struct virtif_user **viup)
need to change " int rv"  => to "int rv = 0" in order to init rv at start

>How-To-Repeat:
run from examples folder => webbrowser.c (the if create function should fail and return 22) (EINV)
>Fix:
Initilize rv to 0

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: port-amd64-maintainer->pooka
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Sun, 19 May 2013 15:15:08 +0000
Responsible-Changed-Why:
review?


State-Changed-From-To: open->closed
State-Changed-By: pooka@NetBSD.org
State-Changed-When: Mon, 20 May 2013 13:25:18 +0300
State-Changed-Why:
fixed. thanks!


From: "Antti Kantee" <pooka@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/47837 CVS commit: src/sys/rump/net/lib/libvirtif
Date: Mon, 20 May 2013 10:24:26 +0000

 Module Name:	src
 Committed By:	pooka
 Date:		Mon May 20 10:24:26 UTC 2013

 Modified Files:
 	src/sys/rump/net/lib/libvirtif: rumpcomp_user.c

 Log Message:
 Return 0 for success instead of returning an uninitialized automatic variable.

 from Gal Sagie, PR 47837


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 src/sys/rump/net/lib/libvirtif/rumpcomp_user.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search