NetBSD Problem Report #48075

From www@NetBSD.org  Tue Jul 23 07:34:24 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D1C55705FC
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 23 Jul 2013 07:34:23 +0000 (UTC)
Message-Id: <20130723073422.947AE70911@mollari.NetBSD.org>
Date: Tue, 23 Jul 2013 07:34:22 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: compilation of devel/gtexinfo fails
X-Send-Pr-Version: www-1.0

>Number:         48075
>Category:       pkg
>Synopsis:       compilation of devel/gtexinfo fails
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 23 07:35:00 +0000 2013
>Last-Modified:  Thu Jul 17 13:00:00 +0000 2014
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
Compilation of devel/gtexinfo fails with

--- texi2dvi.1 ---
unset TEXI2DVI_BUILD_MODE; unset TEXI2DVI_BUILD_DIRECTORY; /usr/pkgsrc/20130422/bin/pdksh /pkgsrc/source/pkgsrc/devel/gtexinfo/work.pkgsrc-i86/texinfo-5.1/build-aux/missing help2man  --name="convert Texinfo documents to DVI or PDF"  ../util/texi2dvi >texi2dvi.1
help2man: can't get `--help' info from ../util/texi2dvi
Try `--no-discard-stderr' if option outputs to stderr
*** [texi2dvi.1] Error code 1


Running "texi2dvi --help" yields:

$ ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi[1979]: no closing quote

The shell script is 1978 lines long. Maybe this is closer to the real error:

$ bash ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi: line 1106: syntax error near unexpected token `'

A second run of the build and installation succeeds, although with a zero bytes sized man1/texi2dvi.1.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/48075: compilation of devel/gtexinfo fails
Date: Tue, 23 Jul 2013 10:44:48 +0200

 On Tue, Jul 23, 2013 at 07:35:00AM +0000, joern.clausen@uni-bielefeld.de wrote:
 > >Number:         48075
 > >Category:       pkg
 > >Synopsis:       compilation of devel/gtexinfo fails
 > >Confidential:   no
 > >Severity:       serious
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Tue Jul 23 07:35:00 +0000 2013
 > >Originator:     Jörn Clausen
 > >Release:        
 > >Organization:
 > University of Bielefeld
 > >Environment:
 > >Description:
 > Compilation of devel/gtexinfo fails with
 > 
 > --- texi2dvi.1 ---
 > unset TEXI2DVI_BUILD_MODE; unset TEXI2DVI_BUILD_DIRECTORY; /usr/pkgsrc/20130422/bin/pdksh /pkgsrc/source/pkgsrc/devel/gtexinfo/work.pkgsrc-i86/texinfo-5.1/build-aux/missing help2man  --name="convert Texinfo documents to DVI or PDF"  ../util/texi2dvi >texi2dvi.1
 > help2man: can't get `--help' info from ../util/texi2dvi
 > Try `--no-discard-stderr' if option outputs to stderr
 > *** [texi2dvi.1] Error code 1
 > 
 > 
 > Running "texi2dvi --help" yields:
 > 
 > $ ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
 > ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi[1979]: no closing quote
 > 
 > The shell script is 1978 lines long. Maybe this is closer to the real error:
 > 
 > $ bash ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
 > ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi: line 1106: syntax error near unexpected token `'

 I don't see this, and I don't see anything wrong around line 1106.

 The pkgsrc patch for this file only comments out 4 lines.
 You can try removing it to check if it changes anything.
 If it doesn't, please report this upstream.

 Also, the script itself says it should be run with --debug when
 reporting bugs.
  Thomas

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Thomas Klausner <wiz@NetBSD.org>, pkg-manager@NetBSD.org,
 gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/48075: compilation of devel/gtexinfo fails
Date: Tue, 23 Jul 2013 11:58:13 +0200

 On 23.07.13 10:45, Thomas Klausner wrote:
 >   >  Running "texi2dvi --help" yields:
 >   >
 >   >  $ ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
 >   >  ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi[1979]: no closing quote
 >   >
 >   >  The shell script is 1978 lines long. Maybe this is closer to the real error:
 >   >
 >   >  $ bash ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi --help
 >   >  ./work.pkgsrc-i86/texinfo-5.1/util/texi2dvi: line 1106: syntax error near unexpected token `'
 >
 >   I don't see this, and I don't see anything wrong around line 1106.

 It probably triggers a bug in pdksh and bash. /bin/sh on Solaris 10 does 
 not have any problems with the script either. So upstream of texinfo is 
 the wrong tree to bark up...

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 23 Jul 2013 11:10:43 +0000
Responsible-Changed-Why:
Problem with a shell on Solaris.


From: Tim Zingelman <zingelman@gmail.com>
To: NetBSD bugtracking <gnats-bugs@netbsd.org>
Cc: solaris-pkg-people@netbsd.org, pkg-manager@netbsd.org, 
	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	Thomas Klausner <wiz@netbsd.org>, =?ISO-8859-1?Q?J=F6rn_C=2E?= <joern.clausen@uni-bielefeld.de>, 
	Amitai Schlair <schmonz@netbsd.org>
Subject: Re: pkg/48075 (compilation of devel/gtexinfo fails)
Date: Fri, 3 Jan 2014 15:53:48 -0600

 I have tracked this down to where adding a single space to the script
 works around the bug in pdksh that this is triggering (or fixes the
 bad syntax that sh & ksh accept)

 I just tried this on a NetBSD 5.1 i386 machine, and if you set:
 TOOLS_PLATFORM.sh?=             /usr/pkg/bin/pdksh
 TOOLS_PLATFORM.ksh?=            /usr/pkg/bin/pdksh
 (or just edit the texti2dvi script to use /usr/pkg/bin/pdksh) the same
 problem occurs.

 Editing the texi2dvi and adding a single space as shown in this diff
 makes pdksh work:

 --- texi2dvi.saved      Fri Jan  3 15:00:27 2014
 +++ texi2dvi    Fri Jan  3 15:29:17 2014
 @@ -1103,7 +1103,7 @@
    # bibtex would never be run.
    if test -r "$in_noext.aux" \
       && test -r "$in_noext.log" \
 -     && ((grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
 +     && ( (grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
            || grep '.*Undefined citation' "$in_noext.log" \
            || grep 'No file .*\.bbl\.' "$in_noext.log") \
            || (grep 'No \.aux file' "$in_noext.log" \


 I think this should be re-assigned to the maintainer of pdksh.
 Perhaps meanwhile the line:

 REPLACE_SH+=            util/texi2dvi

 should be conditionalized to avoid this issue at least on SunOS.

  - Tim

From: Richard PALO <richard.palo@free.fr>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/48075 (compilation of devel/gtexinfo fails)
Date: Tue, 15 Apr 2014 07:41:54 +0200

 Le 03/01/14 22:55, Tim Zingelman a écrit :
 > The following reply was made to PR pkg/48075; it has been noted by GNATS.
 >
 > From: Tim Zingelman <zingelman@gmail.com>
 > To: NetBSD bugtracking <gnats-bugs@netbsd.org>
 > Cc: solaris-pkg-people@netbsd.org, pkg-manager@netbsd.org,
 > 	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org,
 > 	Thomas Klausner <wiz@netbsd.org>, =?ISO-8859-1?Q?J=F6rn_C=2E?= <joern.clausen@uni-bielefeld.de>,
 > 	Amitai Schlair <schmonz@netbsd.org>
 > Subject: Re: pkg/48075 (compilation of devel/gtexinfo fails)
 > Date: Fri, 3 Jan 2014 15:53:48 -0600
 >
 >   I have tracked this down to where adding a single space to the script
 >   works around the bug in pdksh that this is triggering (or fixes the
 >   bad syntax that sh & ksh accept)
 >
 >   I just tried this on a NetBSD 5.1 i386 machine, and if you set:
 >   TOOLS_PLATFORM.sh?=             /usr/pkg/bin/pdksh
 >   TOOLS_PLATFORM.ksh?=            /usr/pkg/bin/pdksh
 >   (or just edit the texti2dvi script to use /usr/pkg/bin/pdksh) the same
 >   problem occurs.
 >
 >   Editing the texi2dvi and adding a single space as shown in this diff
 >   makes pdksh work:
 >
 >   --- texi2dvi.saved      Fri Jan  3 15:00:27 2014
 >   +++ texi2dvi    Fri Jan  3 15:29:17 2014
 >   @@ -1103,7 +1103,7 @@
 >      # bibtex would never be run.
 >      if test -r "$in_noext.aux" \
 >         && test -r "$in_noext.log" \
 >   -     && ((grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
 >   +     && ( (grep 'Warning:.*Citation.*undefined' "$in_noext.log" \
 >              || grep '.*Undefined citation' "$in_noext.log" \
 >              || grep 'No file .*\.bbl\.' "$in_noext.log") \
 >              || (grep 'No \.aux file' "$in_noext.log" \
 >
 >
 >   I think this should be re-assigned to the maintainer of pdksh.
 >   Perhaps meanwhile the line:
 >
 >   REPLACE_SH+=            util/texi2dvi
 >
 >   should be conditionalized to avoid this issue at least on SunOS.
 >
 >    - Tim
 >
 >
 The suggestion to patch texi2dvi has been committed in pkgsrc-current 
 and upstream as well.  A 'feature' request for pdksh will be made to 
 implement a workaround such as bash and recent ast-ksh seem to have done.

From: "Ryo ONODERA" <ryoon@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48075 CVS commit: pkgsrc/devel/gtexinfo
Date: Thu, 17 Jul 2014 12:56:23 +0000

 Module Name:	pkgsrc
 Committed By:	ryoon
 Date:		Thu Jul 17 12:56:23 UTC 2014

 Modified Files:
 	pkgsrc/devel/gtexinfo: distinfo
 	pkgsrc/devel/gtexinfo/patches: patch-util_texi2dvi

 Log Message:
 Update comment for PR pkg/48075.


 To generate a diff of this commit:
 cvs rdiff -u -r1.40 -r1.41 pkgsrc/devel/gtexinfo/distinfo
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/devel/gtexinfo/patches/patch-util_texi2dvi

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.