NetBSD Problem Report #48207

From www@NetBSD.org  Wed Sep 11 14:26:11 2013
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 92FE5715CA
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 11 Sep 2013 14:26:11 +0000 (UTC)
Message-Id: <20130911142609.9ABCC72013@mollari.NetBSD.org>
Date: Wed, 11 Sep 2013 14:26:09 +0000 (UTC)
From: jmartin@basho.com
Reply-To: jmartin@basho.com
To: gnats-bugs@NetBSD.org
Subject: pkg_info segfaults when querying a package file
X-Send-Pr-Version: www-1.0

>Number:         48207
>Category:       pkg
>Synopsis:       pkg_info segfaults when querying a package file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 11 14:30:01 +0000 2013
>Closed-Date:    Thu Sep 12 07:28:56 +0000 2013
>Last-Modified:  Thu Sep 12 07:30:00 +0000 2013
>Originator:     James Martin
>Release:        SmartOS
>Organization:
Basho
>Environment:
SunOS smartos-base1310-64 5.11 joyent_20130725T202435Z i86pc i386 i86pc Solaris
>Description:
pkg_info it is throwing a segfault with one of our packages.

[root@smartos-base1310-64 /vagrant]# pkg_info -X riak_cs-1.4.1-SmartOS-x86_64.tgz
PKGNAME=riak_cs-1.4.1
CONFLICTS=riak_cs-*
DEPENDS=sudo-[0-9]*
DEPENDS=openssl-1.0.1*
DEPENDS=ncurses-5*
DEPENDS=gcc47-libs>=4.7.0
COMMENT=Riak CS
MACHINE_ARCH=x86_64
OPSYS=SunOS
OS_VERSION=5.11
PKGTOOLS_VERSION=20091115
Segmentation Fault (core dumped)


truss output shows:

truss pkg_info -X /vagrant/riak-1.4.2-SmartOS-x86_64.tgz 
execve("/opt/local/sbin/pkg_info", 0xFFFFFD7FFFDFFCB8, 0xFFFFFD7FFFDFFCD8)  argc = 3
sysinfo(SI_MACHINE, "i86pc", 257)               = 6
mmap(0x00000000, 56, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF390000
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF380000
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF370000
memcntl(0xFFFFFD7FFF398000, 93928, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF360000
memcntl(0x00400000, 110960, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
resolvepath("/usr/lib/amd64/ld.so.1", "/lib/amd64/ld.so.1", 1023) = 18
resolvepath("/opt/local/sbin/pkg_info", "/opt/local/sbin/pkg_info", 1023) = 24
stat("/opt/local/sbin/pkg_info", 0xFFFFFD7FFFDFF990) = 0
open("/var/ld/64/ld.config", O_RDONLY)          Err#2 ENOENT
stat("/opt/pbulk-2013Q2/gcc47/x86_64-sun-solaris2.11/lib/amd64/libsocket.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/pbulk-2013Q2/gcc47/lib/amd64/libsocket.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/local/lib/libsocket.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/lib/64/libsocket.so.1", 0xFFFFFD7FFFDFF080) = 0
resolvepath("/lib/64/libsocket.so.1", "/lib/amd64/libsocket.so.1", 1023) = 25
open("/lib/64/libsocket.so.1", O_RDONLY)        = 3
mmapobj(3, MMOBJ_INTERPRET, 0xFFFFFD7FFF360D08, 0xFFFFFD7FFFDFEBDC, 0x00000000) = 0
close(3)                                        = 0
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF350000
memcntl(0xFFFFFD7FFEA40000, 30912, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
stat("/opt/pbulk-2013Q2/gcc47/x86_64-sun-solaris2.11/lib/amd64/libnsl.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/pbulk-2013Q2/gcc47/lib/amd64/libnsl.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/local/lib/libnsl.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/lib/64/libnsl.so.1", 0xFFFFFD7FFFDFF080) = 0
resolvepath("/lib/64/libnsl.so.1", "/lib/amd64/libnsl.so.1", 1023) = 22
open("/lib/64/libnsl.so.1", O_RDONLY)           = 3
mmapobj(3, MMOBJ_INTERPRET, 0xFFFFFD7FFF350B28, 0xFFFFFD7FFFDFEBDC, 0x00000000) = 0
close(3)                                        = 0
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF340000
memcntl(0xFFFFFD7FFED10000, 170992, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
stat("/opt/pbulk-2013Q2/gcc47/x86_64-sun-solaris2.11/lib/amd64/libc.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/pbulk-2013Q2/gcc47/lib/amd64/libc.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/opt/local/lib/libc.so.1", 0xFFFFFD7FFFDFF080) Err#2 ENOENT
stat("/lib/64/libc.so.1", 0xFFFFFD7FFFDFF080)   = 0
resolvepath("/lib/64/libc.so.1", "/lib/amd64/libc.so.1", 1023) = 20
open("/lib/64/libc.so.1", O_RDONLY)             = 3
mmapobj(3, MMOBJ_INTERPRET, 0xFFFFFD7FFF340A88, 0xFFFFFD7FFFDFEBDC, 0x00000000) = 0
close(3)                                        = 0
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF1A0000
memcntl(0xFFFFFD7FFF1B0000, 447208, MC_ADVISE, MADV_WILLNEED, 0, 0) = 0
mmap(0x00000000, 4096, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 4294967295, 0) = 0xFFFFFD7FFF190000
mmap(0x00010000, 24576, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON|MAP_ALIGN, -1, 0) = 0xFFFFFD7FFF180000
getcontext(0xFFFFFD7FFFDFF3E0)
getrlimit(RLIMIT_STACK, 0xFFFFFD7FFFDFF740)     = 0
getpid()                                        = 47307 [47306]
lwp_private(0, 0, 0xFFFFFD7FFF182A40)           = 0x00000000
setustack(0xFFFFFD7FFF182AE8)
sigfillset(0xFFFFFD7FFF33DE60)                  = 0
sysi86(SI86FPSTART, 0xFFFFFD7FFFDFFC6C, 0x0000133F, 0x00001F80) = 0x00000001
open("/opt/local/etc/pkg_install.conf", O_RDONLY) = 3
brk(0x00480950)                                 = 0
brk(0x00484950)                                 = 0
fstat(3, 0xFFFFFD7FFFDFFA30)                    = 0
fstat(3, 0xFFFFFD7FFFDFF960)                    = 0
ioctl(3, TCGETA, 0xFFFFFD7FFFDFF9E0)            Err#25 ENOTTY
read(3, " P K G _ P A T H = h t t".., 512)      = 69
read(3, 0x00480D74, 512)                        = 0
lseek(3, 0, SEEK_CUR)                           = 69
close(3)                                        = 0
brk(0x00484950)                                 = 0
brk(0x00488950)                                 = 0
lstat("/vagrant/riak-1.4.2-SmartOS-x86_64.tgz", 0xFFFFFD7FFFDFF6F0) = 0
stat("/vagrant/riak-1.4.2-SmartOS-x86_64.tgz", 0xFFFFFD7FFFDFF6F0) = 0
brk(0x00488950)                                 = 0
brk(0x0048C950)                                 = 0
open("/vagrant/riak-1.4.2-SmartOS-x86_64.tgz", O_RDONLY) = 3
fstat(3, 0xFFFFFD7FFFDFF690)                    = 0
read(3, "1F8B\b\b8BB51F R\003 r i".., 1024)     = 1024
brk(0x0048C950)                                 = 0
brk(0x0049C950)                                 = 0
brk(0x0049C950)                                 = 0
brk(0x004A4950)                                 = 0
read(3, "AECDEEE8 \C0 x989099 vA3".., 1024)     = 1024
read(3, " 3E6D3FC $ d80 > GA7 {E2".., 1024)     = 1024
read(3, " jB07FBAF811CAAA99E5 Y\f".., 1024)     = 1024
read(3, " r86\rFB ( - ]02 " Z8A98".., 1024)     = 1024
read(3, " rA506 xC5 V ;DBA9DF81FA".., 1024)     = 1024
read(3, "0102 BDA L OBD NF99D O D".., 1024)     = 1024
read(3, " 4A916 n ? Z16C1 ! hF1 X".., 1024)     = 1024
read(3, " -13 H fDE809BADA9A5 913".., 1024)     = 1024
brk(0x004A4950)                                 = 0
brk(0x004C0950)                                 = 0
read(3, "02E4C0 & hB7E997 PD20518".., 1024)     = 1024
read(3, "EAD4 D ;CF &DD L F1DE9C5".., 1024)     = 1024
read(3, " p109F97D6 FD9E6A7E5D795".., 1024)     = 1024
read(3, " t80DC97E6A4 C h XE4 HD3".., 1024)     = 1024
read(3, " 6F4A6C0CB :1A k !C419 Z".., 1024)     = 1024
read(3, " TA4 _DA 9BAB6 :C5 r BC2".., 1024)     = 1024
read(3, " v !91 JBA ^ s \D2 lFA R".., 1024)     = 1024
read(3, "BAF1BC999F m _ s y8EE385".., 1024)     = 1024
read(3, " /BCE31C ~7FFBAFC7DFF5 m".., 1024)     = 1024
read(3, " + ( - ;B6BDF592CE1F oBA".., 1024)     = 1024
read(3, "CDD0F5 } & MEEF5EC , Q P".., 1024)     = 1024
read(3, "C2DDF997F4D7900EF5 eD7 m".., 1024)     = 1024
read(3, "\b .F9E9C6839BCB J8E0EDB".., 1024)     = 1024
read(3, "E8F8FB = U86E1 {86DFA9 9".., 1024)     = 1024
read(3, "C5D4A8A8 R1CA893DB849FFF".., 1024)     = 1024
read(3, "1C rA6 -8CDBC398F1 qA1 1".., 1024)     = 1024
close(3)                                        = 0
brk(0x004C0950)                                 = 0
brk(0x004C4950)                                 = 0
brk(0x004C4950)                                 = 0
brk(0x004C8950)                                 = 0
brk(0x004C8950)                                 = 0
brk(0x004CC950)                                 = 0
brk(0x004CC950)                                 = 0
brk(0x004D0950)                                 = 0
brk(0x004D0950)                                 = 0
brk(0x004D4950)                                 = 0
brk(0x004D4950)                                 = 0
brk(0x004D8950)                                 = 0
brk(0x004D8950)                                 = 0
brk(0x004DC950)                                 = 0
brk(0x004DC950)                                 = 0
brk(0x004E0950)                                 = 0
ioctl(1, TCGETA, 0xFFFFFD7FFFDFE360)            = 0
fstat(1, 0xFFFFFD7FFFDFE2E0)                    = 0
PKGNAME=riak-1.4.2
write(1, " P K G N A M E = r i a k".., 19)      = 19
CONFLICTS=riak-*
write(1, " C O N F L I C T S = r i".., 17)      = 17
DEPENDS=sudo-[0-9]*
write(1, " D E P E N D S = s u d o".., 20)      = 20
DEPENDS=openssl-1.0.1*
write(1, " D E P E N D S = o p e n".., 23)      = 23
DEPENDS=ncurses-5*
write(1, " D E P E N D S = n c u r".., 19)      = 19
DEPENDS=gcc47-libs>=4.7.0
write(1, " D E P E N D S = g c c 4".., 26)      = 26
COMMENT=Riak is a distributed data store
write(1, " C O M M E N T = R i a k".., 41)      = 41
MACHINE_ARCH=x86_64
write(1, " M A C H I N E _ A R C H".., 20)      = 20
OPSYS=SunOS
write(1, " O P S Y S = S u n O S\n", 12)        = 12
OS_VERSION=5.11
write(1, " O S _ V E R S I O N = 5".., 16)      = 16
PKGTOOLS_VERSION=20091115
write(1, " P K G T O O L S _ V E R".., 26)      = 26
    Incurred fault #6, FLTBOUNDS  %pc = 0x00420E48
      siginfo: SIGSEGV SEGV_MAPERR addr=0x00000000
    Received signal #11, SIGSEGV [default]
      siginfo: SIGSEGV SEGV_MAPERR addr=0x00000000


>How-To-Repeat:
Download package from:

http://s3.amazonaws.com/downloads.basho.com/riak/1.4/1.4.2/smartos/13.1/riak-1.4.2-SmartOS-x86_64.tgz

run:

pkg_info -X riak-1.4.2-SmartOS-x86_64.tgz
>Fix:

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
Date: Wed, 11 Sep 2013 17:24:16 +0200

 On Wed, Sep 11, 2013 at 02:30:01PM +0000, jmartin@basho.com wrote:
 > pkg_info it is throwing a segfault with one of our packages.
 > 
 > [root@smartos-base1310-64 /vagrant]# pkg_info -X riak_cs-1.4.1-SmartOS-x86_64.tgz
 > PKGNAME=riak_cs-1.4.1
 > CONFLICTS=riak_cs-*
 > DEPENDS=sudo-[0-9]*
 > DEPENDS=openssl-1.0.1*
 > DEPENDS=ncurses-5*
 > DEPENDS=gcc47-libs>=4.7.0
 > COMMENT=Riak CS
 > MACHINE_ARCH=x86_64
 > OPSYS=SunOS
 > OS_VERSION=5.11
 > PKGTOOLS_VERSION=20091115
 > Segmentation Fault (core dumped)

 How did you create the package?

 There is no trailing '\n' after "PKGTOOLS_VERSION=20091115", which is
 probably the reason of the coredump.

   meta_build_info = 0x7f7ff7b51100 "ABI=64\nMACHINE_ARCH=x86_64\nMACHINE_GNU_ARCH=x86_64\nOBJECT_FMT=ELF\nOPSYS=SunOS\nOS_VERSION=5.11\nPKGTOOLS_VERSION=20091115",

 I agree that this should not cause a coredump, but I'd like to know
 how this came to be.

 Cheers,
  Thomas

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
Date: Wed, 11 Sep 2013 17:33:11 +0200

 --HcAYCG3uE/tztfnV
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Wed, Sep 11, 2013 at 03:25:00PM +0000, Thomas Klausner wrote:
 > The following reply was made to PR pkg/48207; it has been noted by GNATS.
 > 
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc: 
 > Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
 > Date: Wed, 11 Sep 2013 17:24:16 +0200
 > 
 >  On Wed, Sep 11, 2013 at 02:30:01PM +0000, jmartin@basho.com wrote:
 >  > pkg_info it is throwing a segfault with one of our packages.
 >  > 
 >  > [root@smartos-base1310-64 /vagrant]# pkg_info -X riak_cs-1.4.1-SmartOS-x86_64.tgz
 >  > PKGNAME=riak_cs-1.4.1
 >  > CONFLICTS=riak_cs-*
 >  > DEPENDS=sudo-[0-9]*
 >  > DEPENDS=openssl-1.0.1*
 >  > DEPENDS=ncurses-5*
 >  > DEPENDS=gcc47-libs>=4.7.0
 >  > COMMENT=Riak CS
 >  > MACHINE_ARCH=x86_64
 >  > OPSYS=SunOS
 >  > OS_VERSION=5.11
 >  > PKGTOOLS_VERSION=20091115
 >  > Segmentation Fault (core dumped)
 >  
 >  How did you create the package?
 >  
 >  There is no trailing '\n' after "PKGTOOLS_VERSION=20091115", which is
 >  probably the reason of the coredump.
 >  
 >    meta_build_info = 0x7f7ff7b51100 "ABI=64\nMACHINE_ARCH=x86_64\nMACHINE_GNU_ARCH=x86_64\nOBJECT_FMT=ELF\nOPSYS=SunOS\nOS_VERSION=5.11\nPKGTOOLS_VERSION=20091115",
 >  
 >  I agree that this should not cause a coredump, but I'd like to know
 >  how this came to be.

 Here's a diff that fixes the segfault for me.
  Thomas

 --HcAYCG3uE/tztfnV
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="pkg_install.diff"

 Index: files/lib/var.c
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/var.c,v
 retrieving revision 1.9
 diff -u -r1.9 var.c
 --- files/lib/var.c	17 May 2013 07:27:29 -0000	1.9
 +++ files/lib/var.c	11 Sep 2013 15:32:35 -0000
 @@ -60,7 +60,7 @@
  static void var_print(FILE *, const char *, const char *);

  /*
 - * Copy the specified varibales from the file fname to stdout.
 + * Copy the specified variables from the file fname to stdout.
   */
  int
  var_copy_list(const char *buf, const char **variables)
 @@ -69,7 +69,7 @@
  	size_t len;
  	int i;

 -	for (; *buf; buf = next) {
 +	for (; buf && *buf; buf = next) {
  		if ((eol = strchr(buf, '\n')) != NULL) {
  			next = eol + 1;
  			len = eol - buf;

 --HcAYCG3uE/tztfnV--

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
Date: Wed, 11 Sep 2013 18:43:59 +0200

 On Wed, Sep 11, 2013 at 03:35:00PM +0000, Thomas Klausner wrote:
 >  Here's a diff that fixes the segfault for me.

 Don't like it. In the else part, it should be

 	len = strlen(buf);
 	next = buf + len;

 Joerg

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
Date: Wed, 11 Sep 2013 23:30:47 +0200

 --ZPt4rx8FFjLCG7dd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On Wed, Sep 11, 2013 at 04:45:01PM +0000, Joerg Sonnenberger wrote:
 >  Don't like it. In the else part, it should be
 >  
 >  	len = strlen(buf);
 >  	next = buf + len;

 Sure, that works for me too.
  Thomas

 --ZPt4rx8FFjLCG7dd
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="pkg_install.diff"

 Index: files/lib/var.c
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/var.c,v
 retrieving revision 1.9
 diff -u -r1.9 var.c
 --- files/lib/var.c	17 May 2013 07:27:29 -0000	1.9
 +++ files/lib/var.c	11 Sep 2013 21:30:25 -0000
 @@ -60,7 +60,7 @@
  static void var_print(FILE *, const char *, const char *);

  /*
 - * Copy the specified varibales from the file fname to stdout.
 + * Copy the specified variables from the file fname to stdout.
   */
  int
  var_copy_list(const char *buf, const char **variables)
 @@ -74,8 +74,8 @@
  			next = eol + 1;
  			len = eol - buf;
  		} else {
 -			next = eol;
  			len = strlen(buf);
 +			next = buf + len;
  		}

  		for (i=0; variables[i]; i++) {

 --ZPt4rx8FFjLCG7dd--

From: James Martin <jmartin@basho.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
Date: Wed, 11 Sep 2013 18:38:33 -0400

 Adding the extra '\n' did the trick.  I'm not the package maintainer,
 so I can't speak in any depth on how we build the packages.  We do use
 a homegrown tool called node_package for building packages for all of
 our supported platforms.  The +BUILD_INFO file seems to be referenced
 there, https://github.com/basho/node_package/blob/develop/priv/templates/smartos/%2BBUILD_INFO.

 I will pass this bug on to him and let him comment.  Thanks for
 looking this over and quick response!

 On Wed, Sep 11, 2013 at 5:35 PM, Thomas Klausner <wiz@netbsd.org> wrote:
 > The following reply was made to PR pkg/48207; it has been noted by GNATS.
 >
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc:
 > Subject: Re: pkg/48207: pkg_info segfaults when querying a package file
 > Date: Wed, 11 Sep 2013 23:30:47 +0200
 >
 >  --ZPt4rx8FFjLCG7dd
 >  Content-Type: text/plain; charset=us-ascii
 >  Content-Disposition: inline
 >
 >  On Wed, Sep 11, 2013 at 04:45:01PM +0000, Joerg Sonnenberger wrote:
 >  >  Don't like it. In the else part, it should be
 >  >
 >  >      len = strlen(buf);
 >  >      next = buf + len;
 >
 >  Sure, that works for me too.
 >   Thomas
 >
 >  --ZPt4rx8FFjLCG7dd
 >  Content-Type: text/plain; charset=us-ascii
 >  Content-Disposition: attachment; filename="pkg_install.diff"
 >
 >  Index: files/lib/var.c
 >  ===================================================================
 >  RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/var.c,v
 >  retrieving revision 1.9
 >  diff -u -r1.9 var.c
 >  --- files/lib/var.c    17 May 2013 07:27:29 -0000      1.9
 >  +++ files/lib/var.c    11 Sep 2013 21:30:25 -0000
 >  @@ -60,7 +60,7 @@
 >   static void var_print(FILE *, const char *, const char *);
 >
 >   /*
 >  - * Copy the specified varibales from the file fname to stdout.
 >  + * Copy the specified variables from the file fname to stdout.
 >    */
 >   int
 >   var_copy_list(const char *buf, const char **variables)
 >  @@ -74,8 +74,8 @@
 >                         next = eol + 1;
 >                         len = eol - buf;
 >                 } else {
 >  -                      next = eol;
 >                         len = strlen(buf);
 >  +                      next = buf + len;
 >                 }
 >
 >                 for (i=0; variables[i]; i++) {
 >
 >  --ZPt4rx8FFjLCG7dd--
 >

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Thu, 12 Sep 2013 07:28:56 +0000
State-Changed-Why:
Patch for pkg_info committed to pkgsrc. Thanks for the bug report!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48207 CVS commit: pkgsrc/pkgtools/pkg_install/files/lib
Date: Thu, 12 Sep 2013 07:28:28 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Thu Sep 12 07:28:28 UTC 2013

 Modified Files:
 	pkgsrc/pkgtools/pkg_install/files/lib: var.c

 Log Message:
 Fix pkg_info -X segfault when last entry wasn't terminated with \n.
 Addresses PR 48207.


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/pkgtools/pkg_install/files/lib/var.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.