NetBSD Problem Report #48254

From iamleot@gmail.com  Mon Sep 30 18:24:12 2013
Return-Path: <iamleot@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0F845725AF
	for <gnats-bugs@gnats.netbsd.org>; Mon, 30 Sep 2013 18:24:12 +0000 (UTC)
Message-Id: <5249c1c7.08730e0a.3864.fffff28d@mx.google.com>
Date: Mon, 30 Sep 2013 11:24:07 -0700 (PDT)
From: Leonardo Taccari <iamleot@gmail.com>
Reply-To: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@gnats.NetBSD.org
Subject: Update mail/fdm to 1.7
X-Send-Pr-Version: 3.95

>Number:         48254
>Category:       pkg
>Synopsis:       Update mail/fdm to 1.7
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 30 18:25:00 +0000 2013
>Closed-Date:    Thu Oct 03 11:13:32 +0000 2013
>Last-Modified:  Sun Oct 13 21:40:00 +0000 2013
>Originator:     Leonardo Taccari
>Release:        NetBSD 6.1.2
>Organization:
>Environment:
System: NetBSD :) 6.1.2 NetBSD 6.1.2 (EEEPC900) #0: Mon Sep 30 15:26:39 CEST 2013 leot@:):/usr/src/sys/arch/i386/compile/EEEPC900 i386
Architecture: i386
Machine: i386
>Description:
	mail/fdm in pkgsrc (1.6) is not the latest stable version (1.7).
>How-To-Repeat:
	$ cd pkgsrc/mail/fdm
	$ make show-var VARNAME=DISTNAME
>Fix:
	Please apply the attached patches.

	I tried to improve the package in various ways:
	 * Properly use the SUBST framework (and get rid of patches/patch-aa)
	 * options.mk: fdm can be built with "debug" and "pcre" options
	   (previously the user was not able to disable the PCRE support)
	 * MANUAL is now generated via an awk(1) script. Add a line to
	   post-install target accordingly.
	 * Add HAS_CONFIGURE. Now fdm use a "configure" that automatically
	   generate a config.h and config.mk (depending on ``uname -s''). If an OS
	   is not supported adding it to ${WRKSRC}/configure is the first thing to
	   do.
	 * Add a comment to patches/patch-fdm.h
	 * Various cosmetic changes to Makefile (inspired by
	   pkgsrc/doc/Makefile-example, please email me regarding any mistakes
	   that I've done!)

	While there I will also attach a possible commit message.
	Thank you in advance!


-------------------8<-----------------8<-----------------8<-------------------
Update mail/fdm to fdm-1.7

pkgsrc changes:
 * add options.mk: now fdm supports "debug" and "pcre" options (previously the
   PCRE support was always included).

Changes:
 * Add mbox tags for messages fetched from a mbox
 * Detect GMail's XYZZY capability for IMAP and use it to try and workaround
   some of their broken behaviour (incorrectly reported message sizes).
 * Print a warning on missing maildirs when fetching from them rather than
   crashing or giving an error. Reported by Frank Terbeck.
 * Introduce a configure script and tidy up build infrastructure.
 * GMail IMAP doesn't correctly set the \Seen flag after UID FETCH BODY[], so
   explicitly set it with STORE when mail is kept. Reported by Patrice Clement.
 * Properly count mails when polling multiple folders on a single IMAP server,
   reported by Claudio M. Alessi.
 * Support user and pass on NNTP, requested by Michael Hamann.
 * Escape . properly when delivering to SMTP.
 * Don't be as strict about format at the end of messages when using IMAP -
   accept additional information as well as FLAGS. Reported by rivo nurges.
-------------------8<-----------------8<-----------------8<-------------------


-------------------8<-----------------8<-----------------8<-------------------
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/mail/fdm/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	6 Feb 2013 23:22:44 -0000	1.4
+++ Makefile	30 Sep 2013 17:48:51 -0000
@@ -1,9 +1,7 @@
 # $NetBSD: Makefile,v 1.4 2013/02/06 23:22:44 jperkin Exp $

-DISTNAME=		fdm-1.6
-PKGREVISION=		1
+DISTNAME=		fdm-1.7
 CATEGORIES=		mail
-PKG_REVISION=		1
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=fdm/}

 MAINTAINER=		pkgsrc-users@NetBSD.org
@@ -11,27 +9,30 @@
 COMMENT=		Fetch or receive mail and deliver it in various ways
 LICENSE=		modified-bsd

-INSTALLATION_DIRS+=	${EGDIR} ${DOCDIR}
-EGDIR=			${PREFIX}/share/examples/fdm
 DOCDIR=			${PREFIX}/share/doc/fdm
+EGDIR=			${PREFIX}/share/examples/fdm
+HAS_CONFIGURE=		yes
+INSTALLATION_DIRS+=	${DOCDIR} ${EGDIR}

 USE_TOOLS+=		pax
-MAKE_ENV+=		PCRE=1

-SUBST_CLASSES+=		files
-SUBST_STAGE.files=	post-patch
-SUBST_FILES.files=	Makefile
-SUBST_SED.files=	-e "s|@INSTALL_PROGRAM_DIR@|${INSTALL_PROGRAM_DIR}|"
-SUBST_SED.files+=	-e "s|@INSTALL_PROGRAM@|${INSTALL_PROGRAM}|"
-SUBST_SED.files+=	-e "s|@INSTALL_MAN@|${INSTALL_MAN}|"
-SUBST_MESSAGE.files=	Fixing install invocation in Makefile
+SUBST_CLASSES+=		makefile
+SUBST_STAGE.makefile=	post-patch
+SUBST_MESSAGE.makefile=	Fixing install invocation in Makefile
+SUBST_FILES.makefile=	Makefile
+SUBST_SED.makefile+=	-e '/^FDEBUG=/d'	# Disable debug options
+SUBST_SED.makefile+=	-E -e 's,(INSTALLDIR=).*,\1 ${INSTALL_PROGRAM_DIR:Q},'
+SUBST_SED.makefile+=	-E -e 's,(INSTALLBIN=).*,\1 ${INSTALL_PROGRAM:Q},'
+SUBST_SED.makefile+=	-E -e 's,(INSTALLMAN=).*,\1 ${INSTALL_MAN:Q},'
+
+.include "options.mk"
+.include "../../databases/tdb/buildlink3.mk"
+.include "../../devel/zlib/buildlink3.mk"
+.include "../../security/openssl/buildlink3.mk"

 post-install:
 	cd ${WRKSRC}/examples && pax -rwpam . ${DESTDIR}${EGDIR}
+	cd ${WRKSRC} && ${MAKE_PROGRAM} -f ${WRKSRC}/tools/dist.mk manual
 	${INSTALL_DATA} ${WRKSRC}/MANUAL ${DESTDIR}${DOCDIR}

-.include "../../security/openssl/buildlink3.mk"
-.include "../../devel/zlib/buildlink3.mk"
-.include "../../devel/pcre/buildlink3.mk"
-.include "../../databases/tdb/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/mail/fdm/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- PLIST	17 Aug 2012 17:45:40 -0000	1.1.1.1
+++ PLIST	30 Sep 2013 17:48:51 -0000
@@ -1,11 +1,10 @@
-@comment $NetBSD: PLIST,v 1.1.1.1 2012/08/17 17:45:40 seb Exp $
+@comment $NetBSD$
 bin/fdm
 man/man1/fdm.1
 man/man5/fdm.conf.5
 share/doc/fdm/MANUAL
 share/examples/fdm/f-terbeck.conf
 share/examples/fdm/g-lando.conf
-share/examples/fdm/n-marriott-old.conf
 share/examples/fdm/n-marriott.conf
 share/examples/fdm/t-ulmer.conf
 share/examples/fdm/w-maier.conf
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/mail/fdm/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo	23 Aug 2012 18:04:12 -0000	1.2
+++ distinfo	30 Sep 2013 17:48:51 -0000
@@ -1,7 +1,6 @@
 $NetBSD: distinfo,v 1.2 2012/08/23 18:04:12 marino Exp $

-SHA1 (fdm-1.6.tar.gz) = fb8042f2355062848ff142c9604069b6657e6a82
-RMD160 (fdm-1.6.tar.gz) = 7e2c846b97dce20e123b8453732e107f88e0de8f
-Size (fdm-1.6.tar.gz) = 192159 bytes
-SHA1 (patch-aa) = 4284d7fc2e88fc9d42fc861e19a890dd526354d6
-SHA1 (patch-fdm.h) = 03ad0167120e06e76f4f1ef086c918c6a0cccf55
+SHA1 (fdm-1.7.tar.gz) = 5534d1ec1831794e092e0821db70f36b7e1ee961
+RMD160 (fdm-1.7.tar.gz) = 942f0989501645aa7e04bd428510daa309e8fca6
+Size (fdm-1.7.tar.gz) = 199808 bytes
+SHA1 (patch-fdm.h) = 5119757e747908a45ca778fe8d27d7944e37125f
Index: options.mk
===================================================================
RCS file: options.mk
diff -N options.mk
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ options.mk	30 Sep 2013 17:48:51 -0000
@@ -0,0 +1,22 @@
+# $NetBSD$
+
+PKG_OPTIONS_VAR=	PKG_OPTIONS.fdm
+PKG_SUPPORTED_OPTIONS=	debug pcre
+PKG_SUGGESTED_OPTIONS=	pcre
+
+.include "../../mk/bsd.options.mk"
+
+#
+# Debug
+#
+.if !empty(PKG_OPTIONS:Mdebug)
+   MAKE_ENV+=	FDEBUG=1
+.endif
+
+#
+# PCRE support
+#
+.if !empty(PKG_OPTIONS:Mpcre)
+   MAKE_ENV+=	PCRE=1
+.  include "../../devel/pcre/buildlink3.mk"
+.endif
Index: patches/patch-aa
===================================================================
RCS file: patches/patch-aa
diff -N patches/patch-aa
--- patches/patch-aa	23 Aug 2012 18:04:12 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,38 +0,0 @@
-$NetBSD: patch-aa,v 1.2 2012/08/23 18:04:12 marino Exp $
-
-cleanup cpp args dans adjust/fix Darwin build
-
---- Makefile.orig	2008-12-22 16:20:05.000000000 +0000
-+++ Makefile
-@@ -37,7 +37,7 @@ HDRS= fdm.h array.h fetch.h match.h deli
- YACC= yacc -d
- 
- CC?= cc
--INCDIRS+= -I. -I- -I/usr/local/include
-+INCDIRS+= -I. 
- .ifdef PROFILE
- # Don't use ccache
- CC= /usr/bin/gcc
-@@ -70,7 +70,8 @@ LIBS+= -lpcre
- .if ${OS} == "Darwin"
- SRCS+= compat/strtonum.c
- INCDIRS+= -Icompat -I/usr/local/include/openssl
--CFLAGS+= -DNO_STRTONUM -DNO_SETRESUID -DNO_SETRESGID -DNO_SETPROCTITLE
-+CFLAGS+= -DNO_STRTONUM -DNO_SETRESUID -DNO_SETRESGID -DNO_SETPROCTITLE -DNO_QUEUE_H -DNO_TREE_H
-+LIBS+=	-lresolv
- .endif
- 
- # NetBSD
-@@ -93,9 +94,9 @@ CFLAGS+= -DNO_STRTONUM
- .endif
- 
- PREFIX?= /usr/local
--INSTALLDIR= install -d
--INSTALLBIN= install -g bin -o root -m 555
--INSTALLMAN= install -g bin -o root -m 444
-+INSTALLDIR= @INSTALL_PROGRAM_DIR@
-+INSTALLBIN= @INSTALL_PROGRAM@
-+INSTALLMAN= @INSTALL_MAN@
- 
- LDFLAGS+= -L/usr/local/lib
- .ifdef PROFILE
Index: patches/patch-fdm.h
===================================================================
RCS file: /cvsroot/pkgsrc/mail/fdm/patches/patch-fdm.h,v
retrieving revision 1.1
diff -u -r1.1 patch-fdm.h
--- patches/patch-fdm.h	23 Aug 2012 18:04:12 -0000	1.1
+++ patches/patch-fdm.h	30 Sep 2013 17:48:51 -0000
@@ -1,5 +1,8 @@
 $NetBSD: patch-fdm.h,v 1.1 2012/08/23 18:04:12 marino Exp $

+MAXNAMLEN is not POSIX. For systems that does not define it use NAME_MAX
+macro instead.
+
 --- fdm.h.orig	2012-08-23 17:13:57.000000000 +0000
 +++ fdm.h
 @@ -71,6 +71,10 @@

>Release-Note:

>Audit-Trail:

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/48254: Update mail/fdm to 1.7
Date: Wed, 02 Oct 2013 21:12:22 +0900

 On Tue, 01 Oct 2013 03:25:00 +0900, Leonardo Taccari <iamleot@gmail.com> wrote:

 > 	I tried to improve the package in various ways:
 > 	 * Properly use the SUBST framework (and get rid of patches/patch-aa)

 SUBST might cause unwanted changes, so it may be danger.
 You can use BSD_INSTALL_PROGRAM (and so on) in Makefile, and just a patch
 will be sufficient.

 > 	 * MANUAL is now generated via an awk(1) script. Add a line to
 > 	   post-install target accordingly.

 It should be done with `post-build' target.
 `post-install' may be triggered with privileged user with some build configuration,
 and `MANUAL' will be created as owned by the privileged user, then `make clean' will
 be result in `permission denied'.

 > 	 * Various cosmetic changes to Makefile (inspired by
 > 	   pkgsrc/doc/Makefile-example, please email me regarding any mistakes
 > 	   that I've done!)

 Not mistakes, but `Makefile-example' is just a example, so no need to do so much :)

 -- 
 OBATA Akio / obache@NetBSD.org

From: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@NetBSD.org, OBATA Akio <obache@netbsd.org>,
	pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Cc: 
Subject: Re: pkg/48254: Update mail/fdm to 1.7
Date: Thu, 3 Oct 2013 01:47:04 +0200

 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 Hello OBATA!

 On Wed, Oct 02, 2013 at 12:15:00PM +0000, OBATA Akio wrote:
 >  SUBST might cause unwanted changes, so it may be danger.
 >  You can use BSD_INSTALL_PROGRAM (and so on) in Makefile, and just a patch
 >  will be sufficient.
 A patch usually are a bit clearer than few REs.
 However, I prefer to use SUBST in this case because it usually simplify
 the update to a new version.
 Here should not be danger because the REs will substitute only
 variables that are (re)assigned.

 >  It should be done with `post-build' target.
 >  `post-install' may be triggered with privileged user with some build configuration,
 >  and `MANUAL' will be created as owned by the privileged user, then `make clean' will
 >  be result in `permission denied'.
 Sorry for that, I will attach a new diff!


 Thank you for clarification,
 Ciao,
 L.

 --xHFwDpU9dbj6ez1V
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=fdm-patches

 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/fdm/Makefile,v
 retrieving revision 1.4
 diff -u -r1.4 Makefile
 --- Makefile	6 Feb 2013 23:22:44 -0000	1.4
 +++ Makefile	2 Oct 2013 23:24:44 -0000
 @@ -1,9 +1,7 @@
  # $NetBSD: Makefile,v 1.4 2013/02/06 23:22:44 jperkin Exp $

 -DISTNAME=		fdm-1.6
 -PKGREVISION=		1
 +DISTNAME=		fdm-1.7
  CATEGORIES=		mail
 -PKG_REVISION=		1
  MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=fdm/}

  MAINTAINER=		pkgsrc-users@NetBSD.org
 @@ -11,27 +9,32 @@
  COMMENT=		Fetch or receive mail and deliver it in various ways
  LICENSE=		modified-bsd

 -INSTALLATION_DIRS+=	${EGDIR} ${DOCDIR}
 -EGDIR=			${PREFIX}/share/examples/fdm
  DOCDIR=			${PREFIX}/share/doc/fdm
 +EGDIR=			${PREFIX}/share/examples/fdm
 +HAS_CONFIGURE=		yes
 +INSTALLATION_DIRS+=	${DOCDIR} ${EGDIR}

  USE_TOOLS+=		pax
 -MAKE_ENV+=		PCRE=1

 -SUBST_CLASSES+=		files
 -SUBST_STAGE.files=	post-patch
 -SUBST_FILES.files=	Makefile
 -SUBST_SED.files=	-e "s|@INSTALL_PROGRAM_DIR@|${INSTALL_PROGRAM_DIR}|"
 -SUBST_SED.files+=	-e "s|@INSTALL_PROGRAM@|${INSTALL_PROGRAM}|"
 -SUBST_SED.files+=	-e "s|@INSTALL_MAN@|${INSTALL_MAN}|"
 -SUBST_MESSAGE.files=	Fixing install invocation in Makefile
 +SUBST_CLASSES+=		makefile
 +SUBST_STAGE.makefile=	post-patch
 +SUBST_MESSAGE.makefile=	Fixing install invocation in Makefile
 +SUBST_FILES.makefile=	Makefile
 +SUBST_SED.makefile+=	-e '/^FDEBUG=/d'	# Disable debug options
 +SUBST_SED.makefile+=	-E -e 's,(INSTALLDIR=).*,\1 ${INSTALL_PROGRAM_DIR:Q},'
 +SUBST_SED.makefile+=	-E -e 's,(INSTALLBIN=).*,\1 ${INSTALL_PROGRAM:Q},'
 +SUBST_SED.makefile+=	-E -e 's,(INSTALLMAN=).*,\1 ${INSTALL_MAN:Q},'
 +
 +.include "options.mk"
 +.include "../../databases/tdb/buildlink3.mk"
 +.include "../../devel/zlib/buildlink3.mk"
 +.include "../../security/openssl/buildlink3.mk"
 +
 +post-build:
 +	cd ${WRKSRC} && ${MAKE_PROGRAM} -f ${WRKSRC}/tools/dist.mk manual

  post-install:
  	cd ${WRKSRC}/examples && pax -rwpam . ${DESTDIR}${EGDIR}
  	${INSTALL_DATA} ${WRKSRC}/MANUAL ${DESTDIR}${DOCDIR}

 -.include "../../security/openssl/buildlink3.mk"
 -.include "../../devel/zlib/buildlink3.mk"
 -.include "../../devel/pcre/buildlink3.mk"
 -.include "../../databases/tdb/buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: PLIST
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/fdm/PLIST,v
 retrieving revision 1.1.1.1
 diff -u -r1.1.1.1 PLIST
 --- PLIST	17 Aug 2012 17:45:40 -0000	1.1.1.1
 +++ PLIST	2 Oct 2013 23:24:44 -0000
 @@ -1,11 +1,10 @@
 -@comment $NetBSD: PLIST,v 1.1.1.1 2012/08/17 17:45:40 seb Exp $
 +@comment $NetBSD$
  bin/fdm
  man/man1/fdm.1
  man/man5/fdm.conf.5
  share/doc/fdm/MANUAL
  share/examples/fdm/f-terbeck.conf
  share/examples/fdm/g-lando.conf
 -share/examples/fdm/n-marriott-old.conf
  share/examples/fdm/n-marriott.conf
  share/examples/fdm/t-ulmer.conf
  share/examples/fdm/w-maier.conf
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/fdm/distinfo,v
 retrieving revision 1.2
 diff -u -r1.2 distinfo
 --- distinfo	23 Aug 2012 18:04:12 -0000	1.2
 +++ distinfo	2 Oct 2013 23:24:44 -0000
 @@ -1,7 +1,6 @@
  $NetBSD: distinfo,v 1.2 2012/08/23 18:04:12 marino Exp $

 -SHA1 (fdm-1.6.tar.gz) = fb8042f2355062848ff142c9604069b6657e6a82
 -RMD160 (fdm-1.6.tar.gz) = 7e2c846b97dce20e123b8453732e107f88e0de8f
 -Size (fdm-1.6.tar.gz) = 192159 bytes
 -SHA1 (patch-aa) = 4284d7fc2e88fc9d42fc861e19a890dd526354d6
 -SHA1 (patch-fdm.h) = 03ad0167120e06e76f4f1ef086c918c6a0cccf55
 +SHA1 (fdm-1.7.tar.gz) = 5534d1ec1831794e092e0821db70f36b7e1ee961
 +RMD160 (fdm-1.7.tar.gz) = 942f0989501645aa7e04bd428510daa309e8fca6
 +Size (fdm-1.7.tar.gz) = 199808 bytes
 +SHA1 (patch-fdm.h) = 5119757e747908a45ca778fe8d27d7944e37125f
 Index: options.mk
 ===================================================================
 RCS file: options.mk
 diff -N options.mk
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ options.mk	2 Oct 2013 23:24:44 -0000
 @@ -0,0 +1,22 @@
 +# $NetBSD$
 +
 +PKG_OPTIONS_VAR=	PKG_OPTIONS.fdm
 +PKG_SUPPORTED_OPTIONS=	debug pcre
 +PKG_SUGGESTED_OPTIONS=	pcre
 +
 +.include "../../mk/bsd.options.mk"
 +
 +#
 +# Debug
 +#
 +.if !empty(PKG_OPTIONS:Mdebug)
 +   MAKE_ENV+=	FDEBUG=1
 +.endif
 +
 +#
 +# PCRE support
 +#
 +.if !empty(PKG_OPTIONS:Mpcre)
 +   MAKE_ENV+=	PCRE=1
 +.  include "../../devel/pcre/buildlink3.mk"
 +.endif
 Index: patches/patch-aa
 ===================================================================
 RCS file: patches/patch-aa
 diff -N patches/patch-aa
 --- patches/patch-aa	23 Aug 2012 18:04:12 -0000	1.2
 +++ /dev/null	1 Jan 1970 00:00:00 -0000
 @@ -1,38 +0,0 @@
 -$NetBSD: patch-aa,v 1.2 2012/08/23 18:04:12 marino Exp $
 -
 -cleanup cpp args dans adjust/fix Darwin build
 -
 ---- Makefile.orig	2008-12-22 16:20:05.000000000 +0000
 -+++ Makefile
 -@@ -37,7 +37,7 @@ HDRS= fdm.h array.h fetch.h match.h deli
 - YACC= yacc -d
 - 
 - CC?= cc
 --INCDIRS+= -I. -I- -I/usr/local/include
 -+INCDIRS+= -I. 
 - .ifdef PROFILE
 - # Don't use ccache
 - CC= /usr/bin/gcc
 -@@ -70,7 +70,8 @@ LIBS+= -lpcre
 - .if ${OS} == "Darwin"
 - SRCS+= compat/strtonum.c
 - INCDIRS+= -Icompat -I/usr/local/include/openssl
 --CFLAGS+= -DNO_STRTONUM -DNO_SETRESUID -DNO_SETRESGID -DNO_SETPROCTITLE
 -+CFLAGS+= -DNO_STRTONUM -DNO_SETRESUID -DNO_SETRESGID -DNO_SETPROCTITLE -DNO_QUEUE_H -DNO_TREE_H
 -+LIBS+=	-lresolv
 - .endif
 - 
 - # NetBSD
 -@@ -93,9 +94,9 @@ CFLAGS+= -DNO_STRTONUM
 - .endif
 - 
 - PREFIX?= /usr/local
 --INSTALLDIR= install -d
 --INSTALLBIN= install -g bin -o root -m 555
 --INSTALLMAN= install -g bin -o root -m 444
 -+INSTALLDIR= @INSTALL_PROGRAM_DIR@
 -+INSTALLBIN= @INSTALL_PROGRAM@
 -+INSTALLMAN= @INSTALL_MAN@
 - 
 - LDFLAGS+= -L/usr/local/lib
 - .ifdef PROFILE
 Index: patches/patch-fdm.h
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mail/fdm/patches/patch-fdm.h,v
 retrieving revision 1.1
 diff -u -r1.1 patch-fdm.h
 --- patches/patch-fdm.h	23 Aug 2012 18:04:12 -0000	1.1
 +++ patches/patch-fdm.h	2 Oct 2013 23:24:44 -0000
 @@ -1,5 +1,8 @@
  $NetBSD: patch-fdm.h,v 1.1 2012/08/23 18:04:12 marino Exp $

 +MAXNAMLEN is not POSIX. For systems that does not define it use NAME_MAX
 +macro instead.
 +
  --- fdm.h.orig	2012-08-23 17:13:57.000000000 +0000
  +++ fdm.h
  @@ -71,6 +71,10 @@

 --xHFwDpU9dbj6ez1V--

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/48254: Update mail/fdm to 1.7
Date: Thu, 03 Oct 2013 19:39:30 +0900

 On Thu, 03 Oct 2013 08:45:00 +0900, Leonardo Taccari <iamleot@gmail.com> wrote:

 >  On Wed, Oct 02, 2013 at 12:15:00PM +0000, OBATA Akio wrote:
 >  >  SUBST might cause unwanted changes, so it may be danger.
 >  >  You can use BSD_INSTALL_PROGRAM (and so on) in Makefile, and just a patch
 >  >  will be sufficient.
 >  A patch usually are a bit clearer than few REs.
 >  However, I prefer to use SUBST in this case because it usually simplify
 >  the update to a new version.
 >  Here should not be danger because the REs will substitute only
 >  variables that are (re)assigned.

 An advantage is a disadvantage from another perspective.

 Anyway, `-E' option of sed(1) is not portable, so it must not be used there.

 -- 
 OBATA Akio / obache@NetBSD.org

State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Thu, 03 Oct 2013 11:13:32 +0000
State-Changed-Why:
Updated.


From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48254 CVS commit: pkgsrc/mail/fdm
Date: Thu, 3 Oct 2013 11:12:43 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Thu Oct  3 11:12:43 UTC 2013

 Modified Files:
 	pkgsrc/mail/fdm: Makefile PLIST distinfo
 	pkgsrc/mail/fdm/patches: patch-aa patch-fdm.h
 Added Files:
 	pkgsrc/mail/fdm: options.mk

 Log Message:
 Update fdm to 1.7.
 Based on PR pkg/48254 by Leonardo Taccari.

 pkgsrc changes:
  * add options.mk: now fdm supports "debug" and "pcre" options (previously the
    PCRE support was always included).

 Changes:
  * Add mbox tags for messages fetched from a mbox
  * Detect GMail's XYZZY capability for IMAP and use it to try and workaround
    some of their broken behaviour (incorrectly reported message sizes).
  * Print a warning on missing maildirs when fetching from them rather than
    crashing or giving an error. Reported by Frank Terbeck.
  * Introduce a configure script and tidy up build infrastructure.
  * GMail IMAP doesn't correctly set the \Seen flag after UID FETCH BODY[], so
    explicitly set it with STORE when mail is kept. Reported by Patrice Clement.
  * Properly count mails when polling multiple folders on a single IMAP server,
    reported by Claudio M. Alessi.
  * Support user and pass on NNTP, requested by Michael Hamann.
  * Escape . properly when delivering to SMTP.
  * Don't be as strict about format at the end of messages when using IMAP -
    accept additional information as well as FLAGS. Reported by rivo nurges.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/mail/fdm/Makefile
 cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/mail/fdm/PLIST
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/mail/fdm/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/mail/fdm/options.mk
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/mail/fdm/patches/patch-aa
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/mail/fdm/patches/patch-fdm.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Leonardo Taccari <iamleot@gmail.com>
To: gnats-bugs@NetBSD.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org, OBATA Akio <obache@netbsd.org>
Cc: 
Subject: Re: pkg/48254: Update mail/fdm to 1.7
Date: Thu, 3 Oct 2013 14:05:33 +0200

 Hello OBATA,

 On Thu, Oct 03, 2013 at 10:45:00AM +0000, OBATA Akio wrote:
 >  An advantage is a disadvantage from another perspective.
 Indeed the way you handled it is longer but a "bit" more readable and
 cleaner. :)

 >  Anyway, `-E' option of sed(1) is not portable, so it must not be used there.
 Ops, I did not know that... It would be a good idea to add a brief note
 to the guide or maybe mk/subst.mk, isn't it?
 I will attach a small patch that does the latter. Feel free to
 change/improve/ignore it!


 Thank you again,
 Keep up the good work!
 Ciao,
 L.

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48254 CVS commit: pkgsrc/mk
Date: Sun, 13 Oct 2013 21:38:36 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sun Oct 13 21:38:36 UTC 2013

 Modified Files:
 	pkgsrc/mk: subst.mk

 Log Message:
 Add note to SUBST_SED noting that -E is not a standard sed option.
 From Leonardo Taccari in followup to PR 48254.


 To generate a diff of this commit:
 cvs rdiff -u -r1.53 -r1.54 pkgsrc/mk/subst.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.