NetBSD Problem Report #48309

From t-hash@abox3.so-net.ne.jp  Sun Oct 13 16:45:29 2013
Return-Path: <t-hash@abox3.so-net.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 897AB7261B
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 13 Oct 2013 16:45:29 +0000 (UTC)
Message-Id: <201310131645.r9DGjO0H013928@ms-omx11.plus.so-net.ne.jp>
Date: Mon, 14 Oct 2013 01:45:24 +0900
From: Takahiro HAYASHI <t-hash@abox3.so-net.ne.jp>
To: gnats-bugs@gnats.NetBSD.org
Subject: msk(4) cannot change link address

>Number:         48309
>Category:       kern
>Synopsis:       msk(4) cannot change link address
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Oct 13 16:50:00 +0000 2013
>Closed-Date:    Wed Jun 01 03:40:52 +0000 2016
>Last-Modified:  Wed Jun 01 03:40:52 +0000 2016
>Originator:     Takahiro HAYASHI
>Release:        NetBSD 6.99.24
>Organization:
>Environment:
System: NetBSD ruin 6.99.24 NetBSD 6.99.24 (UNION) #0: Wed Oct  9 08:34:24 JST 2013 root@halt:/usr/build2/obj.i386/sys/arch/i386/compile/UNION i386
Architecture: i386
Machine: i386
>Description:
	msk(4) cannot change it's link address
	because the driver does not update sc with new link address in ifp
	when it's link address has been changed.

>How-To-Repeat:
	assign another link address on msk, ifconfig msk down up, and
	ping from other host.

>Fix:
	Please fill sc_if->sk_enaddr with CLLADDR(ifp->if_sadl) before
	writing to unicast filter registers in msk_init_yukon().

--
t-hash

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/48309: msk(4) cannot change link address
Date: Sun, 13 Oct 2013 20:12:29 +0000

 On Sun, Oct 13, 2013 at 04:50:00PM +0000, Takahiro HAYASHI wrote:
  > >Fix:
  > 	Please fill sc_if->sk_enaddr with CLLADDR(ifp->if_sadl) before
  > 	writing to unicast filter registers in msk_init_yukon().

 If you prepare a patch (either for this or 48310), I expect it will
 get committed rapidly...

 -- 
 David A. Holland
 dholland@netbsd.org

From: Takahiro HAYASHI <t-hash@abox3.so-net.ne.jp>
To: David Holland <dholland-bugs@netbsd.org>, gnats-bugs@NetBSD.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/48309: msk(4) cannot change link address
Date: Mon, 14 Oct 2013 09:40:12 +0900

 On Sun, 13 Oct 2013 20:15:00 +0000 (UTC)
 David Holland <dholland-bugs@netbsd.org> wrote:

 > The following reply was made to PR kern/48309; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-bugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: kern/48309: msk(4) cannot change link address
 > Date: Sun, 13 Oct 2013 20:12:29 +0000
 > 
 >  On Sun, Oct 13, 2013 at 04:50:00PM +0000, Takahiro HAYASHI wrote:
 >   > >Fix:
 >   > 	Please fill sc_if->sk_enaddr with CLLADDR(ifp->if_sadl) before
 >   > 	writing to unicast filter registers in msk_init_yukon().
 >  
 >  If you prepare a patch (either for this or 48310), I expect it will
 >  get committed rapidly...

 This is the patch for HEAD, netbsd-6 and netbsd-5.


 Index: src/sys/dev/pci/if_msk.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pci/if_msk.c,v
 retrieving revision 1.43
 diff -u -p -r1.43 if_msk.c
 --- src/sys/dev/pci/if_msk.c	30 Mar 2013 03:21:06 -0000	1.43
 +++ src/sys/dev/pci/if_msk.c	29 Sep 2013 13:35:13 -0000
 @@ -2036,6 +2036,11 @@ msk_init_yukon(struct sk_if_softc *sc_if

  	DPRINTFN(6, ("msk_init_yukon: 10\n"));
  	/* Setup Yukon's address */
 +	struct ifnet *ifp = &sc_if->sk_ethercom.ec_if;
 +	/* msk_attach calls me before ether_ifattach so check null */
 +	if (ifp != NULL && ifp->if_sadl != NULL)
 +		memcpy(sc_if->sk_enaddr, CLLADDR(ifp->if_sadl),
 +		    sizeof(sc_if->sk_enaddr));
  	for (i = 0; i < 3; i++) {
  		/* Write Source Address 1 (unicast filter) */
  		SK_YU_WRITE_2(sc_if, YUKON_SAL1 + i * 4,

 --
 t-hash

From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48309 CVS commit: src/sys/dev/pci
Date: Wed, 1 Jun 2016 03:37:35 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Wed Jun  1 03:37:35 UTC 2016

 Modified Files:
 	src/sys/dev/pci: if_msk.c

 Log Message:
 Commit patch from t-hash in PR kern/48309


 To generate a diff of this commit:
 cvs rdiff -u -r1.49 -r1.50 src/sys/dev/pci/if_msk.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Wed, 01 Jun 2016 03:40:52 +0000
Responsible-Changed-Why:
I handled it.


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 01 Jun 2016 03:40:52 +0000
State-Changed-Why:
Fix committed.


>Unformatted:

Home	PR Database Search