NetBSD Problem Report #48633

From martin@duskware.de  Mon Mar  3 15:58:02 2014
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2B9D0A583D
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  3 Mar 2014 15:58:02 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: List of architectures supporting fenv.h is multiplied
X-Send-Pr-Version: 3.95

>Number:         48633
>Category:       lib
>Synopsis:       List of architectures supporting fenv.h is multiplied
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 03 16:00:00 +0000 2014
>Closed-Date:    Tue Sep 10 15:45:34 +0000 2019
>Last-Modified:  Tue Sep 10 15:45:34 +0000 2019
>Originator:     Martin Husemann
>Release:        NetBSD 6.99.33
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD unpluged.duskware.de 6.99.33 NetBSD 6.99.33 (UNPLUGED) #17: Sun Mar 2 23:01:50 CET 2014 martin@night-owl.duskware.de:/usr/src/sys/arch/evbarm/compile/UNPLUGED evbarm
Architecture: earm
Machine: evbarm
>Description:
The list of architectures which support <fenv.h> is not centralized. Right
now there are at least three copies in the tree:
 - src/lib/libm/Makefile (spread in pieces, very ugly)
 - src/tests/lib/libm/Makefile
 - src/include/fenv.h

There should be a central place, like we have for other features 
(e.g. __HAVE_ATOMIC64_OPS) and it should not be duplicated.
>How-To-Repeat:
Code inspection
>Fix:
n/a

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/48633: List of architectures supporting fenv.h is multiplied
Date: Sun, 21 Dec 2014 13:00:55 +0100

 Two more (both bogus) variants can be found in

 	src/tests/lib/libc/gen

 and

 	src/tests/lib/libc/stdlib

 We urgently need to fix this!

 Would people prefer a generic __HAVE_FENV_H in <machine/types.h>
 or a makefile fragment includdable by all relevant makefiles like
 .include <bsd.fenv.mk> ?

 Martin

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48633 CVS commit: src/tests/lib
Date: Mon, 21 Dec 2015 12:11:24 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Dec 21 12:11:24 UTC 2015

 Modified Files:
 	src/tests/lib/libc/gen: Makefile
 	src/tests/lib/libc/stdlib: Makefile
 	src/tests/lib/libm: Makefile

 Log Message:
 While PR 48633 is not properly fixed, keep the additional lists of
 fenv-enabled architectures in sync.


 To generate a diff of this commit:
 cvs rdiff -u -r1.45 -r1.46 src/tests/lib/libc/gen/Makefile
 cvs rdiff -u -r1.25 -r1.26 src/tests/lib/libc/stdlib/Makefile
 cvs rdiff -u -r1.32 -r1.33 src/tests/lib/libm/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48633 CVS commit: src/tests/lib
Date: Tue, 22 Dec 2015 08:26:16 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Dec 22 08:26:16 UTC 2015

 Modified Files:
 	src/tests/lib/libc/gen: Makefile
 	src/tests/lib/libc/stdlib: Makefile
 	src/tests/lib/libm: Makefile

 Log Message:
 Sync list of fenv enabled architectures again (PR 48633), this time for mips
 addition.


 To generate a diff of this commit:
 cvs rdiff -u -r1.46 -r1.47 src/tests/lib/libc/gen/Makefile
 cvs rdiff -u -r1.26 -r1.27 src/tests/lib/libc/stdlib/Makefile
 cvs rdiff -u -r1.33 -r1.34 src/tests/lib/libm/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 09 Sep 2019 13:52:35 +0000
State-Changed-Why:
tests using the header now don't need a list of archs. is this satisfactory?


State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 10 Sep 2019 15:45:34 +0000
State-Changed-Why:
The libm makefile could use further cleanup, but the main issue is solved.


>Unformatted:

Home	PR Database Search