NetBSD Problem Report #48690

From www@NetBSD.org  Sun Mar 30 10:42:24 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E7DF0A5806
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 30 Mar 2014 10:42:24 +0000 (UTC)
Message-Id: <20140330104222.E1B9EA580A@mollari.NetBSD.org>
Date: Sun, 30 Mar 2014 10:42:22 +0000 (UTC)
From: 6bone@6bone.informatik.uni-leipzig.de
Reply-To: 6bone@6bone.informatik.uni-leipzig.de
To: gnats-bugs@NetBSD.org
Subject: ixg* driver doesn't compile
X-Send-Pr-Version: www-1.0

>Number:         48690
>Category:       kern
>Synopsis:       ixg* driver doesn't compile
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    christos
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 30 10:45:00 +0000 2014
>Closed-Date:    Thu Apr 10 06:17:47 +0000 2014
>Last-Modified:  Thu Apr 10 17:25:01 +0000 2014
>Originator:     Uwe Toenjes
>Release:        NetBSD-6.99.38 (amd64)
>Organization:
University of Leipzig
>Environment:
NetBSD ipv6event.rz.uni-leipzig.de 6.99.31 NetBSD 6.99.31 (MYCONF7) #0: Thu Feb 20 09:07:38 CET 2014  root@ipv6event.rz.uni-leipzig.de:/usr/obj/sys/arch/amd64/compile/MYCONF7 amd64
>Description:
the ixgbe driver for Intel 8259x based NICs doesn't compile
the ixgbe driver is not included in the ALL configuration for i386/amd64

Error message:

#   compile  GENERIC/ixgbe.o
/usr/src/obj/tooldir.NetBSD-6.99.31-amd64/bin/x86_64--netbsd-gcc
-mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -mno-avx -msoft-float
-ffreestanding -fno-zero-initialized-in-bss -O2 -fno-omit-frame-pointer
-fstack-protector -Wstack-protector --param ssp-buffer-size=1
-fno-strict-aliasing -fno-common -std=gnu99 -Werror -Wall -Wno-main
-Wno-format-zero-length -Wpointer-arith -Wmissing-prototypes
-Wstrict-prototypes -Wold-style-definition -Wswitch -Wshadow -Wcast-qual
-Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign -Wno-attributes
-Wextra -Wno-unused-parameter -Wold-style-definition -Wno-sign-compare
--sysroot=/usr/src/obj/destdir.amd64 -Damd64 -Dx86_64 -I.
-I/usr/src/sys/../common/include -I/usr/src/sys/arch -I/usr/src/sys
-nostdinc -DDIAGNOSTIC -DMAXUSERS=64 -D_KERNEL -D_KERNEL_OPT -std=gnu99
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/x86_64/string
-D_FORTIFY_SOURCE=2 -I/usr/src/sys/external/bsd/ipf
-I/usr/src/sys/external/isc/atheros_hal/dist
-I/usr/src/sys/external/isc/atheros_hal/ic
-I/usr/src/sys/external/bsd/drm/dist/bsd-core
-I/usr/src/sys/external/bsd/drm/dist/shared-core
-I/usr/src/sys/../common/include
-I/usr/src/sys/external/bsd/acpica/dist/include -c
/usr/src/sys/dev/pci/ixgbe/ixgbe.c
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_xmit':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:1767:31: error: variable 'txbuf_mapped'
set but not used [-Werror=unused-but-set-variable]
  struct ixgbe_tx_buf *txbuf, *txbuf_mapped;
                               ^
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_allocate_legacy':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:2264:6: error: variable 'rid' set but not
used [-Werror=unused-but-set-variable]
  int rid = 0;
      ^
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_free_pci_resources':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:2552:12: error: variable 'memrid' set but
not used [-Werror=unused-but-set-variable]
  int  rid, memrid;
            ^
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_setup_receive_ring':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:3912:12: error: variable 'dev' set but
not used [-Werror=unused-but-set-variable]
  device_t  dev;
            ^
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_rx_input':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:4292:19: error: variable 'ec' set but not
used [-Werror=unused-but-set-variable]
  struct ethercom *ec;
                   ^
/usr/src/sys/dev/pci/ixgbe/ixgbe.c: In function 'ixgbe_rx_checksum':
/usr/src/sys/dev/pci/ixgbe/ixgbe.c:4671:7: error: variable 'sctp' set but
not used [-Werror=unused-but-set-variable]
  bool sctp = FALSE;
       ^
cc1: all warnings being treated as errors
*** [ixgbe.o] Error code 1

>How-To-Repeat:
add the driver to the kernel configuration and compile

ixg*     at pci? dev ? function ?    # Intel 8259x 10GbE
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->christos
Responsible-Changed-By: tron@NetBSD.org
Responsible-Changed-When: Thu, 10 Apr 2014 06:17:47 +0000
Responsible-Changed-Why:
Christos Zoulas committed the fixes.


State-Changed-From-To: open->closed
State-Changed-By: tron@NetBSD.org
State-Changed-When: Thu, 10 Apr 2014 06:17:47 +0000
State-Changed-Why:
Thanks a lot for the bug report and the patch.


From: Bernd Ernesti <netbsd@lists.veego.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/48690 (ixg* driver doesn't compile)
Date: Thu, 10 Apr 2014 08:33:40 +0200

 Please see the comment from Masanobu SAITOH on
 http://mail-index.netbsd.org/current-users/2014/04/09/msg024658.html

From: Masanobu SAITOH <msaitoh@execsw.org>
To: gnats-bugs@NetBSD.org, christos@NetBSD.org, gnats-admin@netbsd.org, 
 netbsd-bugs@netbsd.org, 6bone@6bone.informatik.uni-leipzig.de
Cc: msaitoh@execsw.org
Subject: Re: kern/48690 (ixg* driver doesn't compile)
Date: Thu, 10 Apr 2014 19:12:50 +0900

 (2014/04/10 15:40), Bernd Ernesti wrote:
 > The following reply was made to PR kern/48690; it has been noted by GNATS.
 > 
 > From: Bernd Ernesti <netbsd@lists.veego.de>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: kern/48690 (ixg* driver doesn't compile)
 > Date: Thu, 10 Apr 2014 08:33:40 +0200
 > 
 >   Please see the comment from Masanobu SAITOH on
 >   http://mail-index.netbsd.org/current-users/2014/04/09/msg024658.html

  Those mails' problem is different from the compilation fail problem
 though both of them are about the same driver :-)

 -- 
 -----------------------------------------------
                 SAITOH Masanobu (msaitoh@execsw.org
                                  msaitoh@netbsd.org)

From: christos@zoulas.com (Christos Zoulas)
To: Masanobu SAITOH <msaitoh@execsw.org>, gnats-bugs@NetBSD.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	6bone@6bone.informatik.uni-leipzig.de
Cc: 
Subject: Re: kern/48690 (ixg* driver doesn't compile)
Date: Thu, 10 Apr 2014 09:01:17 -0400

 On Apr 10,  7:12pm, msaitoh@execsw.org (Masanobu SAITOH) wrote:
 -- Subject: Re: kern/48690 (ixg* driver doesn't compile)

 |  Those mails' problem is different from the compilation fail problem
 | though both of them are about the same driver :-)
 | 

 | http://mail-index.netbsd.org/current-users/2014/04/09/msg024658.html

 Yes, and it is not clear what needs to be done by the statement that
 this is a DELL clone.

 christos

From: Hisashi T Fujinaka <htodd@twofifty.com>
To: Christos Zoulas <christos@zoulas.com>
Cc: Masanobu SAITOH <msaitoh@execsw.org>, gnats-bugs@NetBSD.org, 
    gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
    6bone@6bone.informatik.uni-leipzig.de
Subject: Re: kern/48690 (ixg* driver doesn't compile)
Date: Thu, 10 Apr 2014 10:20:09 -0700 (PDT)

 On Thu, 10 Apr 2014, Christos Zoulas wrote:

 > Yes, and it is not clear what needs to be done by the statement that
 > this is a DELL clone.

 Different PCIe device ID. I didn't check to see if you do a two match or
 a four match.

 -- 
 Hisashi T Fujinaka - htodd@twofifty.com
 BSEE(6/86) + BSChem(3/95) + BAEnglish(8/95) + MSCS(8/03) + $2.50 = latte

>Unformatted:

Home	PR Database Search