NetBSD Problem Report #48809
From www@NetBSD.org Wed May 14 08:54:14 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
by mollari.NetBSD.org (Postfix) with ESMTPS id 9CBDBA5850
for <gnats-bugs@gnats.NetBSD.org>; Wed, 14 May 2014 08:54:14 +0000 (UTC)
Message-Id: <20140514085406.C1D3FA5853@mollari.NetBSD.org>
Date: Wed, 14 May 2014 08:54:06 +0000 (UTC)
From: vs@nifelheim.info
Reply-To: vs@nifelheim.info
To: gnats-bugs@NetBSD.org
Subject: Through a bug in x11/xfce4-exo, Thunar stops changing into directories in "detailled view" after some clicks
X-Send-Pr-Version: www-1.0
>Number: 48809
>Category: pkg
>Synopsis: Through a bug in x11/xfce4-exo, Thunar stops changing into directories in "detailled view" after some clicks
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed May 14 08:55:00 +0000 2014
>Closed-Date: Sun Jul 26 15:34:25 +0000 2015
>Last-Modified: Sun Jul 26 15:34:25 +0000 2015
>Originator: Volkmar Seifert
>Release: NetBSD 6.1_STABLE
>Organization:
>Environment:
NetBSD SnowLion.home.nifelheim.info 6.1_STABLE NetBSD 6.1_STABLE (GENERIC) #1: Fri May 9 12:48:47 CEST 2014 mjoellnir@cheetah:/work/netbsd/v6/work/i386/GENERIC/obj/work/netbsd/v6/src/sys/arch/i386/compile/GENERIC i386
>Description:
If in "detailled view", Thunar stops changing into directories after a few clicks. This is caused by a bug in x11/xfce4-exo.
A fix for this bug has been around since a couple of years, plus the package is quite outdated like the rest of XFCE4.
>How-To-Repeat:
Open Thunar, switch to "Detailled View", click around directories, it won't take long until the freeze hits.
>Fix:
As mentioned above, there's a patch [1] around for this bug [2] since 2010. I have applied this patch to x11/xfce4-exo and tested it on my machine. Thunar is behaving as it should, now.
[1] https://bugzilla.xfce.org/attachment.cgi?id=2940
[2] https://bugzilla.xfce.org/show_bug.cgi?id=6230
>Release-Note:
>Audit-Trail:
From: Volkmar Seifert <vs@dimensionv.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/48809: Through a bug in x11/xfce4-exo, Thunar stops
changing into directories in "detailled view" after some clicks
Date: Wed, 14 May 2014 11:02:13 +0200
This is a multi-part message in MIME format.
--Multipart=_Wed__14_May_2014_11_02_13_+0200_XibMe+4DZl7i6yEi
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Here are the pkgsrc-specific patches as attachments.
- x11_xfce4-exo.patch contains the changes to Makefile and distinfo
- patch-exo_exo-tree-view.c contains the actual patch to the code.
Volkmar
-
On Wed, 14 May 2014 08:55:00 +0000 (UTC)
vs@nifelheim.info wrote:
> >Number: 48809
> >Category: pkg
> >Synopsis: Through a bug in x11/xfce4-exo, Thunar stops
> >changing into directories in "detailled view" after some clicks
> >Confidential: no Severity: serious
> >Priority: medium
> >Responsible: pkg-manager
> >State: open
> >Class: sw-bug
> >Submitter-Id: net
> >Arrival-Date: Wed May 14 08:55:00 +0000 2014
> >Originator: Volkmar Seifert
> >Release: NetBSD 6.1_STABLE
> >Organization:
> >Environment:
> NetBSD SnowLion.home.nifelheim.info 6.1_STABLE NetBSD 6.1_STABLE
> (GENERIC) #1: Fri May 9 12:48:47 CEST 2014
> mjoellnir@cheetah:/work/netbsd/v6/work/i386/GENERIC/obj/work/netbsd/v6/src/sys/arch/i386/compile/GENERIC
> i386
> >Description:
> If in "detailled view", Thunar stops changing into directories after
> a few clicks. This is caused by a bug in x11/xfce4-exo. A fix for
> this bug has been around since a couple of years, plus the package is
> quite outdated like the rest of XFCE4.
> >How-To-Repeat:
> Open Thunar, switch to "Detailled View", click around directories, it
> won't take long until the freeze hits.
> >Fix:
> As mentioned above, there's a patch [1] around for this bug [2] since
> 2010. I have applied this patch to x11/xfce4-exo and tested it on my
> machine. Thunar is behaving as it should, now.
>
>
> [1] https://bugzilla.xfce.org/attachment.cgi?id=2940
> [2] https://bugzilla.xfce.org/show_bug.cgi?id=6230
>
--
http://www.dimensionv.de/
http://tech.nifelheim.info/
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
OpenPGP
Fingerprint: E03D 33DB B409 2E99 C2DA 7D64 145F 0A76 D252 7078
Key: http://www.dimensionv.de/pgp (+ all public key-servers)
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
--Multipart=_Wed__14_May_2014_11_02_13_+0200_XibMe+4DZl7i6yEi
Content-Type: text/plain;
name="patch-exo_exo-tree-view.c"
Content-Disposition: attachment;
filename="patch-exo_exo-tree-view.c"
Content-Transfer-Encoding: quoted-printable
--- exo/exo-tree-view.c 2009-12-12 13:19:12.000000000 +0100
+++ exo/exo-tree-view.c 2010-04-16 23:43:51.212286473 +0200
@@ -373,6 +373,15 @@
/* call the parent's button press handler */
result =3D (*GTK_WIDGET_CLASS (exo_tree_view_parent_class)->button_press=
_event) (widget, event);
=20
+ /* ugly fix for http://bugzilla.xfce.org/show_bug.cgi?id=3D6230 */
+ if (G_LIKELY (selection->user_func =3D=3D (GtkTreeSelectionFunc) exo_noo=
p_false))
+ {
+ /* just reset the select function (previously set to exo_noop_false),
+ * there's no clean way to do this, so what the heck.
+ */
+ selection->user_func =3D NULL;
+ }
+
/* restore previous selection if the path is still selected */
if (event->type =3D=3D GDK_BUTTON_PRESS && (event->state & gtk_accelerat=
or_get_default_mod_mask ()) =3D=3D 0
&& path !=3D NULL && gtk_tree_selection_path_is_selected (selection,=
path))
--Multipart=_Wed__14_May_2014_11_02_13_+0200_XibMe+4DZl7i6yEi
Content-Type: text/plain;
name="x11_xfce4-exo.patch"
Content-Disposition: attachment;
filename="x11_xfce4-exo.patch"
Content-Transfer-Encoding: quoted-printable
Index: Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/pkgsrc/x11/xfce4-exo/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile 5 May 2014 00:48:37 -0000 1.36
+++ Makefile 14 May 2014 08:44:40 -0000
@@ -6,7 +6,7 @@
=20
DISTNAME=3D exo-${XFCE4_VERSION}
PKGNAME=3D xfce4-exo-${XFCE4_VERSION}
-PKGREVISION=3D 25
+PKGREVISION=3D 26
CATEGORIES=3D x11
COMMENT=3D Xfce extension library
=20
Index: distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/pkgsrc/x11/xfce4-exo/distinfo,v
retrieving revision 1.8
diff -u -r1.8 distinfo
--- distinfo 16 Aug 2013 06:45:12 -0000 1.8
+++ distinfo 14 May 2014 08:44:40 -0000
@@ -7,3 +7,4 @@
SHA1 (patch-ae) =3D 18a95737a6eaef8697224d4c099625c18be7ddfb
SHA1 (patch-af) =3D 86aee9fdf075c2de36deeebbb7594193e92cde95
SHA1 (patch-exo-mount-notify_main.c) =3D 99892d72b240e90faa75bc91ae32308ac=
eeb0b17
+SHA1 (patch-exo_exo-tree-view.c) =3D 17b66df0cc8722644bbd6677e3ed6f5be5416=
d55
--Multipart=_Wed__14_May_2014_11_02_13_+0200_XibMe+4DZl7i6yEi--
State-Changed-From-To: open->feedback
State-Changed-By: youri@NetBSD.org
State-Changed-When: Tue, 07 Jul 2015 15:39:04 +0000
State-Changed-Why:
Can you still reproduce this? I tried with thunar 1.6.10 and I can't.
State-Changed-From-To: feedback->closed
State-Changed-By: youri@NetBSD.org
State-Changed-When: Sun, 26 Jul 2015 15:34:25 +0000
State-Changed-Why:
Can't reproduce and poster seems inactive.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.