NetBSD Problem Report #48846

From www@NetBSD.org  Thu May 29 06:46:23 2014
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id A6A49A5813
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 29 May 2014 06:46:23 +0000 (UTC)
Message-Id: <20140529064622.0E477A651E@mollari.NetBSD.org>
Date: Thu, 29 May 2014 06:46:22 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Add missing braces in if_il.c
X-Send-Pr-Version: www-1.0

>Number:         48846
>Category:       kern
>Synopsis:       Add missing braces in if_il.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 29 06:50:00 +0000 2014
>Closed-Date:    Thu May 29 07:08:23 +0000 2014
>Last-Modified:  Thu May 29 07:10:00 +0000 2014
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:
Error found by cppcheck of if_il.c .
>How-To-Repeat:

>Fix:
diff -u -p -r1.26 if_il.c
--- sys/dev/qbus/if_il.c	27 Oct 2012 17:18:37 -0000	1.26
+++ sys/dev/qbus/if_il.c	30 Apr 2014 10:35:08 -0000
@@ -332,7 +332,7 @@ ilinit(struct ifnet *ifp)
 		addr->il_csr = ILC_ALLMC;
 		if (ilwait(ui, "all multi"))
 			return 0;
-	else {
+	} else {
 		int i;
 		register struct ether_addr *ep = is->is_maddrs;
 		struct ether_multi *enm;

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Thu, 29 May 2014 07:08:23 +0000
State-Changed-Why:
Committed, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/48846 CVS commit: src/sys/dev/qbus
Date: Thu, 29 May 2014 07:08:10 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Thu May 29 07:08:10 UTC 2014

 Modified Files:
 	src/sys/dev/qbus: if_il.c

 Log Message:
 Add missing braces. From Henning Petersen in PR 48846.


 To generate a diff of this commit:
 cvs rdiff -u -r1.26 -r1.27 src/sys/dev/qbus/if_il.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search